Skip to content

Add improvements to new networks features #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jan 20, 2025
Merged

Add improvements to new networks features #439

merged 30 commits into from
Jan 20, 2025

Conversation

@heisbrot
Copy link
Contributor

@heisbrot heisbrot commented Jan 13, 2025 •
edited
Loading

Fixes:

  • Keep peers page sort order when switching between single peer and peers overview page
  • Fix the issue when hovering over a group badge that simultaneously has truncated text instantly hides the other groups
  • Add resource counter to groups page (settings)
  • Remove resource counter in access control policy for source groups to make it clearer that resource should be set as the destination for now

UI:

  • Update sidebar navigation and remove deprecation notice for network routes
  • Switched the flow creating a network (Network - Resource - Policy - Routing Peers)

Feature:

  • Add search to resource table inside networks
  • Add enable toggle for resource and routing peers
  • Add option to install NetBird after a Setup Key has been created
  • Add option to install NetBird in Routing Peer modal (New Networks)

CleanShot 2025-01-20 at 11 37 18
CleanShot 2025-01-20 at 11 37 46
CleanShot 2025-01-20 at 11 37 54
CleanShot 2025-01-20 at 11 38 05

heisbrot added 15 commits January 9, 2025 10:18
@heisbrot
Fix wrong ui state for routing peer modal in networks
f68bff7
@heisbrot
Add confirmation dialog when blocking users
67fd256
@heisbrot
Keep peer sort order when switching pages
786efb7
@heisbrot
Update sidebar navigation order and remove deprecation notice
1e5824c
@heisbrot
Fix issue when hovering over truncated text in a group badge closes t…
f81c567 
…he multiple groups popover
@heisbrot
Update group text in network resource modal
766b2d4
@heisbrot
Update networks page text
4d1428f
@heisbrot
Fix line height
52890c0
@heisbrot
Add search to resource table
4f066b9
@heisbrot
Switch networks flow to create first resources and then add routers
5672b41
@heisbrot
Merge branch 'fix/networks-masquerade' into feature/networks-improvem…
acf0a4e 
…ents
@heisbrot
Merge branch 'ux/user-blocking-confirmation' into feature/networks-im…
8b23aa6 
…provements
@heisbrot
Add enabled toggle to routing peers
a541b73
@heisbrot
Add enabled toggle to network resources
92eef5f
@heisbrot
Add resource group modal and adjust tables
449344f
braginini
braginini reviewed Jan 14, 2025
View reviewed changes
braginini and others added 14 commits January 14, 2025 13:19
@braginini
Clarify networks
a1c3e45
@heisbrot
Fix not properly aligned horizontal scroll bar
2b7b587
@heisbrot
Add option to install netbird after creating a setup key
57e71a3
@heisbrot
Fix text for install netbird modal
f3d4dcb
@heisbrot
Show resources count in group settings
d7268cb
@heisbrot
Fix "no results" and "no routing peers" text showing at the same time
1a41026
@heisbrot
Fix wording
33d8295
@heisbrot
Merge branch 'main' into feature/networks-improvements
d37b7e0 
# Conflicts:
#	src/modules/networks/routing-peers/NetworkRoutingPeerModal.tsx
@heisbrot
Merge branch 'feature/setup-key-install-netbird' into feature/network…
1d64f3f 
…s-improvements
@heisbrot
Fix resource policy count
fe41574
@heisbrot
Hide resource count when selection source groups
d3a8b70
@heisbrot
Extend networks routing peer modal with option to create a setup key …
31db280 
…and install netbird
@heisbrot
Add option for horizontal stepper
5c2dba7
@heisbrot
Generate setup key when installing netbird from routing peer modal
48bf8e0
@heisbrot
Add confirm dialog to let the user know a one-off setup-key will be c…
44f28c8 
…reated. This avoids accidental clicking and later confusion on the setup keys page
@heisbrot heisbrot merged commit 25be69e into main Jan 20, 2025
4 checks passed
@heisbrot heisbrot deleted the feature/networks-improvements branch January 20, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braginini braginini braginini left review comments

@pascal-fischer pascal-fischer pascal-fischer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heisbrot @braginini @pascal-fischer