Skip to content

Commit 3f4137a

Browse files
Fix conditional RBAC to be added on NetBird key existence (#26)
Operator checks for existence of NetBird API key to create controllers for Service, NBResource, NBPolicy ...etc, while the Helm chart checks for Values.ingress.enabled, this causes crashes if NetBird API Key is provided but ingress.enabled is set to `false`. This fixes this discrepancy by checking NetBird API key in Helm instead of ingress enabled value. resolves #13
1 parent b06e9b1 commit 3f4137a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

helm/kubernetes-operator/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: kubernetes-operator
33
description: NetBird Kubernetes Operator
44
type: application
5-
version: 0.1.6
5+
version: 0.1.7
66
appVersion: "0.1.2"

helm/kubernetes-operator/templates/rbac.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ rules:
2727
- get
2828
- patch
2929
- update
30-
{{- if .Values.ingress.enabled }}
30+
{{- if or .Values.netbirdAPI.key .Values.netbirdAPI.keyFromSecret }}
3131
- apiGroups:
3232
- netbird.io
3333
resources:
@@ -108,7 +108,7 @@ rules:
108108
- get
109109
- list
110110
- watch
111-
{{- if or .Values.ingress.enabled .Values.clusterSecretsPermissions.allowAllSecrets }}
111+
{{- if or (or .Values.netbirdAPI.key .Values.netbirdAPI.keyFromSecret) .Values.clusterSecretsPermissions.allowAllSecrets }}
112112
- apiGroups:
113113
- ""
114114
resources:
@@ -117,7 +117,7 @@ rules:
117117
- get
118118
- list
119119
- watch
120-
{{- if .Values.ingress.enabled }}
120+
{{- if or .Values.netbirdAPI.key .Values.netbirdAPI.keyFromSecret }}
121121
- patch
122122
- update
123123
- create

0 commit comments

Comments
 (0)