check if we have a successful connection so we do not need to connect to other servers

Author: mohamed-essam

relay/client/picker.go

@@ -45,19 +45,25 @@ func (sp *ServerPicker) PickServer(parentCtx context.Context) (*Client, error) {
 	concurrentLimiter := make(chan struct{}, maxConcurrentServers)
 
 	log.Debugf("pick server from list: %v", sp.ServerURLs.Load().([]string))
+	go sp.processConnResults(connResultChan, successChan)
 	for _, url := range sp.ServerURLs.Load().([]string) {
-		// todo check if we have a successful connection so we do not need to connect to other servers
-		concurrentLimiter <- struct{}{}
-		go func(url string) {
-			defer func() {
-				<-concurrentLimiter
-			}()
-			sp.startConnection(parentCtx, connResultChan, url)
-		}(url)
+		select {
+		case concurrentLimiter <- struct{}{}:
+			go func(url string) {
+				defer func() {
+					<-concurrentLimiter
+				}()
+				sp.startConnection(parentCtx, connResultChan, url)
+			}(url)
+		case cr, ok := <-successChan:
+			if !ok {
+				return nil, errors.New("failed to connect to any relay server: all attempts failed")
+			}
+			log.Infof("chosen home Relay server: %s with latency %s", cr.Url, cr.Latency)
+			return cr.RelayClient, nil
+		}
 	}
 
-	go sp.processConnResults(connResultChan, successChan)
-
 	select {
 	case cr, ok := <-successChan:
 		if !ok {