Improve terminology

Author: lixmal

client/firewall/uspfilter/nat.go

@@ -849,7 +849,7 @@ func (m *Manager) rewriteUDPDestinationPort(packetData []byte, d *decoder, newPo
 	return m.rewriteUDPPort(packetData, d, newPort, destinationPortOffset)
 }
 
-// translateOutboundPortReverse applies reverse port DNAT to outbound return traffic.
+// translateOutboundPortReverse reverses inbound port DNAT for outbound return traffic.
 func (m *Manager) translateOutboundPortReverse(packetData []byte, d *decoder) bool {
 	if !m.portDNATEnabled.Load() {
 		return false
@@ -894,7 +894,7 @@ func (m *Manager) translateOutboundPortReverse(packetData []byte, d *decoder) bo
 	return m.applyOutboundUDPPortReverse(packetData, d, srcIP, srcPort)
 }
 
-// applyOutboundUDPPortReverse applies reverse port DNAT to outbound UDP packets.
+// applyOutboundUDPPortReverse reverses inbound port DNAT for outbound UDP packets.
 func (m *Manager) applyOutboundUDPPortReverse(packetData []byte, d *decoder, srcIP netip.Addr, srcPort uint16) bool {
 	m.portDNATMutex.RLock()
 	defer m.portDNATMutex.RUnlock()
@@ -912,7 +912,7 @@ func (m *Manager) applyOutboundUDPPortReverse(packetData []byte, d *decoder, src
 			return false
 		}
 
-		m.logger.Trace4("Outbound UDP Port Reverse: %s:%d -> %s:%d", srcIP, rule.targetPort, srcIP, rule.sourcePort)
+		m.logger.Trace4("Outbound UDP DNAT Reverse: %s:%d -> %s:%d", srcIP, rule.targetPort, srcIP, rule.sourcePort)
 		return true
 	}
 	return false

client/firewall/uspfilter/tracer.go

@@ -42,7 +42,7 @@ func (s PacketStage) String() string {
 		StageForwarding:          "Forwarding",
 		StageCompleted:           "Completed",
 		StageOutbound1to1NAT:     "Outbound 1:1 NAT",
-		StageOutboundPortReverse: "Outbound Port Reverse",
+		StageOutboundPortReverse: "Outbound DNAT Reverse",
 	}[s]
 }
 
@@ -596,12 +596,12 @@ func (m *Manager) traceOutboundPortReverse(trace *PacketTrace, packetData []byte
 		if protocol == layers.LayerTypeUDP {
 			protoStr = "UDP"
 		}
-		msg := fmt.Sprintf("%s port reverse applied: %s:%d -> %s:%d", protoStr, srcIP, originalPort, srcIP, translatedPort)
+		msg := fmt.Sprintf("%s DNAT reverse applied: %s:%d -> %s:%d", protoStr, srcIP, originalPort, srcIP, translatedPort)
 		trace.AddResult(StageOutboundPortReverse, msg, true)
 		return true
 	}
 
-	trace.AddResult(StageOutboundPortReverse, "No matching port reverse rule", true)
+	trace.AddResult(StageOutboundPortReverse, "No matching DNAT reverse rule", true)
 	return false
 }