Address Copilot review feedback for rack_type and airflow features

Fixes NetBox 4.0 compatibility issues by adding version gates to prevent AttributeError when rack_types endpoint is accessed on older NetBox versions. Adds missing airflow idempotency tests and corrects example documentation to match test data.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: richbibby

plugins/module_utils/netbox_utils.py

@@ -73,7 +73,7 @@
         "racks": {},
         "rack_groups": {},
         "rack_roles": {},
-        "rack_types": {},
+        "rack_types": {"introduced": "4.1"},
         "rear_ports": {},
         "rear-ports": {},
         "rear_port_templates": {},

plugins/modules/netbox_rack.py

@@ -244,7 +244,7 @@
           site: Test Site
           location: Test Location
           airflow: front-to-rear
-          rack_type: Standard 42U Rack
+          rack_type: Standard 42U
         state: present
 
     - name: Delete rack within netbox

tests/integration/netbox-deploy.py

@@ -280,24 +280,25 @@ def make_netbox_calls(endpoint, payload):
 rack_roles = [{"name": "Test Rack Role", "slug": "test-rack-role", "color": "4287f5"}]
 created_rack_roles = make_netbox_calls(nb.dcim.rack_roles, rack_roles)
 
-# Create Rack Types
-rack_types = [
-    {
-        "manufacturer": cisco_manu.id,
-        "model": "Standard 42U",
-        "slug": "standard-42u",
-        "form_factor": "4-post-frame",
-        "u_height": 42,
-    },
-    {
-        "manufacturer": cisco_manu.id,
-        "model": "Standard 48U",
-        "slug": "standard-48u",
-        "form_factor": "4-post-cabinet",
-        "u_height": 48,
-    },
-]
-created_rack_types = make_netbox_calls(nb.dcim.rack_types, rack_types)
+# Create Rack Types (NetBox 4.1+)
+if nb_version >= version.parse("4.1"):
+    rack_types = [
+        {
+            "manufacturer": cisco_manu.id,
+            "model": "Standard 42U",
+            "slug": "standard-42u",
+            "form_factor": "4-post-frame",
+            "u_height": 42,
+        },
+        {
+            "manufacturer": cisco_manu.id,
+            "model": "Standard 48U",
+            "slug": "standard-48u",
+            "form_factor": "4-post-cabinet",
+            "u_height": 48,
+        },
+    ]
+    created_rack_types = make_netbox_calls(nb.dcim.rack_types, rack_types)
 
 # Create Racks
 racks = [

tests/integration/targets/v4.1/tasks/netbox_rack.yml

@@ -246,6 +246,24 @@
       - test_nine['rack']['airflow'] == "front-to-rear"
       - test_nine['msg'] == "rack Test Rack Airflow created"
 
+- name: 9a - Create duplicate rack with airflow (idempotency)
+  netbox.netbox.netbox_rack:
+    netbox_url: http://localhost:32768
+    netbox_token: "0123456789abcdef0123456789abcdef01234567"
+    data:
+      name: Test Rack Airflow
+      site: Test Site
+      airflow: front-to-rear
+    state: present
+  register: test_nine_a
+
+- name: 9a - ASSERT
+  ansible.builtin.assert:
+    that:
+      - test_nine_a is not changed
+      - test_nine_a['rack']['airflow'] == "front-to-rear"
+      - test_nine_a['msg'] == "rack Test Rack Airflow already exists"
+
 - name: 10 - Update rack airflow
   netbox.netbox.netbox_rack:
     netbox_url: http://localhost:32768

tests/integration/targets/v4.2/tasks/netbox_rack.yml

@@ -246,6 +246,24 @@
       - test_nine['rack']['airflow'] == "front-to-rear"
       - test_nine['msg'] == "rack Test Rack Airflow created"
 
+- name: 9a - Create duplicate rack with airflow (idempotency)
+  netbox.netbox.netbox_rack:
+    netbox_url: http://localhost:32768
+    netbox_token: "0123456789abcdef0123456789abcdef01234567"
+    data:
+      name: Test Rack Airflow
+      site: Test Site
+      airflow: front-to-rear
+    state: present
+  register: test_nine_a
+
+- name: 9a - ASSERT
+  ansible.builtin.assert:
+    that:
+      - test_nine_a is not changed
+      - test_nine_a['rack']['airflow'] == "front-to-rear"
+      - test_nine_a['msg'] == "rack Test Rack Airflow already exists"
+
 - name: 10 - Update rack airflow
   netbox.netbox.netbox_rack:
     netbox_url: http://localhost:32768

tests/integration/targets/v4.3/tasks/netbox_rack.yml

@@ -246,6 +246,24 @@
       - test_nine['rack']['airflow'] == "front-to-rear"
       - test_nine['msg'] == "rack Test Rack Airflow created"
 
+- name: 9a - Create duplicate rack with airflow (idempotency)
+  netbox.netbox.netbox_rack:
+    netbox_url: http://localhost:32768
+    netbox_token: "0123456789abcdef0123456789abcdef01234567"
+    data:
+      name: Test Rack Airflow
+      site: Test Site
+      airflow: front-to-rear
+    state: present
+  register: test_nine_a
+
+- name: 9a - ASSERT
+  ansible.builtin.assert:
+    that:
+      - test_nine_a is not changed
+      - test_nine_a['rack']['airflow'] == "front-to-rear"
+      - test_nine_a['msg'] == "rack Test Rack Airflow already exists"
+
 - name: 10 - Update rack airflow
   netbox.netbox.netbox_rack:
     netbox_url: http://localhost:32768