Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order codes vs model names for Opengear models #2363

Open
jonkerj opened this issue Oct 1, 2024 · 0 comments · May be fixed by #2364
Open

Order codes vs model names for Opengear models #2363

jonkerj opened this issue Oct 1, 2024 · 0 comments · May be fixed by #2364

Comments

@jonkerj
Copy link

jonkerj commented Oct 1, 2024

The OpenGear stuff in this repo has model names that are like CM7132-2-DAC-US, while the actual model name of these devices are CM7132-2-DAC (label on device, and that is what they call themselves). If you would order them, you do need to specify either -US or -EU, which will result in a different cable in your box but with an identical device. So the -US/-EU are order codes and not model names. I think the cable type should be modeled in netbox using dcim.cables and not with a dcim.device_type :-)

The reason I came across this, is that we have some of these devices, which are ordered as -EU and will not be matched. I originally wanted to submit a PR to add the -EU types, but I think the model names should to be corrected instead.

The original seems to be submitted by @ryanmerolle, what's your opinion on this?

jonkerj added a commit to jonkerj/netbox-devicetype-library that referenced this issue Oct 1, 2024
Opengear model names were (probably) copied from order codes, which
include the power cord (US, EU) to include in the box. The actual models
don't include the -EU/-US suffix, so this commit makes the model names
canonical.

Fixes netbox-community#2363

Signed-Off-By: Jorik Jonker <[email protected]>
@jonkerj jonkerj linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant