Enhancement: Add is_full_depth to devices

[phillf]

Hi @phillf
Just had a look and about 118 are missing the is_full_depth property.

Originally posted by @harryajc in #2708

Please assign me as owner.

Tag with:
status: Needs PR
type: enhancement

I think adding an enhancement tag is appropriate here. This isn't a bug per se. I see this more as a schema data quality improvement.

[danner26]

Completed. Please feel free to submit a PR and reference this issue. Thanks!

[harryajc]

Hi,
Was thinking about another missing mandatory field. The position field in module-bays should be required as it causes issues if the module trying to be added to the bay has used the {module} variable. Although I recon add this might also require some updating of devices that have already been added

[phillf]

@harryajc @danner26, are there other fields that you can think of that would make sense to require?

[harryajc]

@harryajc @danner26, are there other fields that you can think of that would make sense to require?

Not that I can think of right now. I am planning to put together a PR for the module-bays position requirement but have to fix around 150 devices first

[danner26]

This was merged I believe, I guess we never linked this issue to the ticket.

[harryajc]

This was merged I believe, I guess we never linked this issue to the ticket.

No not for this one. A PR was never created. I'll create on if @phillf is okay with that

[phillf]

@harryajc, go for it. The storage in my primary workstation died and I lost any progress I had on this.