Policies from session's peer group appearing in session's policies

[gellis713]

netbox-bgp/netbox_bgp/api/serializers.py

Line 165 in b620b72

for pol in instance.peer_group.import_policies.difference(

netbox-bgp/netbox_bgp/api/serializers.py

Line 175 in b620b72

for pol in instance.peer_group.export_policies.difference(

The intent of these lines was to only show session policies that were not in the peer group. However in my testing this behavior was implemented in reverse. (The difference should be reversed). Will submit PR when time allows.

[cruse1977]

hi @gellis713 any idea when you might get to this ?

[alexonishchenko]

I've got the same problem. Import/export policies are added from session's peer group when GETting via API.
GUI shows correct policies (no peer group policies included).

plugin version: 0.18.0
netbox version: 4.5.4

This should be considered as a bug.

[alexonishchenko]

netbox-bgp/netbox_bgp/api/serializers.py

Line 214 in 3812d23

def to_representation(self, instance):

what's the purpose of this method? it should be eliminated from the serializer. This breaks REST.