Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD group name not following conventions #66

Open
2 tasks done
faebr opened this issue Sep 20, 2024 · 0 comments · May be fixed by #68
Open
2 tasks done

CRD group name not following conventions #66

faebr opened this issue Sep 20, 2024 · 0 comments · May be fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@faebr
Copy link
Contributor

faebr commented Sep 20, 2024

Bug report criteria

  • This bug report is not security related, security issues should be disclosed privately via netbox operator maintainers.
  • Existing open issues have been checked and this is not a duplicate.

What happened?

The CRD group name is netbox.dev but it should be netbox.netbox.dev following the conventions and the data entered in the PROJECT file. When using the kubebuilder cli to add another API, one needs to manually adapt some things.

What did you expect to happen?

Change the group name in PROJECT (since netbox.netbox.dev seems weird ) and then adapt the CRD group.

How can we reproduce it (as minimally and precisely as possible)?

Running:
kubebuilder create api --group netbox --version v1 --kind Attachment
and:
make manifests
-> there are issues like the kustomization in crd pointing to a non-existant file

Netbox operator version

0.0.1-alpha

Netbox operator configuration (command line flags or environment variables)

Relevant log output

No response

Anything else we need to know?

No response

@faebr faebr added the bug Something isn't working label Sep 20, 2024
@faebr faebr linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant