Fix Finalizers #78
Open
Fix Finalizers #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaIT-HgA
force-pushed
the
fix/finalizers
branch
3 times, most recently
from
9b2fc00
to
a1f57ac
Compare
MaIT-HgA
force-pushed
the
fix/finalizers
branch
from
a1f57ac
to
edc8fbe
Compare
henrybear327
force-pushed
the
fix/finalizers
branch
from
edc8fbe
to
b6cc9db
Compare
jstudler
reviewed
Oct 1, 2024
| @@ -81,6 +82,14 @@ func (r *PrefixReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| if controllerutil.ContainsFinalizer(prefix, PrefixFinalizerName) { | |||
| if !prefix.Spec.PreserveInNetbox { | |||
| if err := r.NetboxClient.DeletePrefix(prefix.Status.PrefixId); err != nil { | |||
| if errors.Is(err, utils.ErrNotFound) { | |||
| setConditionErr := r.SetConditionAndCreateEvent(ctx, prefix, netboxv1.ConditionPrefixReadyFalse, corev1.EventTypeWarning, err.Error()) | |||
There was a problem hiding this comment.
Propose to use a different condition (replace netboxv1.ConditionPrefixReadyFalse with a new condition like e.g. netboxv1.ConditionPrefixReadyFalseDeletionFailed)
Currently the condition looks as follows:
conditions:
- lastTransitionTime: "2024-10-01T07:14:46Z"
message: 'Failed to reserve IP in NetBox. failed to fetch IPAddress: not found'
reason: FailedToReserveIpInNetbox
status: "False"
type: Ready
Propose to use reason "FailedToDeleteIpInNetbox" and message "Failed to delete IP in NetBox".
Same applies to the other controller...
jstudler
reviewed
Oct 1, 2024
jstudler
reviewed
Oct 1, 2024
| @@ -98,9 +100,17 @@ func (r *NetboxClient) UpdatePrefix(prefixId int64, prefix *netboxModels.Writabl | |||
| } | |||
|
|
|||
| func (r *NetboxClient) DeletePrefix(prefixId int64) error { | |||
| // assuming id starts from 1 when Prefix is created so 0 means that Prefix doesn't exist | |||
| if prefixId == 0 { | |||
There was a problem hiding this comment.
Not sure what this check is about. Is it to catch the case where the prefix was never created in NetBox?
henrybear327
force-pushed
the
fix/finalizers
branch
from
b6cc9db
to
51fd430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Close #77