Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional save / create / cancel buttons to top of forms (or make existing buttons stay visible) #16009

Open
ITJamie opened this issue May 7, 2024 · 9 comments · May be fixed by #17523
Open

Add additional save / create / cancel buttons to top of forms (or make existing buttons stay visible) #16009

ITJamie opened this issue May 7, 2024 · 9 comments · May be fixed by #17523
Assignees
@atownson
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@ITJamie
Copy link
Contributor

ITJamie commented May 7, 2024

NetBox version

v4.0.0

Feature type

New functionality

Proposed functionality

Add save / create / cancel buttons to top of forms (or make existing buttons stay visible )

Use case

when a model has a lot of fields/custom fields (or is being used on a small display) there can be a lot of scrolling to get to the save / create buttons.
it would be great if there was a copy of those buttons at the top of the form or if the existing buttons were always visible on the form

Database changes

N/A

External dependencies

N/A
@ITJamie ITJamie added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels May 7, 2024
@jeremystretch
Copy link
Member

There was some discussion around this idea way back in #2237. Unfortunately it never found an owner.

@ITJamie
Copy link
Contributor Author

ITJamie commented May 7, 2024

What would be deemed acceptable?

  • An extra set of buttons at the top of the form
  • Some kind of "fixed" bar with the action buttons

If it was just an extra set of buttons at the top I could likely take a stab at it.

@jeremystretch
Copy link
Member

IMO a single set of fixed/floating buttons would be ideal. Rendering multiple buttons that do the same thing can be confusing and error-prone.

@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: needs triage This issue is awaiting triage by a maintainer labels May 7, 2024
@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label May 21, 2024
@paynl-wesley
Copy link

What would be deemed acceptable?

  • An extra set of buttons at the top of the form
  • Some kind of "fixed" bar with the action buttons

If it was just an extra set of buttons at the top I could likely take a stab at it.

IMHO a fixed bar with the action buttons on the bottom would be awesome!

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Aug 27, 2024
@atownson
Copy link
Contributor

Any thoughts on this approach?

Added this CSS to the buttons div:

position: sticky;
bottom: 0px;
padding: 2px 0px 10px 0px;
z-index: 1;
background-color: var(--tblr-bg-surface-tertiary)

Result:

NetBox.Button.Illustration.mp4

@paynl-wesley
Copy link

Awesome!

@atownson
Copy link
Contributor

I can submit a PR for this if the above method is acceptable.

atownson pushed a commit to atownson/netbox that referenced this issue Sep 17, 2024
netbox-community#16009 Added btn-float-group style class and added to…
8715f6f 
… form templates for floating button groups
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Sep 17, 2024
@jeremystretch
Copy link
Member

Thanks @atownson I've assigned this to you for a PR.

@atownson atownson linked a pull request Sep 17, 2024 that will close this issue
Open
atownson pushed a commit to atownson/netbox that referenced this issue Sep 20, 2024
netbox-community#16009 Removed floating div background and moved filt…
30e6704 
…er form buttons outside of card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atownson atownson

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #16009 - Added styling to form templates to enable floating button groups atownson/netbox
5 participants
@jeffgdotorg @ITJamie @jeremystretch @atownson @paynl-wesley