Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce custom field padding when using descriptions #17464

Open
goteamkor opened this issue Sep 11, 2024 · 4 comments · May be fixed by #17534
Open

reduce custom field padding when using descriptions #17464

goteamkor opened this issue Sep 11, 2024 · 4 comments · May be fixed by #17534
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@goteamkor
Copy link

goteamkor commented Sep 11, 2024

Deployment Type

Self-hosted

NetBox Version

v.4.1.0

Python Version

3.10

Steps to Reproduce

create 2 custom fields
give both custom fields a description

Expected Behavior

custom field padding should be reduced between custom fields that have descriptions.

currently, when custom fields are next to each other and they don't have a description, the spacing is nice and tight. But as soon as you add a description to the custom field, the padding is too much.

Observed Behavior

image

@goteamkor goteamkor added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Sep 11, 2024
@goteamkor goteamkor changed the title too much custom field padding too much custom field padding when using descriptions Sep 11, 2024
@goteamkor goteamkor changed the title too much custom field padding when using descriptions reduce custom field padding when using descriptions Sep 11, 2024
@DanSheps DanSheps added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Sep 12, 2024
@jeremystretch
Copy link
Member

@goteamkor you currently have 15 open issues, most have which have been tagged as needing an owner. Please consider volunteering to own some of the work you've proposed before opening additional issues.

@goteamkor
Copy link
Author

goteamkor commented Sep 12, 2024

@goteamkor you currently have 15 open issues, most have which have been tagged as needing an owner. Please consider volunteering to own some of the work you've proposed before opening additional issues.

@jeremystretch , I would LOVE to contribute. I got pretty far down in creating my own dev environment. The part that got me confused was when it came time to create pull requests. It's very intimidating for me since I'm not a programmer by trade.
Would you recommend any other contributors that might be willing to mentor/offer a bit of hand holding on the last few steps of kicking off my own contributions?

@jeremystretch
Copy link
Member

Our developer documentation has everything you need to get started. If you need help with something specific, I suggest starting a GitHub discussion.

@atownson
Copy link
Contributor

I think the fix for this is to modify _markdown.scss.
Current:

// Remove the bottom margin of <p> elements inside a table cell
td > .rendered-markdown {
  max-height: 200px;
  overflow-y: scroll;

  p:last-of-type {
    margin-bottom: 0;
  }
}

Suggested change:

// Remove the bottom margin of <p> elements inside a table cell
.rendered-markdown {
  max-height: 200px;
  overflow-y: scroll;

  p:last-of-type {
    margin-bottom: 0;
  }
}

The styling doesn't apply for the custom field description in this case because it's not a child of <td>.

@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 18, 2024
@arthanson arthanson self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants