feat: add duplicate check for YunxinApiHttpClient init

Author: caojiajun

src/main/java/com/netease/nim/im/server/sdk/core/YunxinApiHttpClient.java

@@ -12,12 +12,15 @@
 import com.netease.nim.im.server.sdk.core.trace.ApiVersion;
 
 import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Created by caojiajun on 2024/12/9
  */
 public class YunxinApiHttpClient {
 
+    private static final ConcurrentHashMap<String, YunxinApiHttpClient> clientMap = new ConcurrentHashMap<>();
+
     private final YunxinHttpClient httpClient;
 
     private YunxinApiHttpClient(String appkey, String appsecret, EndpointConfig endpointConfig,
@@ -37,6 +40,11 @@ public static class Builder {
         public Builder(String appkey, String appsecret) {
             this.appkey = appkey;
             this.appsecret = appsecret;
+            String cacheKey = appkey + "/" + appsecret;
+            YunxinApiHttpClient client = clientMap.get(cacheKey);
+            if (client != null) {
+                throw new IllegalStateException("YunxinApiHttpClient with appkey = [" + appkey + "] duplicate init");
+            }
         }
 
         public Builder retryPolicy(RetryPolicy retryPolicy) {
@@ -105,11 +113,18 @@ public Builder region(Region region) {
         }
 
         public YunxinApiHttpClient build() {
+            String cacheKey = appkey + "/" + appsecret;
+            YunxinApiHttpClient client = clientMap.get(cacheKey);
+            if (client != null) {
+                throw new IllegalStateException("YunxinApiHttpClient with appkey = [" + appkey + "] duplicate init");
+            }
             if (endpointConfig.getEndpointSelector() == null) {
                 EndpointSelector endpointSelector = new DynamicEndpointSelector(new DynamicEndpointFetcher(appkey, region));
                 endpointConfig.setEndpointSelector(endpointSelector);
             }
-            return new YunxinApiHttpClient(appkey, appsecret, endpointConfig, httpClientConfig, metricsConfig);
+            YunxinApiHttpClient yunxinApiHttpClient = new YunxinApiHttpClient(appkey, appsecret, endpointConfig, httpClientConfig, metricsConfig);
+            clientMap.put(cacheKey, yunxinApiHttpClient);
+            return yunxinApiHttpClient;
         }
     }
 

src/main/java/com/netease/nim/im/server/sdk/core/endpoint/DynamicEndpointFetcher.java

@@ -18,6 +18,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
 
 
@@ -28,6 +29,8 @@ public class DynamicEndpointFetcher implements EndpointFetcher {
 
     private static final Logger logger = LoggerFactory.getLogger(DynamicEndpointFetcher.class);
 
+    private static final ScheduledExecutorService scheduler = Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-endpoint-fetch"));
+
     private final String appkey;
     private final List<String> lbsList;
     private final int reloadIntervalSeconds;
@@ -81,8 +84,7 @@ public void init(OkHttpClient okHttpClient) {
         if (endpoints == null) {
             throw new EndpointFetchException("init endpoints error");
         }
-        Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-endpoint-fetch"))
-                .scheduleAtFixedRate(() -> {
+        scheduler.scheduleAtFixedRate(() -> {
                     for (String lbs : lbsList) {
                         try {
                             boolean reload = reload(lbs);

src/main/java/com/netease/nim/im/server/sdk/core/endpoint/DynamicEndpointSelector.java

@@ -11,6 +11,7 @@
 import java.util.*;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
 
 /**
@@ -20,6 +21,9 @@ public class DynamicEndpointSelector implements EndpointSelector {
 
     private static final Logger logger = LoggerFactory.getLogger(DynamicEndpointSelector.class);
 
+    private static final ScheduledExecutorService scheduler1 = Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-detect"));
+    private static final ScheduledExecutorService scheduler2 = Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-schedule"));
+
     private final EndpointFetcher fetcher;
     private final int scheduleDetectIntervalSeconds;
     private final int scheduleResultIntervalSeconds;
@@ -74,11 +78,9 @@ public void init(OkHttpClient okHttpClient) {
             orderedEndpoints.addAll(backupEndpoints);
         }
         if (detectPath != null) {
-            Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-detect"))
-                    .scheduleAtFixedRate(this::scheduleDetect, scheduleDetectIntervalSeconds, scheduleDetectIntervalSeconds, TimeUnit.SECONDS);
+            scheduler1.scheduleAtFixedRate(this::scheduleDetect, scheduleDetectIntervalSeconds, scheduleDetectIntervalSeconds, TimeUnit.SECONDS);
         }
-        Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-schedule"))
-                .scheduleAtFixedRate(this::scheduleResult, scheduleResultIntervalSeconds, scheduleResultIntervalSeconds, TimeUnit.SECONDS);
+        scheduler2.scheduleAtFixedRate(this::scheduleResult, scheduleResultIntervalSeconds, scheduleResultIntervalSeconds, TimeUnit.SECONDS);
     }
 
     @Override

src/main/java/com/netease/nim/im/server/sdk/core/metrics/YunxinApiSdkMetricsCollector.java

@@ -20,7 +20,8 @@ public class YunxinApiSdkMetricsCollector {
 
     private static final Logger logger = LoggerFactory.getLogger(YunxinApiSdkMetricsCollector.class);
 
-    private final ThreadPoolExecutor callbackExecutor = new ThreadPoolExecutor(1, 1,
+    private static final ScheduledExecutorService scheduler = Executors.newSingleThreadScheduledExecutor(new NamedThreadFactory("yunxin-im-sdk-metrics-collector"));
+    private static final ThreadPoolExecutor callbackExecutor = new ThreadPoolExecutor(1, 1,
             0, TimeUnit.SECONDS, new LinkedBlockingQueue<>(100), new NamedThreadFactory("yunxin-im-sdk-stats-callback"));
 
     private final ConcurrentHashMap<Key1, Statistics> map1 = new ConcurrentHashMap<>();
@@ -35,8 +36,7 @@ public YunxinApiSdkMetricsCollector(int collectIntervalSeconds, MetricsCallback
             throw new IllegalArgumentException("illegal collectIntervalSeconds");
         }
         this.metricsCallback = metricsCallback;
-        Executors.newSingleThreadScheduledExecutor()
-                .scheduleAtFixedRate(this::calc, collectIntervalSeconds, collectIntervalSeconds, TimeUnit.SECONDS);
+        scheduler.scheduleAtFixedRate(this::calc, collectIntervalSeconds, collectIntervalSeconds, TimeUnit.SECONDS);
     }
 
     public void collect(String endpoint, HttpMethod method, ContextType contextType, ApiVersion apiVersion,