Skip to content

Commit 773e426

Browse files
committed
el_script: Don't bother with python extensions on virtual systems
1 parent 67cb9fb commit 773e426

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

el_configurator.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# Works with Debian 13, although atm no scap profile is available as of 27-08-2025
77
# Works with Ubuntu 22.04 tls, although scap support needs to be disabled as of 16-12-2025
88

9-
SCRIPT_BUILD="2026042501"
9+
SCRIPT_BUILD="2026051701"
1010

1111
# Note that all variables can be overridden by kernel arguments
1212
# Example: Override BRAND_NAME with kernel argument: NPF_BRAND_NAME=MyBrand
@@ -51,7 +51,7 @@ SCAP_PROFILE=anssi_bp28_high
5151
#SCAP_PROFILE=anssi_bp28_intermediary
5252
#SCAP_PROFILE=false
5353

54-
# By default, ANSSI profiles disable sudo (which is a good thing, but el10 also disables root account by default, so we need at least a root account or sudo working)
54+
# By default, ANSSI profiles disables sudo (which is a good thing, but el10 also disables root account by default, so we need at least a root account or sudo working)
5555
ALLOW_SUDO=false
5656

5757
# Setup SELinux on Debian
@@ -67,7 +67,7 @@ CONFIGURE_TERMINAL_RESIZER=true
6767
CONFIGURE_NODE_EXPORTER=true
6868
# See below for firewall settings
6969

70-
# Setup python smartmontools / nvme tooling for prometheus
70+
# Setup python smartmontools / nvme tooling for prometheus on physical systems
7171
CONFIGURE_NODE_EXPORTER_PYTHON_EXTENSIONS=true
7272

7373
# Make sure system automatically installs security updates
@@ -584,7 +584,7 @@ if [ ${IS_VIRTUAL} != true ]; then
584584
echo "DEVICESCAN -H -l error -f -C 197+ -U 198+ -t -l selftest -I 194 -n sleep,7,q -s (S/../.././10|L/../../[5]/13)" >> "${SMARTD_CONF_FILE}" 2>> "${LOG_FILE}" || log "Failed to add DEVICESCAN to smartd.conf" "ERROR"
585585
systemctl enable ${SMARTD_SYSTEMD_SERVICE} 2>> "${LOG_FILE}" || log "Failed to start smartd" "ERROR"
586586

587-
if [ "${CONFIGURE_NODE_EXPORTER_PYTHON_EXTENSIONS}" = true ]; then
587+
if [ "${CONFIGURE_NODE_EXPORTER_PYTHON_EXTENSIONS}" = true ] && [ "${IS_VIRTUAL}" != true ]; then
588588
log "Setting up python smartmontools / nvme tooling for prometheus"
589589
if [ "${FLAVOR}" = "rhel" ]; then
590590
# As of 2025-09-23, there is no python3-prometheus_client package so we have to bootstrap in from python on RHEL10

0 commit comments

Comments
 (0)