refactor: use p-retry library for extension fetch with exponential backoff like netlify/edge-bundler

Author: jaredm563

packages/config/package.json

@@ -76,6 +76,7 @@
     "map-obj": "^5.0.0",
     "omit.js": "^2.0.2",
     "p-locate": "^6.0.0",
+    "p-retry": "^6.0.0",
     "path-type": "^6.0.0",
     "read-package-up": "^11.0.0",
     "tomlify-j0.4": "^3.0.0",

packages/config/src/api/site_info.ts

@@ -1,5 +1,5 @@
 import { NetlifyAPI } from '@netlify/api'
-
+import pRetry, { AbortError } from 'p-retry'
 import * as z from 'zod'
 
 import { getEnvelope } from '../env/envelope.js'
@@ -247,34 +247,25 @@ export const getExtensions = async function ({
     headers.set('Netlify-SDK-Build-Bot-Token', token)
   }
 
-  // Retry with exponential backoff for transient network issues
-  const maxRetries = 3
-  let lastError: Error | undefined
-  for (let attempt = 0; attempt < maxRetries; attempt++) {
-    try {
-      const res = await fetch(url, { headers })
-      if (res.status === 200) {
-        return ExtensionResponseSchema.parse(await res.json())
-      }
-      // Dont do retry on 4xx errors
-      if (res.status >= 400 && res.status < 500) {
-        throw new Error(`Unexpected status code ${res.status} from fetching extensions`)
-      }
-      lastError = new Error(`Unexpected status code ${res.status} from fetching extensions`)
-    } catch (err) {
-      lastError = err instanceof Error ? err : new Error('unknown error')
-      // Dont do retry on 4xx errors
-      if (lastError.message.includes('4')) {
-        break
-      }
-    }
-    if (attempt < maxRetries - 1) {
-      await new Promise((resolve) => setTimeout(resolve, 1000 * Math.pow(2, attempt)))
-    }
-  }
-  {
+  try {
+    return await pRetry(
+      async () => {
+        const res = await fetch(url, { headers })
+        if (res.status === 200) {
+          return ExtensionResponseSchema.parse(await res.json())
+        }
+        const errorMsg = `Unexpected status code ${res.status} from fetching extensions`
+        // Don't retry on 4xx errors (client errors)
+        if (res.status >= 400 && res.status < 500) {
+          throw new AbortError(errorMsg)
+        }
+        throw new Error(errorMsg)
+      },
+      { retries: 3 },
+    )
+  } catch (err) {
     return throwUserError(
-      `Failed retrieving extensions for site ${siteId}: ${lastError?.message ?? 'unknown error'}. ${ERROR_CALL_TO_ACTION}`,
+      `Failed retrieving extensions for site ${siteId}: ${err instanceof Error ? err.message : 'unknown error'}. ${ERROR_CALL_TO_ACTION}`,
     )
   }
 }