Skip to content

Commit 3646478

Browse files
authored
Mike's review
1 parent 39f6d0c commit 3646478

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

draft-ietf-netmod-schedule-yang.md

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ informative:
5959
This document defines common types and groupings that are meant to be used
6060
for scheduling purposes such as event, policy, services, or resources based on
6161
date and time. For the sake of better modularity, the YANG module includes a
62-
set of recurrence related groupings with varying levels of representation
62+
set of recurrence-related groupings with varying levels of representation
6363
(i.e., from basic to advanced) to accommodate a variety of requirements.
6464
It also defines groupings for validating requested schedules and reporting scheduling status.
6565

@@ -143,7 +143,7 @@ System:
143143

144144
The "ietf-schedule" data model defines the recurrence related groupings using
145145
a modular approach. To that aim, a variety of representations of recurrence
146-
groupings ranging from basic to advanced (iCalender like) are defined.
146+
groupings ranging from basic to advanced (iCalender-like) are defined.
147147
To allow for different options, two features are defined in the data model:
148148

149149
* "basic-recurrence"
@@ -231,7 +231,7 @@ System:
231231
The "period-of-time" grouping ({{pt-tree}}) represents a time period using
232232
either a start date and time ("period-start") and end date and time ("period-end"), or a
233233
start date and time ("period-start") and a non-negative time duration ("duration"). For the first
234-
format, the start of the period MUST be no later the end of the period. If neither an end date and time ("period-end")
234+
format, the start of the period MUST be no later than the end of the period. If neither an end date and time ("period-end")
235235
nor a duration ("duration") is indicated, the period is considered to last forever.
236236
If the duration ("duration") value is 0 or the end time ("period-end") is the same as the start time ("period-start"), the period
237237
is considered as a one-shot schedule. If no start date and time ("period-start")
@@ -278,7 +278,7 @@ System:
278278
### The "recurrence-utc" Grouping {#sec-rec-utc}
279279

280280
The "recurrence-utc" grouping ({{rec-utc-grp-tree}}) uses the "recurrence-basic"
281-
grouping and specifies a simple recurrence rule in UTC format.
281+
grouping ({{sec-rec}}) and specifies a simple recurrence rule in UTC format.
282282

283283
~~~~
284284
{::include ./yang/tree/rec-utc-grp.txt}
@@ -298,7 +298,7 @@ System:
298298
more time than specified by the "duration" is out of scope. Such considerations
299299
belong to task management, not schedule management.
300300

301-
Note that the "interval" and "duration" cover two distinct properties of a schedule event.
301+
Note that the "interval" and "duration" cover two distinct properties of a schedule event.
302302
The interval specifies when a schedule will occur, combined with the frequency parameter; while the duration indicates how long
303303
an occurrence will last. This document allows the interval between occurrences to be shorter than the duration of each occurrence (e.g., a recurring event is scheduled to start every day for a duration of 2 days).
304304

@@ -312,7 +312,7 @@ an occurrence will last. This document allows the interval between occurrences t
312312
### The "recurrence-with-time-zone" Grouping {#sec-rec-tz}
313313

314314
The "recurrence-with-time-zone" grouping ({{rec-tz-grp-tree}}) uses the
315-
"recurrence-basic" grouping and specifies a simple recurrence rule with a time zone.
315+
"recurrence-basic" grouping ({{sec-rec}}) and specifies a simple recurrence rule with a time zone.
316316

317317
~~~~
318318
{::include ./yang/tree/rec-tz-grp.txt}
@@ -336,6 +336,8 @@ an occurrence will last. This document allows the interval between occurrences t
336336
indicated by the "recurrence-end" choice. The "count" value MUST be greater than 1, the "start-time" value always counts
337337
as the first occurrence.
338338

339+
The considerations discussed in {{sec-rec-utc}} for "interval" and "duration" are also applicable to "recurrence-with-time-zone".
340+
339341
Unlike the definition of "recurrence-utc" grouping ({{sec-rec-utc}}),
340342
"recurrence-with-time-zone" is intended to promote human readability over
341343
machine readability.
@@ -448,7 +450,7 @@ an occurrence will last. This document allows the interval between occurrences t
448450
parameter to allow extensibility in future modules.
449451

450452
The "version" parameter is used to track the current schedule version
451-
information. The version can be bumped by the entity that created the schedule.
453+
information. The version can be incremented by the entity that created the schedule.
452454
The "last-update" parameter identifies when the schedule was last modified.
453455
In some contexts, this parameter can be used to track the configuration of a
454456
given schedule. In such cases, the "version" may not be used.
@@ -1023,5 +1025,5 @@ after that time would not be considered as valid.
10231025
Thanks to Reshad Rahman for the great YANG Doctors review, Mahesh Jethanandani for the AD review, Per Andersson for the OPSDIR review,
10241026
Peter Yee for genart review, and Acee Lindem for the rtgdir review.
10251027

1026-
Thanks to Éric Vyncke and Erik Kline for the IESG review.
1028+
Thanks to Éric Vyncke, Erik Kline, and Mike Bishop for the IESG review.
10271029

0 commit comments

Comments
 (0)