Skip to content

Commit 276cdaf

Browse files
committed
[FIX] Fix deprecations
1 parent 1bba417 commit 276cdaf

5 files changed

Lines changed: 43 additions & 10 deletions

File tree

neuromaps/datasets/_osf.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@
44
"""
55

66
import os
7-
from pkg_resources import resource_filename
7+
try:
8+
import importlib.resources
9+
_importlib_avail = True
10+
except ImportError:
11+
from pkg_resources import resource_filename
12+
_importlib_avail = False
813
import json
914

1015
from nilearn.datasets.utils import _md5_sum_file
@@ -25,9 +30,12 @@
2530
INFO_KEYS = ['source', 'refs', 'comments', 'demographics']
2631

2732
# distribution JSON
28-
OSFJSON = resource_filename(
29-
'neuromaps', os.path.join('datasets', 'data', 'osf.json')
30-
)
33+
if _importlib_avail:
34+
OSFJSON = importlib.resources.files("neuromaps") / "datasets/data/osf.json"
35+
else:
36+
OSFJSON = resource_filename(
37+
'neuromaps', os.path.join('datasets', 'data', 'osf.json')
38+
)
3139

3240

3341
def parse_filename(fname, return_ext=True, verbose=False):

neuromaps/datasets/tests/test__osf.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
For testing neuromaps.datasets._osf functionality
44
"""
55

6-
from pkg_resources import resource_filename
6+
try:
7+
import importlib.resources
8+
_importlib_avail = True
9+
except ImportError:
10+
from pkg_resources import resource_filename
11+
_importlib_avail = False
712

813
import pytest
914

@@ -21,7 +26,10 @@ def test_parse_fname_list():
2126

2227

2328
def test_parse_json():
24-
osf = resource_filename('neuromaps', 'datasets/data/osf.json')
29+
if _importlib_avail:
30+
osf = importlib.resources.files("neuromaps") / "datasets/data/osf.json"
31+
else:
32+
osf = resource_filename('neuromaps', 'datasets/data/osf.json')
2533
out = _osf.parse_json(osf)
2634
assert isinstance(out, list) and all(isinstance(i, dict) for i in out)
2735

neuromaps/datasets/utils.py

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@
55

66
import json
77
import os
8-
from pkg_resources import resource_filename
8+
try:
9+
import importlib.resources
10+
_importlib_avail = True
11+
except ImportError:
12+
from pkg_resources import resource_filename
13+
_importlib_avail = False
914

1015
import requests
1116

@@ -74,8 +79,16 @@ def get_dataset_info(name, return_restricted=True):
7479
Information on requested data
7580
"""
7681

77-
fn = resource_filename('neuromaps',
78-
os.path.join('datasets', 'data', 'osf.json'))
82+
if _importlib_avail:
83+
fn = importlib.resources.files("neuromaps") / "datasets/data/osf.json"
84+
else:
85+
fn = resource_filename(
86+
'neuromaps',
87+
s.path.join('datasets', 'data', 'osf.json')
88+
)
89+
90+
91+
7992
with open(fn) as src:
8093
osf_resources = _osfify_urls(json.load(src), return_restricted)
8194

neuromaps/nulls/tests/test_nulls.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ def test_fixture_surface_parcellated_smoke(sample_surface_parcellated):
119119
# print(surf_tuple, parc_name, annot_parc.shape[0])
120120
pass
121121

122+
@pytest.mark.filterwarnings("ignore::DeprecationWarning") # nilearn/nilearn/pull/3722
122123
def test_fixture_volume_parcellated_smoke(sample_volume_parcellated):
123124
vol_tuple, parc_name, annot_parc = sample_volume_parcellated
124125
# print(vol_tuple, parc_name, annot_parc.shape[0])

neuromaps/parcellate.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
"""
55

66
import nibabel as nib
7-
from nilearn.input_data import NiftiLabelsMasker
7+
try:
8+
from nilearn.maskers import NiftiLabelsMasker
9+
except:
10+
from nilearn.input_data import NiftiLabelsMasker
811
from nilearn.image import new_img_like
912
from nilearn.masking import compute_background_mask
1013
import numpy as np

0 commit comments

Comments
 (0)