Skip to content

Commit 00b1ef1

Browse files
committed
ci: opt into the reusable workflow's e2e tier
Flip enable-e2e-tests=true and pin e2e-test-packages to ./internal/e2e/... so the browser-level journeys run on every PR (Codecov picks them up under the existing "e2e" flag declared in .github/codecov.yml). Extend the intentional-drift reason on ci.yml to record that we now opt into the e2e tier on top of the existing -coverpkg / templates-coverage customisation. Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
1 parent 01a4edd commit 00b1ef1

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

.github/template.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,12 @@ intentional-drift:
1212
from coverage.out before enforcing the 80% threshold. This keeps authored helpers
1313
in the templates package (flash.go, specializeUsers/Groups/Computers, formatLastLogon)
1414
in the numerator while excluding the framework-internal defer/error branches of
15-
generated templ code.
15+
generated templ code. Also opts into the reusable workflow's e2e tier
16+
(enable-e2e-tests=true, e2e-test-packages=./internal/e2e/...) so the
17+
browser-level journeys under internal/e2e/ — bootstrapped via a
18+
testcontainers OpenLDAP + Playwright-driven headless Chromium against
19+
an in-process ldap-manager listener — run on every PR with coverage
20+
uploaded under the "e2e" Codecov flag.
1621
- path: .github/workflows/container.yml
1722
reason: "platforms narrowed to linux/amd64,linux/arm64 \u2014 Dockerfile base images\
1823
\ (oven/bun, golang-alpine) don't publish i386/arm-v6/arm-v7 variants, so a 5-platform\

.github/workflows/ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ jobs:
2323
enable-license-check: true
2424
enable-codecov: true
2525
enable-integration-tests: true
26+
enable-e2e-tests: true
27+
# The e2e suite spins up an OpenLDAP testcontainer, installs Playwright
28+
# browsers, and starts ldap-manager in-process before driving it via a
29+
# headless Chromium. Coverage is reported under the "e2e" Codecov flag
30+
# (see .github/codecov.yml) so unit / integration / e2e numbers remain
31+
# separable. Only the internal/e2e package is gated by the build tag.
32+
e2e-test-packages: "./internal/e2e/..."
2633
# Exclude the auto-generated internal/web/templates package from the
2734
# coverage calculation: the *_templ.go files are produced by the templ
2835
# CLI and contain many framework-internal defer/error branches that

0 commit comments

Comments
 (0)