Skip to content

Commit 034aec1

Browse files
authored
chore(release): drop deprecated with: block and workflow_dispatch.bump (#36)
## Summary Drops the now-deprecated bits from this caller's release workflow: - The `workflow_dispatch:` trigger and its `bump` input. The upstream reusable workflow's `bump` input has been documented `DEPRECATED — ignored` since the auto-bump job was removed; clicking "Run workflow" in the GitHub UI was a no-op. - The `with:` block (`bump:` only, or `bump:` + `attest:` for matrix-skill). `attest` was deprecated in [netresearch/skill-repo-skill#79](netresearch/skill-repo-skill#79) when SLSA build provenance flipped from opt-in to always-on; `bump` has been deprecated for longer. - Stale comments on the `id-token`/`attestations` permission lines that referenced the old "when attest: true" phrasing. ```diff on: push: tags: - 'v*' - workflow_dispatch: - inputs: - bump: - description: 'Version bump type' - required: true - type: choice - options: - - patch - - minor - - major jobs: release: uses: netresearch/skill-repo-skill/.github/workflows/release.yml@main - with: - bump: ${{ inputs.bump }} permissions: contents: write # release upload - id-token: write # OIDC for sigstore (required when attest: true) - attestations: write # GitHub native attestation API (required when attest: true) + id-token: write # OIDC for sigstore (required by the attest job) + attestations: write # GitHub native attestation API (required by the attest job) ``` ## Behaviour change **None.** Releases still trigger on signed tag-push and produce SLSA-attested archives. The `workflow_dispatch` UI button did nothing functional already; this just removes the dead button. ## Test plan - [ ] CI green on this PR - [ ] Next release of this repo continues to publish to the GitHub releases page with SLSA attestation, verifiable via `gh attestation verify <archive>.zip --owner netresearch`
2 parents 260dbcf + 202c12f commit 034aec1

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,11 @@ on:
44
push:
55
tags:
66
- 'v*'
7-
workflow_dispatch:
8-
inputs:
9-
bump:
10-
description: 'Version bump type'
11-
required: true
12-
type: choice
13-
options:
14-
- patch
15-
- minor
16-
- major
177

188
jobs:
199
release:
2010
uses: netresearch/skill-repo-skill/.github/workflows/release.yml@main
21-
with:
22-
bump: ${{ inputs.bump }}
23-
attest: true
2411
permissions:
2512
contents: write # release upload
26-
id-token: write # OIDC for sigstore (required when attest: true)
27-
attestations: write # GitHub native attestation API (required when attest: true)
13+
id-token: write # OIDC for sigstore (required by the attest job)
14+
attestations: write # GitHub native attestation API (required by the attest job)

0 commit comments

Comments
 (0)