fix(web,cli): use defaults.Set instead of hand-setting RunJob.Delete

Per review on #745: reuse the codebase's existing struct-tag-default
convention (creasty/defaults, already used in registerAllJobs) instead
of hand-setting Delete = "true". This also fixes the sibling gaps of
the same bug class for API-created and persisted run jobs: Pull
(default:"true", was silently false) and HistoryLimit (default:"10",
was 0, unbounded run history). Future-proof: defaults.Set only fills
zero values, so an explicit false survives if delete is ever exposed
in jobRequest/persist.Job.

Signed-off-by: Matheus Amendola <matheusamendolaa@gmail.com>

Author: matheusamendola

cli/daemon.go

@@ -14,6 +14,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/creasty/defaults"
 	"github.com/gobs/args"
 
 	cfgvalidator "github.com/netresearch/ofelia/config"
@@ -609,15 +610,13 @@ func (c *DaemonCommand) buildPersistedRunJob(name string, j *persist.Job, provid
 		return nil, fmt.Errorf("docker provider unavailable for run job")
 	}
 	rj := core.NewRunJob(provider)
+	// struct-tag defaults are only applied by the config decoder — apply them here too.
+	_ = defaults.Set(rj)
 	rj.Name = name
 	rj.Schedule = j.Schedule
 	rj.Command = j.Command
 	rj.Image = j.Image
 	rj.Container = j.Container
-	// Same gap as newRunJobFromRequest (web/server.go): Delete's "true" default only
-	// applies through the config.ini decoder, and persisted API jobs are rebuilt here on
-	// every daemon restart without going through it.
-	rj.Delete = "true"
 	return rj, nil
 }
 

web/server.go

@@ -16,6 +16,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/creasty/defaults"
 	"github.com/gobs/args"
 	cron "github.com/netresearch/go-cron"
 
@@ -754,17 +755,13 @@ func (s *Server) newRunJobFromRequest(req *jobRequest) (core.Job, error) {
 		return nil, fmt.Errorf("docker provider unavailable for run job")
 	}
 	j := core.NewRunJob(s.provider)
+	// struct-tag defaults are only applied by the config decoder — apply them here too.
+	_ = defaults.Set(j)
 	j.Name = req.Name
 	j.Schedule = req.Schedule
 	j.Command = req.Command
 	j.Image = req.Image
 	j.Container = req.Container
-	// RunJob.Delete only gets its "true" default (core/runjob.go) via the config.ini
-	// decoder's default-tag handling; jobs built here from a jobRequest never go through
-	// that decoder, so Delete was left at its zero value ("") and deleteContainer() treated
-	// that as false — the container from every API-created run job was left behind,
-	// colliding with the next run's `docker create` on the same name.
-	j.Delete = "true"
 	return j, nil
 }