Commit c96e6c4
authored
docs(anti-patterns): don't file a follow-up for a deliberate, documented decision (#38)
## What
Adds reviewer Process anti-pattern **#25** — the inverse of #20 ("file a
follow-up for structural `(!)` items"):
> Before raising a "gap" (missing automation, no schedule, a manual-only
check) as a `(!)` or a follow-up ticket, confirm it isn't a choice the
implementer already made **and documented**. Read the MR/PR
**description** and code/CI **comments** — the *why* — before the code.
If the rationale is there, it's `(/)` (or an `(i)` noting the tradeoff),
not a follow-up.
## Why
In a real QA batch I filed a follow-up flagging a vzdump drift-check as
a "detectable-but-not-detected gap". It wasn't: the implementer had
deliberately made it user-triggered because the Vault auth model allows
no unattended credential — documented in the MR description and the CI
comment. I'd read the code, not the documented rationale. The ticket
owner pushed back and the follow-up was closed as obsolete. This
generalizes the "treat findings as untrusted claims" discipline to the
reviewer's *own* findings.
## Follow-up (not in this PR)
A matching eval case could be added to `evals/qa-discipline.md`.
Came from /retro: yes1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
0 commit comments