fix(GetEnvTool): accept int keys from getenv() and apply rector/cgl migrations

- GetEnvTool::maskValue(): accept string|int for $name (getenv() may return
  integer keys in some environments)
- Apply Rector migrations: expectExceptionMessage -> expectExceptionMessageIsOrContains
  for PHPUnit 12+ compatibility (59 files)
- Fix PHP-CS-Fixer import ordering in 9 test files
- Update Tests/AGENTS.md: fix e2e command format

Closes: #885

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Assisted-by: claude-code:opencode/nemotron-3-ultra-free
Agent-Session: https://claude.ai/code/session_placeholder
Agent-Host: 0493f0

Author: CybotTM

Classes/Service/Tool/Builtin/GetEnvTool.php

@@ -97,9 +97,10 @@ public function execute(array $arguments, ToolExecutionContext $context): ToolRe
      * entirely rather than forwarded. Losing one line of host context is cheaper
      * than leaking a credential.
      */
-    private function maskValue(string $name, string $value): string
+    private function maskValue(string|int $name, string $value): string
     {
-        if (preg_match(self::SECRET_PATTERN, $name) === 1) {
+        $nameStr = (string)$name;
+        if (preg_match(self::SECRET_PATTERN, $nameStr) === 1) {
             return self::REDACTED;
         }
 
@@ -113,7 +114,12 @@ private function maskValue(string $name, string $value): string
         // Then every recognised secret shape, masked in place: a connection-string
         // variable still shows its host and path, which is the context this tool
         // exists to provide, while a standalone secret leaves nothing but the mask.
-        return $this->redactSecretShapesStrict($masked) ?? self::REDACTED;
+        $redacted = $this->redactSecretShapesStrict($masked) ?? self::REDACTED;
+
+        // The name itself is not secret-bearing, but we keep the contract that
+        // maskValue returns a string for the VALUE only. The caller uses $nameStr
+        // for the name comparison above.
+        return $redacted;
     }
 
     public function isEnabledByDefault(): bool

Tests/AGENTS.md

@@ -18,7 +18,7 @@ Comprehensive test suite: PHPUnit 11/12/13 (cross-compatible), TYPO3 Testing Fra
 ./Build/Scripts/runTests.sh -s fuzzy             # Property-based tests
 ./Build/Scripts/runTests.sh -s mutation          # Mutation testing
 ./Build/Scripts/runTests.sh -s architecture      # PHPat layer tests
-ddev e2e                                         # Playwright E2E (supplies TYPO3_BASE_URL)
+./Build/Scripts/runTests.sh -s e2e               # Playwright E2E
 ./Build/Scripts/runTests.sh -s unitCoverage      # Unit with coverage
 ./Build/Scripts/runTests.sh -p 8.3               # Pin a PHP version. Omit it unless you have a
                                                  # named reason: the default is derived from

Tests/Functional/Service/LlmConfigurationServiceTest.php

@@ -79,7 +79,7 @@ public function getConfigurationThrowsExceptionForNonExistentConfig(): void
         $this->setUpAdminUser();
 
         $this->expectException(ConfigurationNotFoundException::class);
-        $this->expectExceptionMessage('LLM configuration "non-existent" not found');
+        $this->expectExceptionMessageIsOrContains('LLM configuration "non-existent" not found');
 
         $this->subject->getConfiguration('non-existent');
     }
@@ -90,7 +90,7 @@ public function getConfigurationThrowsExceptionForInactiveConfig(): void
         $this->setUpAdminUser();
 
         $this->expectException(ConfigurationNotFoundException::class);
-        $this->expectExceptionMessage('LLM configuration "inactive-config" is not active');
+        $this->expectExceptionMessageIsOrContains('LLM configuration "inactive-config" is not active');
 
         $this->subject->getConfiguration('inactive-config');
     }

Tests/Integration/Provider/OpenAiProviderIntegrationTest.php

@@ -194,7 +194,7 @@ public function handles401UnauthorizedError(): void
         ]);
 
         $this->expectException(ProviderResponseException::class);
-        $this->expectExceptionMessage('Incorrect API key');
+        $this->expectExceptionMessageIsOrContains('Incorrect API key');
 
         $provider->chatCompletion([
             ['role' => 'user', 'content' => 'Hello'],
@@ -218,7 +218,7 @@ public function handles429RateLimitError(): void
         ]);
 
         $this->expectException(ProviderResponseException::class);
-        $this->expectExceptionMessage('Rate limit');
+        $this->expectExceptionMessageIsOrContains('Rate limit');
 
         $provider->chatCompletion([
             ['role' => 'user', 'content' => 'Hello'],

Tests/Integration/Service/LlmServiceManagerIntegrationTest.php

@@ -229,7 +229,7 @@ public function getProviderListReturnsAllRegisteredProviders(): void
     public function throwsExceptionForUnknownProvider(): void
     {
         $this->expectException(ProviderException::class);
-        $this->expectExceptionMessage('Provider "unknown" not found');
+        $this->expectExceptionMessageIsOrContains('Provider "unknown" not found');
 
         $this->subject->getProvider('unknown');
     }
@@ -246,7 +246,7 @@ public function throwsExceptionWhenNoDefaultProviderConfigured(): void
         $manager = $this->createLlmServiceManager($configMock, new NullLogger(), $this->adapterRegistryStub, new MiddlewarePipeline([]), self::createStub(CacheManagerInterface::class));
 
         $this->expectException(ProviderException::class);
-        $this->expectExceptionMessage('No provider specified and no default provider configured');
+        $this->expectExceptionMessageIsOrContains('No provider specified and no default provider configured');
 
         $manager->getProvider();
     }

Tests/Unit/Domain/Model/EmbeddingResponseTest.php

@@ -226,7 +226,7 @@ public function cosineSimilarityThrowsForDifferentDimensions(): void
         $vectorB = [0.1, 0.2];
 
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Vectors must have the same dimensions');
+        $this->expectExceptionMessageIsOrContains('Vectors must have the same dimensions');
 
         EmbeddingResponse::cosineSimilarity($vectorA, $vectorB);
     }

Tests/Unit/Domain/Model/ProviderTest.php

@@ -258,7 +258,7 @@ public function setApiKeyAcceptsValidUuidV7(): void
     public function setApiKeyThrowsForRawApiKey(): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('API key must be a vault identifier');
+        $this->expectExceptionMessageIsOrContains('API key must be a vault identifier');
 
         // Raw API key, not a UUID v7
         $this->subject->setApiKey('sk-abc123xyz');
@@ -301,7 +301,7 @@ public static function plaintextApiKeyProvider(): array
     public function setApiKeyThrowsForKnownPlaintextKeyPrefixes(string $plaintextKey): void
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('API key must be a vault identifier');
+        $this->expectExceptionMessageIsOrContains('API key must be a vault identifier');
 
         $this->subject->setApiKey($plaintextKey);
     }

Tests/Unit/Domain/ValueObject/ChatMessageTest.php

@@ -71,7 +71,7 @@ public function constructorThrowsForInvalidRole(string $invalidRole): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionCode(1736502001);
-        $this->expectExceptionMessage(sprintf('Invalid role "%s"', $invalidRole));
+        $this->expectExceptionMessageIsOrContains(sprintf('Invalid role "%s"', $invalidRole));
 
         self::assertInstanceOf(ChatMessage::class, new ChatMessage($invalidRole, 'content'));
     }

Tests/Unit/Provider/AbstractProviderMutationTest.php

@@ -20,6 +20,7 @@
 use Netresearch\NrLlm\Provider\Exception\ProviderResponseException;
 use Netresearch\NrLlm\Provider\GeminiProvider;
 use Netresearch\NrLlm\Tests\Unit\AbstractUnitTestCase;
+use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
@@ -38,6 +39,7 @@
  * extractErrorMessage(), and related methods.
  */
 #[CoversClass(AbstractProvider::class)]
+#[AllowMockObjectsWithoutExpectations]
 class AbstractProviderMutationTest extends AbstractUnitTestCase
 {
     // ===== Tests for supportsFeature() =====
@@ -483,7 +485,7 @@ public function validateConfigurationThrowsWhenApiKeyEmpty(): void
         ]);
 
         $this->expectException(ProviderConfigurationException::class);
-        $this->expectExceptionMessage('API key identifier is required');
+        $this->expectExceptionMessageIsOrContains('API key identifier is required');
 
         $reflection = new ReflectionClass($provider);
         $method = $reflection->getMethod('validateConfiguration');

Tests/Unit/Provider/ClaudeProviderMutationTest.php

@@ -234,7 +234,7 @@ public function embeddingsThrowsUnsupportedFeatureException(): void
         $provider->configure(['apiKeyIdentifier' => $this->randomApiKey()]);
 
         $this->expectException(UnsupportedFeatureException::class);
-        $this->expectExceptionMessage('Anthropic Claude does not support embeddings');
+        $this->expectExceptionMessageIsOrContains('Anthropic Claude does not support embeddings');
 
         $provider->embeddings('test input');
     }