Skip to content

Commit 095cc68

Browse files
CybotTMCybotTM
committed
ci: replace broken TYPO3_11 CI infrastructure with TYPO3_12 structure
Replace the non-functional TYPO3_11 CI setup with the complete, working CI infrastructure from TYPO3_12/main branches, adapted for TYPO3 v11 compatibility. Problem: -------- The existing TYPO3_11 CI workflows are broken and non-functional, preventing automated testing, quality checks, and continuous integration. The previous setup used outdated Docker-based workflows and incomplete configurations. Solution: --------- Complete replacement of CI infrastructure by backporting the proven TYPO3_12 CI setup: 1. **GitHub Actions Workflow** (.github/workflows/ci.yml) - Matrix strategy testing PHP 7.4, 8.0, 8.1, 8.2 with TYPO3 ^11.5 - Composer dependency caching for faster builds - Automated security audits (composer audit) - PHP linting, PHPStan static analysis, functional tests - Code coverage generation and Codecov upload - All steps use composer ci:* scripts for consistency 2. **Composer Scripts** (composer.json) - ci:security - Security vulnerability scanning - ci:test:php:lint - PHP syntax validation - ci:test:php:phpstan - Static analysis with PHPStan - ci:test:php:phpstan:baseline - Baseline generation - ci:test:php:functional - PHPUnit functional test suite - ci:coverage:functional - Coverage report generation - ci:test - Combined quality gate (lint + phpstan + functional) 3. **PHPStan Configuration** (Build/phpstan.neon) - Level 8 analysis (appropriate for TYPO3 v11) - Strict rules for maximum code quality - PHPUnit extension integration - Comprehensive path coverage (Classes, Configuration, Resources, Tests) - Advanced type inference and checking - Empty baseline for clean start Changes Made: ------------- **New Files:** - .github/workflows/ci.yml - Complete CI workflow for TYPO3 v11 - Build/phpstan.neon - PHPStan configuration adapted for v11 - Build/phpstan-baseline.neon - Empty baseline (clean slate) **Modified Files:** - composer.json - Added complete ci:* scripts section **Adaptations for TYPO3 v11:** - PHP version matrix: 7.4-8.2 (v11 support range) - TYPO3 constraint: ^11.5 instead of ^12.4 - PHPStan level: 8 (v11 appropriate) instead of 9 (v12) - Removed phpstan-deprecation-rules (not in v11 dependencies) - Coverage PHP version: 8.1 (stable for v11) instead of 8.2 - Included typo3/cms-recordlist dependency (v11 requirement) Technical Details: ------------------ - All CI steps use composer scripts for local reproducibility - Workflow includes proper error formatting (--error-format=github) - SQLite database driver for zero-dependency functional tests - Composer cache strategy optimizes build times - Coverage reports uploaded only on PHP 8.1 to avoid duplicates Impact: ------- ✅ Functional CI pipeline with automated quality gates ✅ Local and CI consistency through composer scripts ✅ Static analysis catches errors before review ✅ Test coverage tracking and reporting ✅ Security vulnerability monitoring ✅ Foundation for automated PR checks and branch protection
1 parent 1debb22 commit 095cc68

4 files changed

Lines changed: 159 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,104 @@
1+
# Adapted from https://github.com/TYPO3GmbH/blog/blob/master/.github/workflows/ci.yml
2+
name: CI
3+
4+
on:
5+
push:
6+
branches: [TYPO3_11]
7+
pull_request:
8+
branches: [TYPO3_11]
9+
10+
jobs:
11+
build:
12+
runs-on: ubuntu-latest
13+
14+
strategy:
15+
fail-fast: false
16+
matrix:
17+
typo3: [ '^11.5' ]
18+
php: [ '7.4', '8.0', '8.1', '8.2' ]
19+
20+
steps:
21+
- id: checkout
22+
name: Checkout
23+
uses: actions/checkout@v5
24+
25+
- id: setup_php
26+
name: Set up PHP version ${{ matrix.php }}
27+
uses: shivammathur/setup-php@v2
28+
with:
29+
php-version: ${{ matrix.php }}
30+
tools: composer:v2
31+
32+
- name: Validate composer.json and composer.lock
33+
run: composer validate
34+
35+
- id: security
36+
name: Security audit
37+
if: ${{ always() && steps.install.conclusion == 'success' }}
38+
run: |
39+
composer audit
40+
41+
- id: composer-cache-vars
42+
name: Composer Cache Vars
43+
run: |
44+
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
45+
echo "timestamp=$(date +"%s")" >> $GITHUB_OUTPUT
46+
47+
- id: composer-cache-dependencies
48+
name: Cache Composer dependencies
49+
uses: actions/cache@v4
50+
with:
51+
path: ${{ steps.composer-cache-vars.outputs.dir }}
52+
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.typo3 }}-${{ steps.composer-cache-vars.outputs.timestamp }}
53+
restore-keys: |
54+
${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.typo3 }}-
55+
${{ runner.os }}-composer-${{ matrix.php }}-
56+
${{ runner.os }}-composer-
57+
58+
- id: install
59+
name: Install dependencies with typo3/cms-core:${{ matrix.typo3 }}
60+
run: |
61+
composer require typo3/cms-core:${{ matrix.typo3 }} --no-progress --no-update
62+
composer require typo3/cms-backend:${{ matrix.typo3 }} --no-progress --no-update
63+
composer require typo3/cms-extbase:${{ matrix.typo3 }} --no-progress --no-update
64+
composer require typo3/cms-recordlist:${{ matrix.typo3 }} --no-progress --no-update
65+
composer require typo3/cms-frontend:${{ matrix.typo3 }} --no-progress --no-update
66+
composer require typo3/cms-rte-ckeditor:${{ matrix.typo3 }} --no-progress --no-update
67+
composer install
68+
git checkout composer.json
69+
70+
- id: lint
71+
name: Lint
72+
if: ${{ always() && steps.install.conclusion == 'success' }}
73+
run: |
74+
composer ci:test:php:lint
75+
76+
- id: phpstan
77+
name: PHPStan
78+
if: ${{ always() && steps.install.conclusion == 'success' }}
79+
run: |
80+
composer ci:test:php:phpstan -- --error-format=github
81+
82+
- id: functional
83+
name: Functional Tests
84+
if: ${{ always() && steps.install.conclusion == 'success' }}
85+
env:
86+
typo3DatabaseDriver: pdo_sqlite
87+
run: |
88+
composer ci:test:php:functional
89+
90+
- id: coverage
91+
name: Generate Coverage Report
92+
if: ${{ always() && steps.functional.conclusion == 'success' && matrix.php == '8.1' }}
93+
env:
94+
typo3DatabaseDriver: pdo_sqlite
95+
run: |
96+
composer ci:coverage:functional
97+
98+
- id: upload-coverage
99+
name: Upload Coverage to Codecov
100+
if: ${{ always() && steps.coverage.conclusion == 'success' && matrix.php == '8.1' }}
101+
uses: codecov/codecov-action@v5
102+
with:
103+
files: .Build/logs/clover.xml
104+
fail_ci_if_error: false

‎Build/phpstan-baseline.neon‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
parameters:
2+
ignoreErrors: []

‎Build/phpstan.neon‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
includes:
2+
- %currentWorkingDirectory%/.Build/vendor/phpstan/phpstan-strict-rules/rules.neon
3+
- %currentWorkingDirectory%/.Build/vendor/phpstan/phpstan-phpunit/rules.neon
4+
- %currentWorkingDirectory%/Build/phpstan-baseline.neon
5+
6+
parameters:
7+
# Level 8 is appropriate for TYPO3 v11 compatibility
8+
level: 8
9+
10+
paths:
11+
- %currentWorkingDirectory%/Classes/
12+
- %currentWorkingDirectory%/Configuration/
13+
- %currentWorkingDirectory%/Resources/
14+
- %currentWorkingDirectory%/Tests/
15+
- %currentWorkingDirectory%/ext_localconf.php
16+
17+
excludePaths:
18+
- %currentWorkingDirectory%/.Build/*
19+
- %currentWorkingDirectory%/ext_emconf.php
20+
21+
# Strict configuration options for maximum code quality
22+
treatPhpDocTypesAsCertain: false
23+
reportUnmatchedIgnoredErrors: true
24+
25+
# Advanced type inference and checking
26+
inferPrivatePropertyTypeFromConstructor: true
27+
checkMissingCallableSignature: true
28+
checkUninitializedProperties: true

‎composer.json‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,30 @@
4242
"extension-key": "rte_ckeditor_image",
4343
"web-dir": ".Build/Web"
4444
}
45+
},
46+
"scripts": {
47+
"ci:security": [
48+
"composer audit"
49+
],
50+
"ci:test:php:functional": [
51+
"phpunit -c Build/phpunit/FunctionalTests.xml"
52+
],
53+
"ci:test:php:lint": [
54+
"find . -name \\*.php ! -path \"./.Build/*\" -print0 | xargs -0 -n1 -P4 php -dxdebug.mode=off -l >/dev/null"
55+
],
56+
"ci:test:php:phpstan": [
57+
"phpstan analyze --configuration Build/phpstan.neon --memory-limit=-1"
58+
],
59+
"ci:test:php:phpstan:baseline": [
60+
"phpstan analyze --configuration Build/phpstan.neon --memory-limit=-1 --generate-baseline Build/phpstan-baseline.neon --allow-empty-baseline"
61+
],
62+
"ci:coverage:functional": [
63+
"phpunit -c Build/phpunit/FunctionalTests.xml --coverage-clover=.Build/logs/clover.xml --coverage-html=.Build/coverage"
64+
],
65+
"ci:test": [
66+
"@ci:test:php:lint",
67+
"@ci:test:php:phpstan",
68+
"@ci:test:php:functional"
69+
]
4570
}
4671
}

0 commit comments

Comments
 (0)