Ensure buffer is released even if future fails (#320)

Motivation:

We should release in a finally blog so we don't leak on failure

Modifications:

Move release() to finally block.

Result:

No more leaks when write fails

Author: normanmaurer

src/test/java/io/netty/incubator/codec/quic/QuicReadableTest.java

@@ -82,6 +82,7 @@ public boolean isSharable() {
                 });
         Channel channel = QuicTestUtils.newClient();
         QuicChannelValidationHandler clientHandler = new QuicChannelValidationHandler();
+        ByteBuf data = Unpooled.directBuffer().writeLong(8);
         try {
             QuicChannel quicChannel = QuicChannel.newBootstrap(channel)
                     .handler(clientHandler)
@@ -90,7 +91,6 @@ public boolean isSharable() {
                     .connect()
                     .get();
 
-            ByteBuf data = Unpooled.directBuffer().writeLong(8);
             List<Channel> streams = new ArrayList<>();
             for (int i = 0; i < numOfStreams; i++) {
                 QuicStreamChannel stream = quicChannel.createStream(
@@ -102,7 +102,6 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
                         }).get();
                 streams.add(stream.writeAndFlush(data.retainedSlice()).sync().channel());
             }
-            data.release();
             latch.await();
             while (bytesRead.get() < expectedDataRead) {
                 Thread.sleep(50);
@@ -118,6 +117,7 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
             serverHandler.assertState();
             clientHandler.assertState();
         } finally {
+            data.release();
             server.close().sync();
             // Close the parent Datagram channel as well.
             channel.close().sync();