Skip to content
This repository was archived by the owner on Apr 3, 2025. It is now read-only.

Commit 3d071dc

Browse files
committed
Log submission failures via tracing level as these are expected
Motivation: Sometimes submission of ops will fail if these are executed inline and return some error. This is expected and so we shouldn't log a warn message. That said it might still be useful to log these cases with trace level. Modifications: Log submission failures via tracing level Result: Use correct logging level that will not confuse people. This is a port of netty/netty#14671
1 parent d84c547 commit 3d071dc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

transport-classes-io_uring/src/main/java/io/netty/incubator/channel/uring/IOUringSubmissionQueue.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,8 @@ private int submit(int toSubmit, int minComplete, int flags) {
261261
if (ret < 0) {
262262
throw new RuntimeException("ioUringEnter syscall returned " + ret);
263263
}
264-
logger.warn("Not all submissions succeeded");
264+
// some submission might fail if these are done inline and failed.
265+
logger.trace("Not all submissions succeeded. Only {} of {} SQEs were submitted.", ret, toSubmit);
265266
}
266267
return ret;
267268
}

0 commit comments

Comments
 (0)