Skip to content

Complete the fix of common USB matching options for richcomm_usb #1768

Open
@jimklimov

Description

@jimklimov

Follow-up for #1763: the richcomm_usb.c source does not getval all of the common matching options, and even segfaults during a (failed) matching loop. Debug-traced output of the matching method looks different from that in the other drivers too, so maybe there is obsolete/custom logic in play?

# NUT_STATEPATH=/tmp ./drivers/richcomm_usb -s test -DDDDDD -x port=auto -x bus=000 -x vendorid=0463 -u nut
Network UPS Tools - Richcomm dry-contact to USB driver 0.11 (2.8.0-Windows-259-ge23192718)
Warning: This is an experimental driver.
Some features may not function correctly.

   0.000000     [D3] main_arg: var='port' val='auto'
   0.000030     [D5] send_to_all: SETINFO driver.parameter.port "auto"
   0.000038     [D3] main_arg: var='bus' val='000'
   0.000048     [D5] send_to_all: SETINFO driver.parameter.bus "000"
   0.000055     [D3] main_arg: var='vendorid' val='0463'
   0.000065     [D5] send_to_all: SETINFO driver.parameter.vendorid "0463"
   0.000072     [D1] Built-in default or configured user for drivers 'nobody' was ignored due to 'nut' specified on command line
   0.000081     [D1] debug level is '6'
   0.000716     [D1] Succeeded to become_user(nut): now UID=77 GID=77
   0.000737     [D5] send_to_all: SETINFO device.type "ups"
   0.003895     [D4] Failed to open USB device, skipping: Access denied (insufficient permissions)
   0.003910     [D4] Failed to open USB device, skipping: Access denied (insufficient permissions)
   0.003922     [D4] Failed to open USB device, skipping: Access denied (insufficient permissions)
   0.003936     [D4] Failed to open USB device, skipping: Access denied (insufficient permissions)
   0.425563     [D4] - VendorID     : 0463
   0.425574     [D4] - ProductID    : ffff
   0.425577     [D4] - Manufacturer : EATON
   0.425579     [D4] - Product      : Ellipse ECO
   0.425582     [D4] - Serial Number: 000000000
   0.425584     [D4] - Bus          : 003
   0.425587     [D4] Device does not match - skipping
   0.425619     [D4] - VendorID     : 1d6b
   0.425626     [D4] - ProductID    : 0002
   0.425632     [D4] - Manufacturer : unknown
   0.425637     [D4] - Product      : unknown
   0.425643     [D4] - Serial Number: unknown
   0.425649     [D4] - Bus          : 003
   0.425655     [D4] Device does not match - skipping
Segmentation fault

Originally posted by @jimklimov in #1763 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions