Skip to content

Commit cbb3310

Browse files
committed
Merge branch 'java-11' into java-record-support
# Conflicts: # .gitignore # src/test/resources/compiler/exceptions/error.html
2 parents 9b94b69 + 9070a49 commit cbb3310

4 files changed

Lines changed: 8 additions & 49 deletions

File tree

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ target/
77
!.idea/runConfigurations/
88
*.iml
99
release.properties
10-
.serena
1110
bin/
12-
.claude/settings.local.json
11+
.serena
12+
.claude/settings.local.json

pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@
7878
<maven.compiler.target>17</maven.compiler.target>
7979
<graalvm.version>25.0.0</graalvm.version>
8080
<java.version>17</java.version>
81+
<!-- Disable SHA1 checksums for Maven Central Portal (only SHA256/SHA512 accepted) -->
82+
<maven.deploy.checksums>sha256,sha512</maven.deploy.checksums>
8183
</properties>
8284

8385
<profiles>

src/main/java/de/neuland/pug4j/expression/JexlExpressionHandler.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,10 @@
1313
import org.apache.commons.logging.LogFactory;
1414

1515
import java.util.Map;
16-
import java.util.regex.Matcher;
17-
import java.util.regex.Pattern;
1816

1917
public class JexlExpressionHandler extends AbstractExpressionHandler {
2018

2119
private static final int MAX_ENTRIES = 5000;
22-
private static Pattern plusplus = Pattern.compile("([a-zA-Z0-9-_]*[a-zA-Z0-9])\\+\\+\\s*;{0,1}\\s*$");
23-
private static Pattern isplusplus = Pattern.compile("\\+\\+\\s*;{0,1}\\s*$");
24-
private static Pattern minusminus = Pattern.compile("([a-zA-Z0-9-_]*[a-zA-Z0-9])--\\s*;{0,1}\\s*$");
25-
private static Pattern isminusminus = Pattern.compile("--\\s*;{0,1}\\s*$");
2620
private JexlEngine jexl;
2721
private final JexlExpressionHandlerOptions options = new JexlExpressionHandlerOptions();
2822
private final RecordWrapperUberspect pugUberspect = new RecordWrapperUberspect(LogFactory.getLog(JexlExpressionHandler.class),
@@ -81,12 +75,6 @@ public Object evaluateExpression(String expression, PugModel model) throws Expre
8175
try {
8276
saveLocalVariableName(expression, model);
8377
expression = removeVar(expression);
84-
if (isplusplus.matcher(expression).find()) {
85-
expression = convertPlusPlusExpression(expression);
86-
}
87-
if (isminusminus.matcher(expression).find()) {
88-
expression = convertMinusMinusExpression(expression);
89-
}
9078
JexlScript e = jexl.createScript(expression);
9179
MapContext jexlContext = new MapContext(model);
9280
return e.execute(jexlContext);
@@ -95,24 +83,6 @@ public Object evaluateExpression(String expression, PugModel model) throws Expre
9583
}
9684
}
9785

98-
private String convertMinusMinusExpression(String expression) {
99-
Matcher matcher = minusminus.matcher(expression);
100-
if (matcher.find(0) && matcher.groupCount() == 1) {
101-
String a = matcher.group(1);
102-
expression = a + " = " + a + " - 1";
103-
}
104-
return expression;
105-
}
106-
107-
private String convertPlusPlusExpression(String expression) {
108-
Matcher matcher = plusplus.matcher(expression);
109-
if (matcher.find(0) && matcher.groupCount() == 1) {
110-
String a = matcher.group(1);
111-
expression = a + " = " + a + " + 1";
112-
}
113-
return expression;
114-
}
115-
11686
private String removeVar(String expression) {
11787
expression = expression.replace("var ", ";");
11888
expression = expression.replace("let ", ";");

src/test/java/de/neuland/pug4j/benchmark/TemplateBenchmark.java

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package de.neuland.pug4j.benchmark;
22

33
import de.neuland.pug4j.PugConfiguration;
4-
import de.neuland.pug4j.PugConfigurationCaffeine;
54
import de.neuland.pug4j.template.ClasspathTemplateLoader;
65
import de.neuland.pug4j.template.PugTemplate;
76
import org.openjdk.jmh.Main;
@@ -29,35 +28,23 @@ public class TemplateBenchmark {
2928

3029
HashMap<String, Object> model = new HashMap<>();
3130

32-
PugConfigurationCaffeine jadeCaffeine = new PugConfigurationCaffeine();
3331

34-
PugConfiguration jade = new PugConfiguration();
32+
PugConfiguration pug = new PugConfiguration();
3533

3634
@Setup(Level.Invocation)
3735
public void setUp() {
38-
jadeCaffeine.setTemplateLoader(templateLoader);
39-
jade.setTemplateLoader(templateLoader);
36+
pug.setTemplateLoader(templateLoader);
4037
model.put("pageName", "Jade");
4138
model.put("books", books);
4239
}
4340

44-
@Benchmark
45-
public void templatesCaffeine() throws Exception {
46-
47-
Writer writer = new StringWriter();
48-
PugTemplate template =
49-
jadeCaffeine.getTemplate("benchmark/simple" + templateId);
50-
jadeCaffeine.renderTemplate(template, model, writer);
51-
52-
}
53-
5441
@Benchmark
5542
public void templates() throws Exception {
5643

5744
Writer writer = new StringWriter();
5845
PugTemplate template =
59-
jade.getTemplate("benchmark/simple" + templateId);
60-
jade.renderTemplate(template, model, writer);
46+
pug.getTemplate("benchmark/simple" + templateId);
47+
pug.renderTemplate(template, model, writer);
6148

6249
}
6350

0 commit comments

Comments
 (0)