Skip to content

Commit 9dc0d0d

Browse files
committed
replace assertRegexpMatches with assertRegex in tests
1 parent b52035b commit 9dc0d0d

File tree

2 files changed

+29
-19
lines changed

2 files changed

+29
-19
lines changed

skipper/skipper/dataseries/tests/data_series/structure/rest_crud/test_dataseries_by_external_id_basic.py

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,38 +22,38 @@ class DataSeriesByExternalIdBasicTest(BaseViewTest):
2222
def check_urls_by_external_id(self, data_series: Dict[str, Any]) -> None:
2323
# by-external-id functionality should work, but not be the default, so we should still always give out
2424
# the canonical url, as this will always work
25-
self.assertRegexpMatches(data_series['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/')
26-
self.assertRegexpMatches(data_series['dimensions'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/dimension/')
27-
self.assertRegexpMatches(data_series['json_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/jsonfact/')
28-
self.assertRegexpMatches(data_series['timestamp_facts'],
25+
self.assertRegex(data_series['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/')
26+
self.assertRegex(data_series['dimensions'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/dimension/')
27+
self.assertRegex(data_series['json_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/jsonfact/')
28+
self.assertRegex(data_series['timestamp_facts'],
2929
DATA_SERIES_BASE_URL + r'dataseries/(.*)/timestampfact/')
30-
self.assertRegexpMatches(data_series['file_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/filefact/')
31-
self.assertRegexpMatches(data_series['image_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/imagefact/')
32-
self.assertRegexpMatches(data_series['float_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/floatfact/')
33-
self.assertRegexpMatches(data_series['boolean_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/booleanfact/')
34-
self.assertRegexpMatches(data_series['text_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/textfact/')
35-
self.assertRegexpMatches(data_series['string_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/stringfact/')
30+
self.assertRegex(data_series['file_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/filefact/')
31+
self.assertRegex(data_series['image_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/imagefact/')
32+
self.assertRegex(data_series['float_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/floatfact/')
33+
self.assertRegex(data_series['boolean_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/booleanfact/')
34+
self.assertRegex(data_series['text_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/textfact/')
35+
self.assertRegex(data_series['string_facts'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/stringfact/')
3636

37-
self.assertRegexpMatches(data_series['data_points'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/datapoint/')
37+
self.assertRegex(data_series['data_points'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/datapoint/')
3838

39-
self.assertRegexpMatches(data_series['data_points_bulk'],
39+
self.assertRegex(data_series['data_points_bulk'],
4040
DATA_SERIES_BASE_URL + r'dataseries/(.*)/bulk/datapoint/')
41-
self.assertRegexpMatches(data_series['data_point_validate_external_ids'],
41+
self.assertRegex(data_series['data_point_validate_external_ids'],
4242
DATA_SERIES_BASE_URL + r'dataseries/(.*)/bulk/check-external-ids/')
4343

44-
self.assertRegexpMatches(data_series['cube_sql'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/cubesql/')
45-
self.assertRegexpMatches(data_series['create_view'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/createview/')
44+
self.assertRegex(data_series['cube_sql'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/cubesql/')
45+
self.assertRegex(data_series['create_view'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/createview/')
4646

4747
def check_urls_by_external_id_dp(self, data_point: Dict[str, Any]) -> None:
48-
self.assertRegexpMatches(data_point['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/datapoint/(.*)/')
48+
self.assertRegex(data_point['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/datapoint/(.*)/')
4949

5050
def check_urls_by_external_id_fact(self, fact: Dict[str, Any], fact_type: str) -> None:
51-
self.assertRegexpMatches(fact['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/' + fact_type + 'fact/(.*)/')
51+
self.assertRegex(fact['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/' + fact_type + 'fact/(.*)/')
5252

5353
def check_urls_by_external_id_dimension(self, fact: Dict[str, Any]) -> None:
54-
self.assertRegexpMatches(fact['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/dimension/(.*)/')
54+
self.assertRegex(fact['url'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/dimension/(.*)/')
5555

56-
self.assertRegexpMatches(fact['reference'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/')
56+
self.assertRegex(fact['reference'], DATA_SERIES_BASE_URL + r'dataseries/(.*)/')
5757

5858
def test_create_broken_url_data_series(self) -> None:
5959
# for dataseries it should be impossible to create weird situations where

skipper/skipper/urls.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,17 @@ def tenant_object(self: Any) -> Any:
5656

5757
TenantModelMixin.tenant_object = tenant_object
5858

59+
def _do_update(self: Any, *args: Any, **kwargs: Any) -> Any:
60+
"""
61+
This method is patched to be compatible with Django 6.0+
62+
which passes one additional argument (forced_update) to _do_update
63+
"""
64+
# Call the parent class _do_update with all arguments
65+
return super(TenantModelMixin, self)._do_update(*args, **kwargs)
5966

67+
TenantModelMixin._do_update = _do_update
68+
69+
6070
monkey_patch_multitenant()
6171

6272

0 commit comments

Comments
 (0)