Skip to content

basic NetCon graph in ModelView - #1912

Draft
ramcdougal wants to merge 2 commits into
masterfrom
modelview-netcon
Draft

basic NetCon graph in ModelView#1912
ramcdougal wants to merge 2 commits into
masterfrom
modelview-netcon

Conversation

@ramcdougal

@ramcdougal ramcdougal commented Jul 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Selecting the "### NetCon objects" in a ModelView shows a graph of the pre/post NetCon relationships by cell.

e.g. for the model of Short et al., 2016 (http://modeldb.yale.edu/183300)

image

This works best for small networks. Cells of the same type are grouped together.

To do:

  • Something reasonable when no cell object is specified; right now, these are lumped in with artificial cells, which is incorrect.
  • Something reasonable for NetCons connected using gids and the ParallelContext framework.
  • Clicking a submenu ought to restrict the set of NetCons plotted to whatever was in the submenu... e.g. if there's a line that says "3 threshold = -20", clicking that ought to show us just those NetCons.

ramcdougal
ramcdougal commented Jul 11, 2022
View reviewed changes
Comment thread share/lib/hoc/mview/mview1.hoc
sprint(tstr, "%d NetCon objects", tobj.count)
display.top.append(new TreeViewItem(nil, tstr))
mvncgrapher = new ModelViewNetConGrapher(this)
display.top.append(new TreeViewItem(nil, tstr, mvncgrapher, 1.7))

@ramcdougal ramcdougal Jul 11, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to confirm this is okay if there are no NetCons

@codecov-commenter

codecov-commenter commented Jul 11, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.61538% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.10%. Comparing base (622f1a8) to head (312859c).
⚠️ Report is 2888 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/__init__.py 4.61% 62 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   47.12%   47.10%   -0.03%     
==========================================
  Files         543      543              
  Lines      112929   112994      +65     
==========================================
+ Hits        53223    53226       +3     
- Misses      59706    59768      +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@azure-pipelines

azure-pipelines Bot commented Jul 11, 2022

Copy link
Copy Markdown

✔️ 312859c -> Azure artifacts URL

@ramcdougal ramcdougal added this to the Release v9.0 milestone May 23, 2023
@ramcdougal ramcdougal self-assigned this May 23, 2023
@ramcdougal ramcdougal modified the milestones: Release v9.0, Release v9.1 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ramcdougal ramcdougal

Labels

enhancement gui

Projects

None yet

Milestone

Release v9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@ramcdougal @codecov-commenter