[FIX] pull sample_size metadata from study if not in analysis (#939)

* look into study as well as analysis for sample_size

* fix style

* fix docstring

Author: jdkent

nimare/io.py

@@ -63,8 +63,12 @@ def _analysis_to_dict(study, analysis):
             },
         }
 
-        sample_sizes = analysis.metadata.get("sample_sizes", None)
-        sample_size = analysis.metadata.get("sample_size", None)
+        sample_sizes = analysis.metadata.get("sample_sizes", None) or study.metadata.get(
+            "sample_sizes", None
+        )
+        sample_size = analysis.metadata.get("sample_size", None) or study.metadata.get(
+            "sample_size", None
+        )
 
         # Validate sample sizes if present
         if sample_sizes is not None and not isinstance(sample_sizes, (list, tuple)):

nimare/tests/conftest.py

@@ -172,6 +172,20 @@ def testdata_ibma_resample(tmp_path_factory):
     return dset
 
 
+@pytest.fixture(scope="session")
+def sample_size_nimads_studyset():
+    """Download/lookup example NiMADS studyset."""
+    out_file = os.path.join(get_test_data_path(), "sample_size_nimads_studyset.json")
+    if not os.path.isfile(out_file):
+        url = "https://neurostore.org/api/studysets/zvE8LEQHAJxV?nested=true"
+        response = request("GET", url)
+        with open(out_file, "wb") as f:
+            f.write(response.content)
+    with open(out_file, "r") as f:
+        studyset = json.load(f)
+    return studyset
+
+
 @pytest.fixture(scope="session")
 def example_nimads_studyset():
     """Download/lookup example NiMADS studyset."""

nimare/tests/data/sample_size_nimads_studyset.json

@@ -38,9 +38,7 @@ def test_convert_nimads_to_dataset_sample_sizes(
     assert "sample_sizes" in dset.metadata.columns
 
 
-def test_convert_nimads_to_dataset_single_sample_size(
-    example_nimads_studyset, example_nimads_annotation
-):
+def test_convert_nimads_to_dataset_single_sample_size(example_nimads_studyset):
     """Test conversion of nimads JSON to nimare dataset with a single sample size value."""
     studyset = Studyset(example_nimads_studyset)
     for study in studyset.studies:
@@ -53,6 +51,16 @@ def test_convert_nimads_to_dataset_single_sample_size(
     assert "sample_sizes" in dset.metadata.columns
 
 
+def test_convert_nimads_to_dataset_wonky_sample_size(sample_size_nimads_studyset):
+    """Test conversion of nimads JSON to nimare dataset with wonky sample size values."""
+    studyset = Studyset(sample_size_nimads_studyset)
+
+    dset = io.convert_nimads_to_dataset(studyset)
+
+    assert isinstance(dset, nimare.dataset.Dataset)
+    assert "sample_sizes" in dset.metadata.columns
+
+
 @pytest.mark.parametrize(
     "sample_sizes_val,sample_size_val,expect_col,expect_warning",
     [