[FIX] cloning (#715)

* fix schema weirdness

* fix more schema weirdness

Author: jdkent

store/neurostore/schemas/data.py

@@ -277,7 +277,7 @@ def load_values(self, data, **kwargs):
             ]
         elif data.get("conditions") is not None:
             data["analysis_conditions"] = [
-                {"condition": cond} for cond in data.get("conditions")
+                {"condition": cond, "weight": 0} for cond in data.get("conditions")
             ]
 
         data.pop("conditions", None)
@@ -288,6 +288,7 @@ def load_values(self, data, **kwargs):
     def dump_values(self, data, **kwargs):
         if data.get("analysis_conditions") is not None:
             data["conditions"] = [ac["condition"] for ac in data["analysis_conditions"]]
+            data["weights"] = [ac["weight"] for ac in data["analysis_conditions"]]
         data.pop("analysis_conditions", None)
 
         return data

store/neurostore/tests/api/test_studies.py

@@ -89,7 +89,7 @@ def test_put_studies(auth_client, ingest_neurosynth, data, session):
     assert put_resp.json()["metadata"] == updated_study_entry.metadata_
 
 
-def test_clone_studies(auth_client, ingest_neurosynth, session):
+def test_clone_studies(auth_client, ingest_neurovault, session):
     study_entry = Study.query.first()
     resp = auth_client.post(f"/api/studies/?source_id={study_entry.id}", data={})
     data = resp.json()