[MNT] migrate to connexion 3.0 #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkent
commented
Sep 17, 2025
| commit_session() | ||
|
|
||
| return 204 | ||
| return _make_json_response({}, status=200) |
Member
Author
There was a problem hiding this comment.
a successful delete should return a 204, not a 200
Comment on lines
+107
to
+130
| def __init__(self, response): | ||
| self._response = response | ||
| self._cached = None | ||
|
|
||
| def _get(self): | ||
| if self._cached is None: | ||
| self._cached = self._response.json() | ||
| return self._cached | ||
|
|
||
| def __call__(self): | ||
| return self._get() | ||
|
|
||
| def __getitem__(self, item): | ||
| return self._get()[item] | ||
|
|
||
| def __iter__(self): | ||
| return iter(self._get()) | ||
|
|
||
| def __len__(self): | ||
| return len(self._get()) | ||
|
|
||
| def get(self, key, default=None): | ||
| return self._get().get(key, default) | ||
|
|
Member
Author
There was a problem hiding this comment.
this can be simplified at some future date.
This was referenced Sep 17, 2025
chore(deps): update connexion[swagger-ui] requirement from ~=2.13 to ~=3.2 in /compose/backend
#1028
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.