Skip to content

Conversation

@jdkent
Copy link
Member

@jdkent jdkent commented Oct 17, 2025

attempt to not try to remove the auto-generated partitioned table.

@jdkent jdkent merged commit 03f9898 into master Oct 17, 2025
17 of 18 checks passed
@jdkent jdkent deleted the fix/alembic_migration branch October 17, 2025 06:55
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +24 to +27
if (
type_ in {"index", "constraint"}
and name.startswith("pe_")
and (name.endswith("_hnsw") or name.endswith("_dims_chk"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard include_object against unnamed constraints

include_object now unconditionally calls name.startswith for any index or constraint. Alembic invokes this callback with name=None for metadata constraints or indexes that were defined without an explicit name. When such objects exist, flask db migrate will crash with an AttributeError before generating migrations, blocking schema changes. Check that name is truthy before using string methods or handle unnamed objects separately.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants