Skip to content

Conversation

@jdkent
Copy link
Member

@jdkent jdkent commented Nov 20, 2025

closes #1207

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +694 to +697
analyses, points, tables = process_coordinates(pmid, s, metadata_row)
to_commit.extend(points)
to_commit.extend(analyses)
to_commit.extend(tables)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unpack failure when ACE metadata lacks coordinates

In ace_ingestion_logic, the call analyses, points, tables = process_coordinates(pmid, s, metadata_row) now expects three return values, but process_coordinates still returns only two when a study has no coordinates (the KeyError branch at lines 574-578). If an ACE metadata row is missing from coordinates_df this unpack will raise ValueError and abort ingestion instead of skipping the study as before. Update the error path to return a third value so missing-coordinate records no longer crash the ingest.

Useful? React with 👍 / 👎.

@jdkent jdkent merged commit 06e9b2b into master Nov 20, 2025
18 checks passed
@jdkent jdkent deleted the enh/add_table branch November 20, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add table number and name as specific attributes for each analysis

2 participants