-
Notifications
You must be signed in to change notification settings - Fork 6
Feat 839 update visualizer with niivue #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…visualizer-with-niivue
…39-update-visualizer-with-niivue
…39-update-visualizer-with-niivue
|
The feedback that I received from this PR is that the niivue min and max should be adjustable, and that some of the values disappear when the max is increased (even though they are above some threshold). These are issues to be fixed on the niivue side. I've raised an issue, and it is being addresses via this PR |
|
No mechanism exists in which we can allow for a soft threshold (translucent subthreshold) AND provide an adjustable min value it seems. We can only choose either (1) having an adjustable min or (2) having the translucent sub threshold |
|
@adelavega can you review https://synth.neurostore.xyz/ and let me know if it looks good to merge in? |
|
Looks good to me! Only minor comment I have is if perhaps we could add a info hover over to explain what a soft threshold is |
No description provided.