Skip to content

Conversation

@nicoalee
Copy link
Collaborator

@nicoalee nicoalee commented Jan 6, 2025

No description provided.

@nicoalee nicoalee linked an issue Jan 6, 2025 that may be closed by this pull request
@nicoalee
Copy link
Collaborator Author

The feedback that I received from this PR is that the niivue min and max should be adjustable, and that some of the values disappear when the max is increased (even though they are above some threshold). These are issues to be fixed on the niivue side. I've raised an issue, and it is being addresses via this PR

@nicoalee
Copy link
Collaborator Author

No mechanism exists in which we can allow for a soft threshold (translucent subthreshold) AND provide an adjustable min value it seems. We can only choose either (1) having an adjustable min or (2) having the translucent sub threshold

@nicoalee
Copy link
Collaborator Author

nicoalee commented Feb 2, 2025

@adelavega can you review https://synth.neurostore.xyz/ and let me know if it looks good to merge in?

@adelavega
Copy link
Member

Looks good to me! Only minor comment I have is if perhaps we could add a info hover over to explain what a soft threshold is

@nicoalee nicoalee merged commit 666496f into master Feb 27, 2025
31 checks passed
@nicoalee nicoalee deleted the FEAT-839-update-visualizer-with-niivue branch February 27, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update visualizer with niivue

4 participants