Skip to content

Commit e0b2fb9

Browse files
committed
TYP/BUG: fix incompatible method override signature
1 parent f6539f0 commit e0b2fb9

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,9 @@ known-third-party = [
102102
]
103103
known-first-party = ["yt", "yt_idefix"]
104104

105+
[tool.ty.rules]
106+
unused-type-ignore-comment = "ignore"
107+
105108
[tool.mypy]
106109
python_version = '3.10'
107110
show_error_codes = true

src/yt_idefix/fields.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
from yt.fields.field_info_container import FieldInfoContainer
22
from yt.fields.magnetic_field import setup_magnetic_field_aliases
33

4+
import sys
45

6+
if sys.version_info >= (3, 12):
7+
from typing import override
8+
else:
9+
from typing_extensions import override
510
class IdefixVtkFields(FieldInfoContainer):
611
known_other_fields = (
712
("RHO", ("code_mass / code_length**3", ["density"], None)), # type: ignore
@@ -30,6 +35,7 @@ class IdefixVtkFields(FieldInfoContainer):
3035
),
3136
)
3237

38+
@override
3339
def setup_fluid_fields(self):
3440
setup_magnetic_field_aliases(
3541
self, "idefix-vtk", [f"BX{idir}" for idir in "123"]
@@ -52,6 +58,7 @@ class IdefixDmpFields(FieldInfoContainer):
5258

5359
known_particle_fields = ()
5460

61+
@override
5562
def setup_fluid_fields(self):
5663
setup_magnetic_field_aliases(
5764
self, "idefix-dmp", [f"Vc-BX{idir}" for idir in "123"]
@@ -110,12 +117,14 @@ class PlutoFields(FieldInfoContainer):
110117

111118
known_particle_fields = ()
112119

120+
@override
113121
def setup_fluid_fields(self):
114122
setup_magnetic_field_aliases(
115123
self, self.ds._dataset_type, [f"BX{idir}" for idir in "123"]
116124
)
117125

118-
def setup_particle_fields(self, ptype):
126+
@override
127+
def setup_particle_fields(self, ptype: str, ftype: str="gas", num_neighbors:int=64) -> None:
119128
super().setup_particle_fields(ptype)
120129
# This will get called for every particle type.
121130
# {TODO} Starting with version 4.4 PLUTO has particle support and this function needs an implementation in future

0 commit comments

Comments
 (0)