Character preview clipping when switching species

[PeccNeck]

What version did the issue occur in?

Dev environment (master)

Description

Title. When switching between two characters with different species scaling, the character preview may clip if switching from a smaller species to a larger one (e.g. dwarf -> moth).

Media

Moth -> Dwarf

Dwarf -> Moth

Difference

Reproduction

1. Have a small-species character (i.e. Dwarf).
2. Enter profile editor.
   • If you had another character selected, select the dwarf and then refresh the lobby.
   • disconnect, then reconnect (or join/observe then respawn) to do so.
3. Change to a species larger than previous (i.e. anything larger than dwarf).
4. Observe clipping.

Also occurs when switching characters entirely, starting from step 3 onwards.

Additional Context

Does not occur upstream. Partly because they gave dwarves a unique appearance instead of just scaling a human, but mainly the part where we're almost a year behind and it seems they fixed the underlying bug somewhere in that time. (I tested by re-adding ScaleVisuals by hand, bug still didn't occur upstream.)

[JojyAsmir]

Worth noting that this also affects sprite exporting, both with the button in character creation, AND ingame using the Debug menu while adminned. So it's not just the visual preview.