fix: s3 connect error log (labring#362)

Author: FinleyGe

lib/s3/index.ts

@@ -90,40 +90,40 @@ const createS3Service = async (bucket: string, isPublic: boolean) => {
     }
   };
 
-  try {
-    await client.ensureBucket();
-    if (isPublic) await ensurePublicPolicy(client);
-  } catch (error) {
-    logger.info(`Failed to ensure bucket "${bucket}" exists:`, { error });
-  }
+  await client.ensureBucket();
+  if (isPublic) await ensurePublicPolicy(client);
 
-  try {
-    await externalClient?.ensureBucket();
-    if (isPublic && externalClient) await ensurePublicPolicy(externalClient);
-  } catch (error) {
-    logger.info(`Failed to ensure bucket "${bucket}" exists:`, { error });
-  }
+  await externalClient?.ensureBucket();
+  if (isPublic && externalClient) await ensurePublicPolicy(externalClient);
 
   return new S3Service(client, externalClient);
 };
 
-export const publicS3Server = await (async () => {
-  if (!global._publicS3Server) {
-    const { publicBucket } = getConfig();
-    global._publicS3Server = await createS3Service(publicBucket, true);
-  }
-  return global._publicS3Server;
-})();
-
-export const privateS3Server = await (async () => {
-  if (!global._privateS3Server) {
-    const { privateBucket } = getConfig();
-    global._privateS3Server = await createS3Service(privateBucket, false);
-  }
-  return global._privateS3Server;
-})();
-
 declare global {
   var _publicS3Server: S3Service;
   var _privateS3Server: S3Service;
 }
+
+export const initS3Service = async () => {
+  const logger = getLogger(infra.storage);
+  logger.info('Initializing S3 service...');
+  const { publicBucket, privateBucket } = getConfig();
+
+  try {
+    if (!globalThis._publicS3Server) {
+      logger.debug('Initializing public S3 service...');
+      globalThis._publicS3Server = await createS3Service(publicBucket, true);
+    }
+
+    if (!globalThis._privateS3Server) {
+      logger.debug('Initializing private S3 service...');
+      globalThis._privateS3Server = await createS3Service(privateBucket, false);
+    }
+  } catch (e) {
+    logger.error('Failed to initialize S3 service:', { error: e });
+    throw new Error('Failed to initialize S3 service');
+  }
+};
+
+export const publicS3Server = globalThis._publicS3Server;
+export const privateS3Server = globalThis._privateS3Server;

runtime/index.ts

@@ -1,6 +1,6 @@
 import { getCachedData, refreshVersionKey } from '@/cache';
 import { SystemCacheKeyEnum } from '@/cache/type';
-import { connectionMongo, connectMongo, MONGO_URL } from '@/mongo';
+import { connectionMongo, connectMongo, delay, MONGO_URL } from '@/mongo';
 import { ensureDir, refreshDir } from '@/utils/fs';
 import { configureLogger, getLogger, root, destroyLogger } from '@/logger';
 import { env } from '@/env';
@@ -10,6 +10,7 @@ import { tempDir, tempToolsDir } from '@tool/constants';
 import { initWorkflowTemplates } from '@workflow/init';
 import { serve, type ServerType } from '@hono/node-server';
 import { app } from './app';
+import { initS3Service } from '@/s3';
 
 const logger = getLogger(root);
 
@@ -24,6 +25,7 @@ async function prepare() {
   await configureLogger(); // setup logger
 
   await connectMongo(connectionMongo, MONGO_URL); // connect to MongoDB
+  await initS3Service();
 
   await refreshDir(tempDir); // cleanup 'tmp' directory
   await ensureDir(tempToolsDir); // ensure temp tools directory