Skip to content

Commit 12eabb8

Browse files
committed
fix: duplicate CMS key and casing for login pages
1 parent 43c36be commit 12eabb8

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

content/src/fieldConfig/login-support-page.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"unlinkedAccount": "It looks like you haven’t linked your myNewJersey account.",
44
"havingTrouble": "Having trouble logging in?",
55
"logoutButtonText": "Log out",
6-
"logoutButtonTextUnlinked": "log out",
76
"logoutAndTryAgain": "~~logoutButton~~ and try again.",
87
"logoutAndTryAgainUnlinked": "Please ~~logoutButton~~ and try again.",
98
"forMoreAssistance": "For more assistance, visit our [Login Issues Help page](support/login).",
@@ -43,7 +42,6 @@
4342
}
4443
],
4544
"logoutIfStillHavingTrouble": "If you're still having trouble, ~~logoutButton~~ to reset your session on [account.business.nj.gov](https://account.business.nj.gov), and repeat the steps above.",
46-
"logoutButtonText": "log out",
4745
"supportCallout": {
4846
"header": "Dedicated Business Experts ready to help",
4947
"body": "Still having issues? Chat with a business advocate based in New Jersey.",

web/decap-config/collections/13-support.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ collections:
2424
- { label: "Unlinked Account", name: "unlinkedAccount", widget: "string" }
2525
- { label: "Having Trouble", name: "havingTrouble", widget: "string" }
2626
- { label: "Logout Button Text", name: "logoutButtonText", widget: "string" }
27-
- {
28-
label: "Logout Button Text Unlinked",
29-
name: "logoutButtonTextUnlinked",
30-
widget: "string",
31-
}
3227
- { label: "Logout And Try Again", name: "logoutAndTryAgain", widget: "string" }
3328
- {
3429
label: "Logout And Try Again Unlinked",

web/src/components/LoadingPageComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const LoadingPageComponent = ({
3333
className="logout-button-unstyled"
3434
>
3535
{isLinkingError
36-
? Config.loginSupportPage.logoutButtonTextUnlinked
36+
? Config.loginSupportPage.logoutButtonText.toLowerCase()
3737
: Config.loginSupportPage.logoutButtonText}
3838
</UnStyledButton>
3939
),

web/src/pages/support/login.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const LoginSupportPage = (): ReactElement => {
2828
}}
2929
className="logout-button-unstyled"
3030
>
31-
{loginSupport.logoutButtonText}
31+
{loginSupport.logoutButtonText.toLowerCase()}
3232
</UnStyledButton>
3333
),
3434
};

web/test/components/LoadingPageComponent.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ describe("LoadingPageComponent", () => {
3434
expect(screen.getByText(Config.loginSupportPage.unlinkedAccount)).toBeInTheDocument();
3535

3636
expect(
37-
screen.getByRole("button", { name: Config.loginSupportPage.logoutButtonTextUnlinked }),
37+
screen.getByRole("button", {
38+
name: Config.loginSupportPage.logoutButtonText.toLowerCase(),
39+
}),
3840
).toBeInTheDocument();
3941
expect(screen.getByText(/please/i)).toBeInTheDocument();
4042
expect(screen.getByText(/and try again/i)).toBeInTheDocument();

0 commit comments

Comments
 (0)