feat: [AB#17075] auto promotion for non essential questions associated with anytime actions to recommended for you category

adidner · adidner · commit 5a23a914b547 · 2025-12-22T08:51:31.000-05:00
diff --git a/shared/src/types/types.ts b/shared/src/types/types.ts
@@ -165,7 +165,6 @@ export interface AnytimeActionTask extends AnytimeAction {
   callToActionText?: string;
   issuingAgency?: string;
   moveToRecommendedForYouSection?: boolean;
-  nonEssentialQuestionsMoveToRecommendedAnytimeActionIds?: string[];
   industryIds: string[];
   sectorIds: string[];
   applyToAllUsers: boolean;
diff --git a/web/decap-config/collections/05-roadmap.yml b/web/decap-config/collections/05-roadmap.yml
@@ -319,9 +319,12 @@ collections:
                 value_field: "{{fields.id}}"
                 display_fields: [displayname]
                 options_length: 9999
-              - label: Anytime Actions Tasks
+              - label: Anytime Actions Tasks (Added when Non Essential Question is Answered Yes)
                 name: anytimeActions
-                hint: Anytime Actions related to reinstatements are not included in this dropdown
+                hint:
+                  (Anytime Actions chosen will automatically be displayed in the Recommended for You
+                  section for the user)(Anytime Actions related to reinstatements are not included
+                  in this dropdown)
                 required: false
                 default: []
                 widget: relation
diff --git a/web/decap-config/collections/10-anytime-action.yml b/web/decap-config/collections/10-anytime-action.yml
@@ -92,18 +92,6 @@ collections:
           widget: "boolean",
           required: false,
         }
-      - label:
-          Non Essential Questions which will move this to recommended for you section if answered
-          yes
-        name: nonEssentialQuestionsMoveToRecommendedAnytimeActionIds
-        widget: relation
-        multiple: true
-        required: false
-        default: []
-        collection: "nonEssentialQuestionsCollection"
-        search_fields: ["nonEssentialQuestionsArray.*.id"]
-        value_field: "nonEssentialQuestionsArray.*.id"
-        display_fields: ["nonEssentialQuestionsArray.*.id"]
       - {
           label: "Url Slug - Internal Routing",
           name: "urlSlug",
diff --git a/web/src/components/dashboard/AnytimeActionSearch.test.tsx b/web/src/components/dashboard/AnytimeActionSearch.test.tsx
@@ -19,7 +19,7 @@ import {
 import { fireEvent, render, screen } from "@testing-library/react";
 
 import { AnytimeActionSearch } from "@/components/dashboard/AnytimeActionSearch";
-import { taskIdLicenseNameMapping } from "@businessnjgovnavigator/shared/index";
+import { getMergedConfig, taskIdLicenseNameMapping } from "@businessnjgovnavigator/shared/index";
 import userEvent from "@testing-library/user-event";
 
 function setupMockAnalytics(): typeof analytics {
@@ -50,6 +50,8 @@ describe("<AnytimeActionSearch />", () => {
   const taskName = "some-task-name";
   const licenseReinstatementName = "some-license-reinstatement-name";
 
+  const Config = getMergedConfig();
+
   const anytimeActionTasksAlternate = [
     generateAnytimeActionTask({
       name: "test-title-1",
@@ -226,6 +228,7 @@ describe("<AnytimeActionSearch />", () => {
           filename: "some-filename-license",
         }),
       ];
+      anytimeActionTasksFromNonEssentialQuestions = [];
     });
 
     const renderAnytimeActionSearch = (): void => {
@@ -398,6 +401,60 @@ describe("<AnytimeActionSearch />", () => {
       expect(screen.queryByText("license - hvac-reinstatement")).not.toBeInTheDocument();
     });
 
+    it("creates and moves anytime action to recommended for you section when flag is set", () => {
+      anytimeActionTasks = [
+        generateAnytimeActionTask({
+          filename: "vacant-building-fire-permit",
+          moveToRecommendedForYouSection: true,
+        }),
+        ...anytimeActionTasks,
+      ];
+      anytimeActionTasksFromNonEssentialQuestions = [];
+
+      useMockBusiness({
+        profileData: generateProfileData({
+          vacantPropertyOwner: true,
+        }),
+      });
+      renderAnytimeActionSearch();
+      fireEvent.click(screen.getByLabelText("Open"));
+      const nonEssentialAnytimeAction = screen.getByTestId("vacant-building-fire-permit-option");
+      const recommendedForYouCategory = screen.getByText(
+        Config.dashboardAnytimeActionDefaults.recommendedForYouCategoryHeader,
+      );
+      const category1Title = screen.getByText("Some Category");
+      expect(recommendedForYouCategory.compareDocumentPosition(nonEssentialAnytimeAction)).toBe(
+        Node.DOCUMENT_POSITION_FOLLOWING,
+      );
+      expect(nonEssentialAnytimeAction.compareDocumentPosition(category1Title)).toBe(
+        Node.DOCUMENT_POSITION_FOLLOWING,
+      );
+    });
+
+    it("does not creates recommended for you section when flag is set and nonEssentialQuestions is empty", () => {
+      anytimeActionTasks = [
+        generateAnytimeActionTask({
+          filename: "vacant-building-fire-permit",
+          moveToRecommendedForYouSection: false,
+        }),
+        ...anytimeActionTasks,
+      ];
+
+      anytimeActionTasksFromNonEssentialQuestions = [];
+
+      useMockBusiness({
+        profileData: generateProfileData({
+          vacantPropertyOwner: true,
+        }),
+      });
+      renderAnytimeActionSearch();
+      fireEvent.click(screen.getByLabelText("Open"));
+      expect(screen.getByTestId("vacant-building-fire-permit-option")).toBeInTheDocument();
+      expect(
+        screen.queryByText(Config.dashboardAnytimeActionDefaults.recommendedForYouCategoryHeader),
+      ).not.toBeInTheDocument();
+    });
+
     describe("non essential questions", () => {
       it("duplicate Anytime Actions added via non-essential questions are removed", () => {
         const duplicateAnytimeAction = generateAnytimeActionTask({
@@ -413,10 +470,35 @@ describe("<AnytimeActionSearch />", () => {
         expect(screen.getAllByText("same-anytime-action").length).toBe(1);
       });
 
+      it("promotes non essential questions to the recommended for you section", () => {
+        anytimeActionTasksFromNonEssentialQuestions = [
+          generateAnytimeActionTask({ filename: "vacant-building-fire-permit" }),
+          ...anytimeActionTasksFromNonEssentialQuestions,
+        ];
+
+        useMockBusiness({
+          profileData: generateProfileData({
+            vacantPropertyOwner: true,
+          }),
+        });
+        renderAnytimeActionSearch();
+        fireEvent.click(screen.getByLabelText("Open"));
+        const nonEssentialAnytimeAction = screen.getByTestId("vacant-building-fire-permit-option");
+        const recommendedForYouCategory = screen.getByText(
+          Config.dashboardAnytimeActionDefaults.recommendedForYouCategoryHeader,
+        );
+        const category1Title = screen.getByText("Some Category");
+        expect(recommendedForYouCategory.compareDocumentPosition(nonEssentialAnytimeAction)).toBe(
+          Node.DOCUMENT_POSITION_FOLLOWING,
+        );
+        expect(nonEssentialAnytimeAction.compareDocumentPosition(category1Title)).toBe(
+          Node.DOCUMENT_POSITION_FOLLOWING,
+        );
+      });
+
       it("adds vacant property anytime action for vacant property owners", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "vacant-building-fire-permit" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
@@ -440,7 +522,6 @@ describe("<AnytimeActionSearch />", () => {
       it("adds fire carnival modification for carnival ride owning businesses", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "carnival-ride-supplemental-modification" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
@@ -468,7 +549,6 @@ describe("<AnytimeActionSearch />", () => {
       it("adds operating carnival fire permit for carnival owning businesses", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "operating-carnival-fire-permit" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
@@ -496,7 +576,6 @@ describe("<AnytimeActionSearch />", () => {
       it("adds operating carnival fire permit for traveling circus or carnival owning businesses", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "operating-carnival-fire-permit" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
@@ -524,7 +603,6 @@ describe("<AnytimeActionSearch />", () => {
       it("adds operating carnival fire permit for traveling circus or carnival owning businesses based on non-essential question answers", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "operating-carnival-fire-permit" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
@@ -560,7 +638,6 @@ describe("<AnytimeActionSearch />", () => {
       it("adds carnival ride supplemental modification for traveling circus or carnival owning businesses based on non-essential question answers", () => {
         anytimeActionTasks = [
           generateAnytimeActionTask({ filename: "carnival-ride-supplemental-modification" }),
-          ...anytimeActionTasks,
         ];
         useMockBusiness({
           profileData: generateProfileData({
diff --git a/web/src/components/dashboard/AnytimeActionSearch.tsx b/web/src/components/dashboard/AnytimeActionSearch.tsx
@@ -12,7 +12,7 @@ import {
   AnytimeActionTask,
 } from "@businessnjgovnavigator/shared/types";
 import { Autocomplete, TextField, useMediaQuery } from "@mui/material";
-import { orderBy, unionBy } from "lodash";
+import { orderBy } from "lodash";
 import { useRouter } from "next/compat/router";
 import { type ReactElement, ReactNode, useState } from "react";
 
@@ -73,21 +73,28 @@ export const AnytimeActionSearch = (props: Props): ReactElement => {
       }),
     ];
 
-    const deduplicatedTasks = unionBy(
+    const deduplicatedTasks = removeNonEssentialAnytimeActionTasksFromGenericAnytimeActionList(
       tasks,
       props.anytimeActionTasksFromNonEssentialQuestions,
-      "name",
     );
 
-    const orderedTasks = orderBy(deduplicatedTasks, ["name"]);
-    const orderedReinstatements = orderBy(reinstatements, ["name"]);
+    const nonEssentialAnytimeActionsWithRecommendedCategory =
+      moveNonEssentialAnyTimeActionsToRecommendeForYou(
+        props.anytimeActionTasksFromNonEssentialQuestions,
+      );
+    const allTasks = [...nonEssentialAnytimeActionsWithRecommendedCategory, ...deduplicatedTasks];
 
-    const allActions = [...orderedTasks, ...orderedReinstatements];
+    const allActions = [...allTasks, ...reinstatements];
+    const allActionsOrdered = orderBy(allActions, ["name"]);
 
-    return allActions.sort((a, b) => {
+    return allActionsOrdered.sort((a, b) => {
       const categoryA = a.category[0].categoryName.toLowerCase();
       const categoryB = b.category[0].categoryName.toLowerCase();
 
+      if (categoryA === categoryB) {
+        return 0;
+      }
+
       if (categoryA === RECOMMENDED_FOR_YOU_DISPLAY_TEXT.toLowerCase()) {
         return -1;
       }
@@ -141,6 +148,39 @@ export const AnytimeActionSearch = (props: Props): ReactElement => {
     Config.dashboardAnytimeActionDefaults.recommendedForYouCategoryHeader;
   const RECOMMENDED_FOR_YOU_ID = "recommended-for-you";
 
+  const moveNonEssentialAnyTimeActionsToRecommendeForYou = (
+    nonEssentialAnytimeActions: AnytimeActionTask[],
+  ): AnytimeActionTask[] => {
+    const nonEssentialAnytimeActionsRecommendedForYouCategorysOverriden =
+      nonEssentialAnytimeActions;
+    for (const [index] of nonEssentialAnytimeActions.entries()) {
+      nonEssentialAnytimeActionsRecommendedForYouCategorysOverriden[
+        index
+      ].category[0].categoryName = RECOMMENDED_FOR_YOU_DISPLAY_TEXT;
+      nonEssentialAnytimeActionsRecommendedForYouCategorysOverriden[index].category[0].categoryId =
+        RECOMMENDED_FOR_YOU_ID;
+    }
+    return nonEssentialAnytimeActionsRecommendedForYouCategorysOverriden;
+  };
+
+  const removeNonEssentialAnytimeActionTasksFromGenericAnytimeActionList = (
+    anytimeActionsRoot: AnytimeActionTask[],
+    anytimeActionsToRemoveFromRoot: AnytimeActionTask[],
+  ): AnytimeActionTask[] => {
+    const anytimeActionsToRemoveFromRootUrlSlugs = new Set(
+      anytimeActionsToRemoveFromRoot.map((anytimeAction) => anytimeAction.urlSlug),
+    );
+
+    const anytimeActionsRootRemoved = anytimeActionsRoot.filter((anytimeAction) => {
+      if (anytimeActionsToRemoveFromRootUrlSlugs.has(anytimeAction.urlSlug)) {
+        return false;
+      }
+      return true;
+    });
+
+    return anytimeActionsRootRemoved;
+  };
+
   const moveAnytimeActionsToRecommendedForYouSection = (
     anytimeActions: AnytimeActionTask[],
   ): AnytimeActionTask[] => {
@@ -156,16 +196,6 @@ export const AnytimeActionSearch = (props: Props): ReactElement => {
         anytimeActionsWithRecommendedForYouCategorysOverriden[index].category[0].categoryId =
           RECOMMENDED_FOR_YOU_ID;
       }
-      if (anytimeAction.nonEssentialQuestionsMoveToRecommendedAnytimeActionIds) {
-        for (const nonEssentialQuestionId of anytimeAction.nonEssentialQuestionsMoveToRecommendedAnytimeActionIds) {
-          if (business?.profileData.nonEssentialRadioAnswers[nonEssentialQuestionId]) {
-            anytimeActionsWithRecommendedForYouCategorysOverriden[index].category[0].categoryName =
-              RECOMMENDED_FOR_YOU_DISPLAY_TEXT;
-            anytimeActionsWithRecommendedForYouCategorysOverriden[index].category[0].categoryId =
-              RECOMMENDED_FOR_YOU_ID;
-          }
-        }
-      }
     }
 
     return anytimeActionsWithRecommendedForYouCategorysOverriden;
