Skip to content

Commit 6d9b3bb

Browse files
jphechterjphechter
committed
fix: [AB#17114] fixes missing configuration values
1 parent b14d273 commit 6d9b3bb

File tree

7 files changed

+59
-33
lines changed

7 files changed

+59
-33
lines changed

‎.github/workflows/deploy-content-environment.yml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535

3636
BASIC_AUTH_PASSWORD: ${{ secrets.BASIC_AUTH_PASSWORD }}
3737
BASIC_AUTH_USERNAME: ${{ vars.BASIC_AUTH_USERNAME }}
38-
BUSINESS_NAME_BASE_URL: ${{ secrets.BUSINESS_NAME_BASE_URL_DEV }}
38+
BUSINESS_NAME_BASE_URL: ${{ vars.BUSINESS_NAME_BASE_URL_DEV }}
3939
COGNITO_IDENTITY_POOL_ID: ${{ secrets.COGNITO_IDENTITY_POOL_ID_CONTENT }}
4040
COGNITO_USER_POOL_ID: ${{ secrets.COGNITO_USER_POOL_ID_CONTENT }}
4141
COGNITO_WEB_CLIENT_ID: ${{ secrets.COGNITO_WEB_CLIENT_ID_CONTENT }}
@@ -75,7 +75,7 @@ jobs:
7575
FORMATION_API_BASE_URL: ${{ secrets.FORMATION_API_BASE_URL_DEV }}
7676

7777
GOV2GO_REGISTRATION_API_KEY: ${{ secrets.GOV2GO_REGISTRATION_API_KEY_DEV }}
78-
GOV2GO_REGISTRATION_BASE_URL: ${{ secrets.GOV2GO_REGISTRATION_BASE_URL_DEV }}
78+
GOV2GO_REGISTRATION_BASE_URL: ${{ vars.GOV2GO_REGISTRATION_BASE_URL_DEV }}
7979

8080
LICENSE_STATUS_BASE_URL: ${{ vars.LICENSE_STATUS_BASE_URL_DEV }}
8181
MYNJ_ROLE_NAME: ${{ vars.MYNJ_ROLE_NAME_CONTENT }}
@@ -86,13 +86,14 @@ jobs:
8686
SHOW_DISABLED_INDUSTRIES: ${{ vars.CONTENT_SHOW_DISABLED_INDUSTRIES }}
8787
SMOKE_TEST_ENV: ${{ secrets.SMOKE_TEST_ENV_DEV }}
8888
TAX_CLEARANCE_CERTIFICATE_PASSWORD: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_DEV }}
89-
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ vars.TAX_CLEARANCE_CERTIFICATE_USER_NAME }}
89+
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_USER_NAME_DEV }}
9090
TAX_CLEARANCE_CERTIFICATE_URL: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_URL_DEV }}
9191
USE_BASIC_AUTH: ${{ vars.USE_BASIC_AUTH_DEV }}
9292
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ secrets.XRAY_REGISTRATION_STATUS_BASE_URL_DEV }}
9393
AWS_CRYPTO_TAX_ID_HASHING_KEY: ${{ secrets.AWS_CRYPTO_TAX_ID_HASHING_KEY_CONTENT }}
9494
AWS_CRYPTO_TAX_ID_ENCRYPTION_KEY: ${{ secrets.AWS_CRYPTO_TAX_ID_ENCRYPTION_KEY_CONTENT }}
9595
FEATURE_EMPLOYER_RATES: ${{ vars.FEATURE_EMPLOYER_RATES_DEV }}
96+
INTERCOM_HASH_SECRET: ${{ secrets.INTERCOM_HASH_SECRET }}
9697

9798
steps:
9899
- uses: actions/checkout@v6

‎.github/workflows/deploy-dev-environment.yml‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
FORMATION_API_BASE_URL: ${{ secrets.FORMATION_API_BASE_URL_DEV }}
6363

6464
GOV2GO_REGISTRATION_API_KEY: ${{ secrets.GOV2GO_REGISTRATION_API_KEY_DEV }}
65-
GOV2GO_REGISTRATION_BASE_URL: ${{ secrets.GOV2GO_REGISTRATION_BASE_URL_DEV }}
65+
GOV2GO_REGISTRATION_BASE_URL: ${{ vars.GOV2GO_REGISTRATION_BASE_URL_DEV }}
6666

6767
LICENSE_STATUS_BASE_URL: ${{ vars.LICENSE_STATUS_BASE_URL_DEV }}
6868

@@ -95,11 +95,20 @@ jobs:
9595
AIRTABLE_USERS_TABLE: ${{ vars.AIRTABLE_USERS_TABLE_DEV }}
9696
AB_TESTING_EXPERIENCE_B_PERCENTAGE: ${{ vars.AB_TESTING_EXPERIENCE_B_PERCENTAGE_DEV }}
9797
SMOKE_TEST_ENV: ${{ secrets.SMOKE_TEST_ENV_DEV }}
98-
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ secrets.XRAY_REGISTRATION_STATUS_BASE_URL_DEV }}
98+
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ vars.XRAY_REGISTRATION_STATUS_BASE_URL_DEV }}
99+
100+
AIRTABLE_API_KEY: ${{ secrets.AIRTABLE_API_KEY }}
101+
AIRTABLE_BASE_URL: ${{ vars.AIRTABLE_BASE_URL }}
102+
AIRTABLE_USER_RESEARCH_BASE_ID: ${{ secrets.AIRTABLE_USER_RESEARCH_BASE_ID }}
103+
BUSINESS_NAME_BASE_URL: ${{ vars.BUSINESS_NAME_BASE_URL_DEV }}
104+
GOV_DELIVERY_API_KEY: ${{ secrets.GOV_DELIVERY_API_KEY }}
105+
GOV_DELIVERY_BASE_URL: ${{ vars.GOV_DELIVERY_BASE_URL }}
106+
GOV_DELIVERY_TOPIC: ${{ vars.GOV_DELIVERY_TOPIC }}
107+
INTERCOM_HASH_SECRET: ${{ secrets.INTERCOM_HASH_SECRET }}
99108

100109
TAX_CLEARANCE_CERTIFICATE_PASSWORD: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_DEV }}
101-
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ vars.TAX_CLEARANCE_CERTIFICATE_USER_NAME }}
102-
TAX_CLEARANCE_CERTIFICATE_URL: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_URL_DEV }}
110+
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_USER_NAME_DEV }}
111+
TAX_CLEARANCE_CERTIFICATE_URL: ${{ vars.TAX_CLEARANCE_CERTIFICATE_URL_DEV }}
103112

104113
steps:
105114
- uses: actions/checkout@v6

‎.github/workflows/deploy-staging-environment.yml‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
COGNITO_IDENTITY_POOL_ID: ${{ secrets.COGNITO_IDENTITY_POOL_ID_STAGING }}
2828
COGNITO_USER_POOL_ID: ${{ secrets.COGNITO_USER_POOL_ID_STAGING }}
2929
COGNITO_WEB_CLIENT_ID: ${{ secrets.COGNITO_WEB_CLIENT_ID_STAGING }}
30-
BUSINESS_NAME_BASE_URL: ${{ secrets.BUSINESS_NAME_BASE_URL_STAGING }}
30+
BUSINESS_NAME_BASE_URL: ${{ vars.BUSINESS_NAME_BASE_URL_STAGING }}
3131
MYNJ_ROLE_NAME: ${{ vars.MYNJ_ROLE_NAME_PROD_STAGING }}
3232
FEATURE_CIGARETTE_LICENSE: ${{ vars.FEATURE_CIGARETTE_LICENSE_STAGING }}
3333
FEATURE_TAX_CLEARANCE_CERTIFICATE: ${{ vars.FEATURE_TAX_CLEARANCE_CERTIFICATE_STAGING }}
@@ -36,8 +36,8 @@ jobs:
3636
FORMATION_API_KEY: ${{ secrets.FORMATION_API_KEY_STAGING }}
3737
FORMATION_API_BASE_URL: ${{ secrets.FORMATION_API_BASE_URL_STAGING }}
3838

39-
GOV2GO_REGISTRATION_API_KEY: ${{ secrets.GOV2GO_REGISTRATION_API_KEY_PROD_STAGING }}
40-
GOV2GO_REGISTRATION_BASE_URL: ${{ secrets.GOV2GO_REGISTRATION_BASE_URL_STAGING }}
39+
GOV2GO_REGISTRATION_API_KEY: ${{ secrets.GOV2GO_REGISTRATION_API_KEY_STAGING }}
40+
GOV2GO_REGISTRATION_BASE_URL: ${{ vars.GOV2GO_REGISTRATION_BASE_URL_STAGING }}
4141

4242
LICENSE_STATUS_BASE_URL: ${{ vars.LICENSE_STATUS_BASE_URL_STAGING }}
4343

@@ -47,11 +47,6 @@ jobs:
4747
REDIRECT_URL: ${{ vars.REDIRECT_URL_STAGING }}
4848
USE_BASIC_AUTH: ${{ vars.USE_BASIC_AUTH_STAGING }}
4949

50-
TAX_CLEARANCE_CERTIFICATE_PASSWORD:
51-
${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_PROD_STAGING }}
52-
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ vars.TAX_CLEARANCE_CERTIFICATE_USER_NAME }}
53-
TAX_CLEARANCE_CERTIFICATE_URL: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_URL_PROD_STAGING }}
54-
5550
AB_TESTING_EXPERIENCE_B_PERCENTAGE: ${{ vars.AB_TESTING_EXPERIENCE_B_PERCENTAGE_DEV }}
5651

5752
ABC_ETP_API_ACCOUNT: ${{ secrets.ABC_ETP_API_ACCOUNT_STAGING }}
@@ -99,6 +94,12 @@ jobs:
9994
FEATURE_LOGIN_PAGE: ${{ vars.FEATURE_LOGIN_PAGE_STAGING }}
10095

10196
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ vars.XRAY_REGISTRATION_STATUS_BASE_URL_STAGING }}
97+
INTERCOM_HASH_SECRET: ${{ secrets.INTERCOM_HASH_SECRET }}
98+
99+
TAX_CLEARANCE_CERTIFICATE_PASSWORD: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_STAGING }}
100+
TAX_CLEARANCE_CERTIFICATE_USER_NAME:
101+
${{ secrets.TAX_CLEARANCE_CERTIFICATE_USER_NAME_STAGING }}
102+
TAX_CLEARANCE_CERTIFICATE_URL: ${{ vars.TAX_CLEARANCE_CERTIFICATE_URL_STAGING }}
102103

103104
steps:
104105
- name: Checkout Repository

‎.github/workflows/release-pipeline.yml‎

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
8585
echo "API_BASE_URL=${{ vars.API_BASE_URL_AWS_PROD }}" >> $GITHUB_ENV
8686
echo "AUTH_DOMAIN=${{ secrets.COGNITO_AUTH_DOMAIN_PROD }}" >> $GITHUB_ENV
87-
echo "BUSINESS_NAME_BASE_URL=${{ secrets.BUSINESS_NAME_BASE_URL_PROD }}" >> $GITHUB_ENV
87+
echo "BUSINESS_NAME_BASE_URL=${{ vars.BUSINESS_NAME_BASE_URL_PROD }}" >> $GITHUB_ENV
8888
8989
echo "COGNITO_IDENTITY_POOL_ID=${{ secrets.COGNITO_IDENTITY_POOL_ID_PROD }}" >> $GITHUB_ENV
9090
echo "COGNITO_USER_POOL_ID=${{ secrets.COGNITO_USER_POOL_ID_PROD }}" >> $GITHUB_ENV
@@ -94,10 +94,6 @@ jobs:
9494
echo "FORMATION_API_BASE_URL=${{ secrets.FORMATION_API_BASE_URL_PROD }}" >> $GITHUB_ENV
9595
echo "FORMATION_API_KEY=${{ secrets.FORMATION_API_KEY_PROD }}" >> $GITHUB_ENV
9696
97-
echo "GOV2GO_REGISTRATION_API_KEY=${{ secrets.GOV2GO_REGISTRATION_API_KEY_PROD }}" >> $GITHUB_ENV
98-
echo "GOV2GO_REGISTRATION_BASE_URL=${{ secrets.GOV2GO_REGISTRATION_BASE_URL_PROD }}" >> $GITHUB_ENV
99-
echo "GOV_DELIVERY_BASE_URL=${{ secrets.GOV_DELIVERY_BASE_URL }}" >> $GITHUB_ENV
100-
10197
echo "LICENSE_STATUS_BASE_URL=${{ vars.LICENSE_STATUS_BASE_URL_PROD }}" >> $GITHUB_ENV
10298
10399
echo "MYNJ_ROLE_NAME=${{ vars.MYNJ_ROLE_NAME_PROD_STAGING }}" >> $GITHUB_ENV
@@ -112,16 +108,14 @@ jobs:
112108
echo "FEATURE_TAX_CLEARANCE_CERTIFICATE=${{ vars.FEATURE_TAX_CLEARANCE_CERTIFICATE_PROD }}" >> $GITHUB_ENV
113109
echo "FEATURE_EMPLOYER_RATES=${{ vars.FEATURE_EMPLOYER_RATES_PROD }}" >> $GITHUB_ENV
114110
115-
echo "TAX_CLEARANCE_CERTIFICATE_PASSWORD=${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_PROD_STAGING }}" >> $GITHUB_ENV
116-
echo "TAX_CLEARANCE_CERTIFICATE_USER_NAME=${{ vars.TAX_CLEARANCE_CERTIFICATE_USER_NAME }}" >> $GITHUB_ENV
117-
echo "TAX_CLEARANCE_CERTIFICATE_URL=${{ secrets.TAX_CLEARANCE_CERTIFICATE_URL_PROD_STAGING }}" >> $GITHUB_ENV
111+
echo "TAX_CLEARANCE_CERTIFICATE_PASSWORD=${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_PROD }}" >> $GITHUB_ENV
112+
echo "TAX_CLEARANCE_CERTIFICATE_USER_NAME=${{ secrets.TAX_CLEARANCE_CERTIFICATE_USER_NAME_PROD }}" >> $GITHUB_ENV
113+
echo "TAX_CLEARANCE_CERTIFICATE_URL=${{ vars.TAX_CLEARANCE_CERTIFICATE_URL_PROD }}" >> $GITHUB_ENV
118114
119115
echo "ABC_ETP_API_ACCOUNT=${{ secrets.ABC_ETP_API_ACCOUNT_PROD }}" >> $GITHUB_ENV
120116
echo "ABC_ETP_API_BASE_URL=${{ vars.ABC_ETP_API_BASE_URL_PROD }}" >> $GITHUB_ENV
121117
echo "ABC_ETP_API_KEY=${{ secrets.ABC_ETP_API_KEY_PROD }}" >> $GITHUB_ENV
122118
123-
echo "AIRTABLE_USERS_TABLE=${{ vars.AIRTABLE_USERS_TABLE_PROD }}" >> $GITHUB_ENV
124-
125119
echo "AWS_ACCOUNT_ID=${{ vars.AWS_ACCOUNT_ID_PROD }}" >> $GITHUB_ENV
126120
echo "AWS_ACCESS_KEY_ID=${{ secrets.AWS_ACCESS_KEY_ID_PROD }}" >> $GITHUB_ENV
127121
echo "AWS_SECRET_ACCESS_KEY=${{ secrets.AWS_SECRET_ACCESS_KEY_PROD }}" >> $GITHUB_ENV
@@ -162,6 +156,22 @@ jobs:
162156
echo "GOOGLE_TAG_MANAGER_ID=${{ secrets.GOOGLE_TAG_MANAGER_ID }}" >> $GITHUB_ENV
163157
echo "XRAY_REGISTRATION_STATUS_BASE_URL=${{ vars.XRAY_REGISTRATION_STATUS_BASE_URL_PROD }}" >> $GITHUB_ENV
164158
159+
160+
echo "ADMIN_PASSWORD=${{ secrets.ADMIN_PASSWORD }}" >> $GITHUB_ENV
161+
echo "AIRTABLE_API_KEY=${{ secrets.AIRTABLE_API_KEY }}" >> $GITHUB_ENV
162+
echo "AIRTABLE_BASE_URL=${{ vars.AIRTABLE_BASE_URL }}" >> $GITHUB_ENV
163+
echo "AIRTABLE_USERS_TABLE=${{ vars.AIRTABLE_USERS_TABLE_PROD }}" >> $GITHUB_ENV
164+
echo "AIRTABLE_USER_RESEARCH_BASE_ID=${{ secrets.AIRTABLE_USER_RESEARCH_BASE_ID }}" >> $GITHUB_ENV
165+
166+
echo "GOV2GO_REGISTRATION_API_KEY=${{ secrets.GOV2GO_REGISTRATION_API_KEY_PROD }}" >> $GITHUB_ENV
167+
echo "GOV2GO_REGISTRATION_BASE_URL=${{ vars.GOV2GO_REGISTRATION_BASE_URL_PROD }}" >> $GITHUB_ENV
168+
169+
echo "GOV_DELIVERY_API_KEY=${{ secrets.GOV_DELIVERY_API_KEY }}" >> $GITHUB_ENV
170+
echo "GOV_DELIVERY_BASE_URL=${{ vars.GOV_DELIVERY_BASE_URL }}" >> $GITHUB_ENV
171+
172+
echo "GOV_DELIVERY_TOPIC=${{ vars.GOV_DELIVERY_TOPIC }}" >> $GITHUB_ENV
173+
echo "INTERCOM_HASH_SECRET=${{ secrets.INTERCOM_HASH_SECRET }}" >> $GITHUB_ENV
174+
165175
- name: Deploy to Production
166176
uses: ./.github/actions/deploy
167177
with:

‎.github/workflows/testing-deployment-trigger.yml‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
SHOW_DISABLED_INDUSTRIES: ${{ vars.DEV_SHOW_DISABLED_INDUSTRIES }}
4242
SMOKE_TEST_ENV: ${{ secrets.SMOKE_TEST_ENV_DEV }}
4343
USE_BASIC_AUTH: ${{ vars.USE_BASIC_AUTH_DEV }}
44-
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ secrets.XRAY_REGISTRATION_STATUS_BASE_URL_DEV }}
44+
XRAY_REGISTRATION_STATUS_BASE_URL: ${{ vars.XRAY_REGISTRATION_STATUS_BASE_URL_DEV }}
4545

4646
DYNAMICS_ELEVATOR_SAFETY_CLIENT_ID: ${{ secrets.DYNAMICS_ELEVATOR_SAFETY_CLIENT_ID }}
4747
DYNAMICS_ELEVATOR_SAFETY_SECRET: ${{ secrets.DYNAMICS_ELEVATOR_SAFETY_SECRET }}
@@ -75,13 +75,13 @@ jobs:
7575
FORMATION_API_BASE_URL: ${{ secrets.FORMATION_API_BASE_URL_DEV }}
7676

7777
GOV2GO_REGISTRATION_API_KEY: ${{ secrets.GOV2GO_REGISTRATION_API_KEY_DEV }}
78-
GOV2GO_REGISTRATION_BASE_URL: ${{ secrets.GOV2GO_REGISTRATION_BASE_URL_DEV }}
78+
GOV2GO_REGISTRATION_BASE_URL: ${{ vars.GOV2GO_REGISTRATION_BASE_URL_DEV }}
7979

8080
LICENSE_STATUS_BASE_URL: ${{ vars.LICENSE_STATUS_BASE_URL_DEV }}
8181

8282
TAX_CLEARANCE_CERTIFICATE_PASSWORD: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_PASSWORD_DEV }}
83-
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ vars.TAX_CLEARANCE_CERTIFICATE_USER_NAME }}
84-
TAX_CLEARANCE_CERTIFICATE_URL: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_URL_DEV }}
83+
TAX_CLEARANCE_CERTIFICATE_USER_NAME: ${{ secrets.TAX_CLEARANCE_CERTIFICATE_USER_NAME_DEV }}
84+
TAX_CLEARANCE_CERTIFICATE_URL: ${{ vars.TAX_CLEARANCE_CERTIFICATE_URL_DEV }}
8585

8686
# Testing Overrides
8787
API_BASE_URL: ${{ vars.API_BASE_URL_AWS_TESTING }}
@@ -104,6 +104,9 @@ jobs:
104104
REDIRECT_URL: ${{ vars.REDIRECT_URL_TESTING }}
105105
NEXT_PUBLIC_WEB_BASE_URL: ${{ vars.WEB_BASE_URL_TESTING }}
106106

107+
BUSINESS_NAME_BASE_URL: ${{ vars.BUSINESS_NAME_BASE_URL_DEV }}
108+
INTERCOM_HASH_SECRET: ${{ secrets.INTERCOM_HASH_SECRET }}
109+
107110
steps:
108111
- name: Checkout Repository
109112
uses: actions/checkout@v6

‎api/src/functions/express/app.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ const businessNameClient = ApiBusinessNameClient(BUSINESS_NAME_BASE_URL!, logger
285285
const GOV_DELIVERY_BASE_URL =
286286
process.env.GOV_DELIVERY_BASE_URL || `http://${IS_DOCKER ? "wiremock" : "localhost"}:9000`;
287287
const GOV_DELIVERY_API_KEY = process.env.GOV_DELIVERY_API_KEY || "testkey";
288-
const GOV_DELIVERY_TOPIC = process.env.GOV_DELIVERY_TOPIC || "NJGOV_17";
288+
const GOV_DELIVERY_TOPIC = process.env.GOV_DELIVERY_TOPIC || "";
289289
const GOV_DELIVERY_URL_QUESTION_ID = process.env.GOV_DELIVERY_URL_QUESTION_ID;
290290

291291
const AIRTABLE_API_KEY = process.env.AIRTABLE_API_KEY || "AIRTABLE_API_KEY";
@@ -347,8 +347,9 @@ const govDeliveryNewsletterClient = GovDeliveryNewsletterClient({
347347
topic: GOV_DELIVERY_TOPIC,
348348
apiKey: GOV_DELIVERY_API_KEY,
349349
logWriter: logger,
350+
// TODO: This is no longer our domain. Can we change this? Make it a variable.
350351
siteUrl: "navigator.business.nj.gov",
351-
urlQuestion: GOV_DELIVERY_URL_QUESTION_ID,
352+
urlQuestion: GOV_DELIVERY_URL_QUESTION_ID, // TODO: What is this? Currently undefined.
352353
});
353354

354355
const airtableUserTestingClient = AirtableUserTestingClient(

‎api/src/functions/updateExternalStatus/app.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export const handler = async (): Promise<void> => {
4545
? `http://${IS_DOCKER ? "wiremock" : "localhost"}:9000`
4646
: "https://api.govdelivery.com");
4747
const GOV_DELIVERY_API_KEY = process.env.GOV_DELIVERY_API_KEY || "tempkey";
48-
const GOV_DELIVERY_TOPIC = process.env.GOV_DELIVERY_TOPIC || "NJGOV_1";
48+
const GOV_DELIVERY_TOPIC = process.env.GOV_DELIVERY_TOPIC || "";
4949
const GOV_DELIVERY_URL_QUESTION_ID = process.env.GOV_DELIVERY_URL_QUESTION_ID || "q_86783";
5050

5151
const AIRTABLE_API_KEY = process.env.AIRTABLE_API_KEY || "";
@@ -60,8 +60,9 @@ export const handler = async (): Promise<void> => {
6060
topic: GOV_DELIVERY_TOPIC,
6161
apiKey: GOV_DELIVERY_API_KEY,
6262
logWriter: logger,
63+
// TODO: This is no longer our domain. Can we change this? Make it a variable.
6364
siteUrl: "navigator.business.nj.gov",
64-
urlQuestion: GOV_DELIVERY_URL_QUESTION_ID,
65+
urlQuestion: GOV_DELIVERY_URL_QUESTION_ID, // TODO: What is this? Currently undefined.
6566
});
6667

6768
const airtableUserTestingClient = AirtableUserTestingClient(

0 commit comments

Comments
 (0)