fix: [AB#13064] remove edit button on deferred location question

Author: jennyverdeyen

web/src/components/DeferredLocationQuestion.test.tsx

@@ -83,13 +83,29 @@ describe("<DeferredLocationQuestion />", () => {
     expect(screen.queryByTestId("city-success-banner")).not.toBeInTheDocument();
   });
 
-  it("shows inner content without question nor success banner when already location saved", () => {
+  it("shows inner content with success banner when already location saved", () => {
     const municipality = generateMunicipality({});
     const business = generateBusiness({ profileData: generateProfileData({ municipality }) });
     renderComponent({ initialBusiness: business, innerContent: "inner-content" });
     expect(screen.queryByText(Config.deferredLocation.header)).not.toBeInTheDocument();
     expect(screen.getByText("inner-content")).toBeInTheDocument();
+    expect(screen.getByTestId("city-success-banner")).toBeInTheDocument();
+  });
+
+  it("shows question form when Remove City is clicked from saved location", async () => {
+    const municipality = generateMunicipality({ displayName: "Allendale" });
+    const business = generateBusiness({ profileData: generateProfileData({ municipality }) });
+    renderComponent({ initialBusiness: business, innerContent: "inner-content" });
+
+    expect(screen.getByTestId("city-success-banner")).toBeInTheDocument();
+    expect(screen.getByText("inner-content")).toBeInTheDocument();
+    expect(screen.queryByText(Config.deferredLocation.header)).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByText(Config.deferredLocation.removeText));
+
+    expect(screen.getByText(Config.deferredLocation.header)).toBeInTheDocument();
     expect(screen.queryByTestId("city-success-banner")).not.toBeInTheDocument();
+    expect(screen.queryByText("inner-content")).not.toBeInTheDocument();
   });
 
   describe("when saving location", () => {
@@ -122,22 +138,6 @@ describe("<DeferredLocationQuestion />", () => {
       expect(screen.getByText("inner-content")).toBeInTheDocument();
     });
 
-    it("shows location question when edit button is clicked", async () => {
-      await selectNewarkAndSave();
-      fireEvent.click(screen.getByText(Config.deferredLocation.editText));
-      expect(screen.getByText(Config.deferredLocation.header)).toBeInTheDocument();
-      expect(screen.queryByTestId("city-success-banner")).not.toBeInTheDocument();
-    });
-
-    it("shows inner content when saving location after editing", async () => {
-      await selectNewarkAndSave();
-      fireEvent.click(screen.getByText(Config.deferredLocation.editText));
-      selectLocationByText("Absecon");
-      fireEvent.click(screen.getByText(Config.deferredLocation.deferredOnboardingSaveButtonText));
-      await screen.findByTestId("city-success-banner");
-      expect(screen.getByText("inner-content")).toBeInTheDocument();
-    });
-
     it("removes municipality from user profile when clicking remove button", async () => {
       await selectNewarkAndSave();
       fireEvent.click(screen.getByText(Config.deferredLocation.removeText));

web/src/components/DeferredLocationQuestion.tsx

@@ -8,7 +8,7 @@ import { useUserData } from "@/lib/data-hooks/useUserData";
 import analytics from "@/lib/utils/analytics";
 import { templateEval } from "@/lib/utils/helpers";
 import { Business } from "@businessnjgovnavigator/shared/userData";
-import { ReactElement, ReactNode, useState } from "react";
+import { ReactElement, ReactNode } from "react";
 
 interface Props {
   innerContent: string;
@@ -22,10 +22,8 @@ export const DeferredLocationQuestion = (props: Props): ReactElement => {
   const business = props.CMS_ONLY_fakeBusiness ?? userDataFromHook.business;
   const updateQueue = userDataFromHook.updateQueue;
 
-  const [showSuccessBanner, setShowSuccessBanner] = useState<boolean>(
-    props.CMS_ONLY_showSuccessBanner ?? false,
-  );
-  const [showEditLocation, setShowEditLocation] = useState<boolean>(false);
+  const showSuccessBanner =
+    props.CMS_ONLY_showSuccessBanner ?? business?.profileData.municipality !== undefined;
 
   const label = (
     <>
@@ -34,11 +32,9 @@ export const DeferredLocationQuestion = (props: Props): ReactElement => {
     </>
   );
 
-  const shouldShowQuestion = business?.profileData.municipality === undefined || showEditLocation;
+  const shouldShowQuestion = business?.profileData.municipality === undefined;
 
   const onSaveNewLocation = (): void => {
-    setShowSuccessBanner(true);
-    setShowEditLocation(false);
     business?.profileData.municipality === undefined &&
       updateQueue?.currentBusiness().profileData.municipality !== undefined &&
       analytics.event.task_location_question.submit.location_entered_for_first_time();
@@ -65,10 +61,6 @@ export const DeferredLocationQuestion = (props: Props): ReactElement => {
               })}
             </Content>
           </div>
-          <UnStyledButton isUnderline onClick={(): void => setShowEditLocation(true)}>
-            {Config.deferredLocation.editText}
-          </UnStyledButton>
-          <span className="margin-x-105">|</span>
           <UnStyledButton isUnderline onClick={onRemoveLocation}>
             {Config.deferredLocation.removeText}
           </UnStyledButton>