chore: [AB#17345] remove user feedback Airtable integration

The `user.userTesting` boolean continues to be stored in the production
database via the standard `UpdateQueue` flow, but it is no longer synced
to Airtable.

Author: hinzed1127

api/src/api/externalEndpointRouter.test.ts

@@ -1,5 +1,5 @@
 import { externalEndpointRouterFactory } from "@api/externalEndpointRouter";
-import { AddNewsletter, AddToUserTesting, DatabaseClient } from "@domain/types";
+import { AddNewsletter, DatabaseClient } from "@domain/types";
 import { setupExpress } from "@libs/express";
 import { DummyLogWriter } from "@libs/logWriter";
 import { generateUser, generateUserData } from "@shared/test";
@@ -37,7 +37,6 @@ describe("externalEndpointRouter", () => {
   let app: Express;
   let stubDynamoDataClient: jest.Mocked<DatabaseClient>;
   let stubAddNewsletter: jest.MockedFunction<AddNewsletter>;
-  let stubAddToUserTesting: jest.MockedFunction<AddToUserTesting>;
 
   beforeEach(async () => {
     stubDynamoDataClient = {
@@ -50,16 +49,8 @@ describe("externalEndpointRouter", () => {
       findBusinessesByHashedTaxId: jest.fn(),
     };
     stubAddNewsletter = jest.fn();
-    stubAddToUserTesting = jest.fn();
     app = setupExpress(false);
-    app.use(
-      externalEndpointRouterFactory(
-        stubDynamoDataClient,
-        stubAddNewsletter,
-        stubAddToUserTesting,
-        DummyLogWriter,
-      ),
-    );
+    app.use(externalEndpointRouterFactory(stubDynamoDataClient, stubAddNewsletter, DummyLogWriter));
     jest.spyOn(DummyLogWriter, "LogInfo").mockImplementation(() => {});
     jest.spyOn(DummyLogWriter, "LogError").mockImplementation(() => {});
   });
@@ -136,71 +127,5 @@ describe("externalEndpointRouter", () => {
         );
       });
     });
-
-    describe("userTesting", () => {
-      it("adds to userTesting if userTesting is set to true and externalStatus is empty", async () => {
-        const userData = generateUserData({
-          user: generateUser({
-            externalStatus: { newsletter: { status: "IN_PROGRESS" } },
-            userTesting: true,
-          }),
-        });
-        await request(app).post(`/userTesting`).send(userData);
-        expect(stubAddToUserTesting).toHaveBeenCalled();
-      });
-
-      it("does not add to userTesting if the request has been attempted", async () => {
-        const userData = generateUserData({
-          user: generateUser({
-            externalStatus: { userTesting: { status: "IN_PROGRESS" } },
-            userTesting: true,
-          }),
-        });
-        await request(app).post(`/userTesting`).send(userData);
-        expect(stubAddToUserTesting).not.toHaveBeenCalled();
-        expect(DummyLogWriter.LogInfo).toHaveBeenCalledWith(
-          expect.stringContaining("successfully updated user testing preferences for userId:"),
-        );
-      });
-
-      it("adds to newsletter and does not update the db if the user is unauthenticated", async () => {
-        const userData = generateUserData({
-          user: generateUser({ id: "123", externalStatus: {}, userTesting: true }),
-        });
-        await request(app).post(`/userTesting`).send(userData);
-        expect(stubAddToUserTesting).toHaveBeenCalled();
-        expect(stubDynamoDataClient.put).not.toHaveBeenCalled();
-      });
-
-      it("logs no update needed and does not call addToUserTesting when no update is needed", async () => {
-        const userData = generateUserData({
-          user: generateUser({
-            externalStatus: { userTesting: { status: "IN_PROGRESS" } },
-            userTesting: true,
-          }),
-        });
-
-        await request(app).post(`/userTesting`).send(userData);
-
-        expect(stubAddToUserTesting).not.toHaveBeenCalled();
-        expect(DummyLogWriter.LogInfo).toHaveBeenCalledWith(
-          expect.stringContaining("no update to user testing preferences needed for userId"),
-        );
-      });
-
-      it("adds to newsletter and updates the db if the user is authenticated", async () => {
-        const userData = generateUserData({
-          user: generateUser({ id: "123", externalStatus: {}, userTesting: true }),
-        });
-        mockJwt.decode.mockReturnValue(cognitoPayload({ id: "123" }));
-        stubDynamoDataClient.put.mockResolvedValue(userData);
-        await request(app)
-          .post(`/userTesting`)
-          .send(userData)
-          .set("Authorization", "Bearer user-123-token");
-        expect(stubAddToUserTesting).toHaveBeenCalled();
-        expect(stubDynamoDataClient.put).toHaveBeenCalled();
-      });
-    });
   });
 });

api/src/api/externalEndpointRouter.ts

@@ -1,7 +1,6 @@
 import { getSignedInUserId } from "@api/userRouter";
 import { shouldAddToNewsletter } from "@domain/newsletter/shouldAddToNewsletter";
-import { AddNewsletter, AddToUserTesting, DatabaseClient } from "@domain/types";
-import { shouldAddToUserTesting } from "@domain/user-testing/shouldAddToUserTesting";
+import { AddNewsletter, DatabaseClient } from "@domain/types";
 import { getDurationMs } from "@libs/logUtils";
 import type { LogWriterType } from "@libs/logWriter";
 import { UserData } from "@shared/userData";
@@ -11,7 +10,6 @@ import { StatusCodes } from "http-status-codes";
 export const externalEndpointRouterFactory = (
   databaseClient: DatabaseClient,
   addNewsletter: AddNewsletter,
-  addToUserTesting: AddToUserTesting,
   logger: LogWriterType,
 ): Router => {
   const router = Router();
@@ -69,57 +67,5 @@ export const externalEndpointRouterFactory = (
     res.status(StatusCodes.OK).json(userData);
   });
 
-  router.post("/userTesting", async (req, res) => {
-    const method = req.method;
-    const endpoint = req.originalUrl;
-    const requestStart = Date.now();
-
-    let userData = req.body as UserData;
-    const userId = userData.user.id;
-    let isAnonymous;
-    try {
-      isAnonymous = getSignedInUserId(req) !== userId;
-    } catch {
-      isAnonymous = true;
-    }
-
-    if (shouldAddToUserTesting(userData)) {
-      userData = await addToUserTesting(userData);
-      if (!isAnonymous) {
-        try {
-          userData = await databaseClient.put(userData);
-        } catch (error) {
-          const status = StatusCodes.INTERNAL_SERVER_ERROR;
-          const message = error instanceof Error ? error.message : "Unexpected error";
-          logger.LogError(
-            `${method} ${endpoint} - Failed to update user: ${message}, status: ${status}, userId: ${userId}, duration: ${getDurationMs(
-              requestStart,
-            )}ms`,
-          );
-          res.status(status).json({ error: message });
-          return;
-        }
-      }
-
-      logger.LogInfo(
-        `[END] ${method} ${endpoint} - status: ${
-          StatusCodes.OK
-        }, successfully updated user testing preferences for userId: ${userId}, duration: ${getDurationMs(
-          requestStart,
-        )}ms`,
-      );
-    } else {
-      logger.LogInfo(
-        `[END] ${method} ${endpoint} - status: ${
-          StatusCodes.OK
-        }, no update to user testing preferences needed for userId: ${userId}, duration: ${getDurationMs(
-          requestStart,
-        )}ms`,
-      );
-    }
-
-    res.status(StatusCodes.OK).json(userData);
-  });
-
   return router;
 };

api/src/client/AirtableUserTestingClient.test.ts

@@ -131,11 +131,6 @@ export const DynamoUserDataClient = (
     return search(statement);
   };
 
-  const getNeedToAddToUserTestingUsers = (): Promise<UserData[]> => {
-    const statement = `SELECT data FROM "${tableName}" WHERE data["user"].userTesting = true and (data["user"].externalStatus.userTesting is missing or data["user"].externalStatus.userTesting.success = false)`;
-    return search(statement);
-  };
-
   const getNeedTaxIdEncryptionUsers = (): Promise<UserData[]> => {
     const statement = `SELECT data FROM "${tableName}" WHERE data["profileData"].encryptedTaxId IS MISSING AND data["profileData"].taxId IS NOT MISSING`;
     return search(statement);
@@ -181,7 +176,6 @@ export const DynamoUserDataClient = (
     put,
     findByEmail,
     getNeedNewsletterUsers,
-    getNeedToAddToUserTestingUsers,
     getNeedTaxIdEncryptionUsers,
     getUsersWithOutdatedVersion,
   };

api/src/client/AirtableUserTestingClient.ts

@@ -17,7 +17,6 @@ describe("addNewsletterBatch", () => {
       put: jest.fn(),
       findByEmail: jest.fn(),
       getNeedNewsletterUsers: jest.fn(),
-      getNeedToAddToUserTestingUsers: jest.fn(),
       getNeedTaxIdEncryptionUsers: jest.fn(),
       getUsersWithOutdatedVersion: jest.fn(),
     };

api/src/db/DynamoUserDataClient.ts

@@ -12,7 +12,7 @@ import {
 } from "@businessnjgovnavigator/shared";
 import { REMINDER_EMAIL_CONFIG_SET_BASE, WELCOME_EMAIL_CONFIG_SET_BASE } from "@libs/constants";
 import { NameAvailability, NameAvailabilityResponse } from "@shared/businessNameSearch";
-import { BusinessUser, NewsletterResponse, UserTestingResponse } from "@shared/businessUser";
+import { BusinessUser, NewsletterResponse } from "@shared/businessUser";
 import { TaxFilingCalendarEvent } from "@shared/calendarEvent";
 import {
   EmailConfirmationResponse,
@@ -41,7 +41,6 @@ import {
   LicenseEntity,
   LicenseSearchNameAndAddress,
 } from "@shared/license";
-import { ProfileData } from "@shared/profileData";
 import { TaxFilingLookupState, TaxFilingOnboardingState } from "@shared/taxFiling";
 import { Business, UserData } from "@shared/userData";
 import { AxiosResponse } from "axios";
@@ -90,7 +89,6 @@ export interface UserDataClient {
   findByEmail: (email: string) => Promise<UserData | undefined>;
   put: (userData: UserData) => Promise<UserData>;
   getNeedNewsletterUsers: () => Promise<UserData[]>;
-  getNeedToAddToUserTestingUsers: () => Promise<UserData[]>;
   getNeedTaxIdEncryptionUsers: () => Promise<UserData[]>;
   getUsersWithOutdatedVersion: (
     latestVersion: number,
@@ -172,7 +170,6 @@ export interface TimeStampBusinessSearch {
 export type EncryptTaxId = (userData: UserData) => Promise<UserData>;
 
 export type AddNewsletter = (userData: UserData) => Promise<UserData>;
-export type AddToUserTesting = (userData: UserData) => Promise<UserData>;
 
 export interface LicenseStatusClient {
   search: (name: string, zipCode: string) => Promise<LicenseEntity[]>;
@@ -183,10 +180,6 @@ export interface EmployerRatesClient {
   getEmployerRates: (employerRatesRequest: EmployerRatesRequest) => Promise<EmployerRatesResponse>;
 }
 
-export interface UserTestingClient {
-  add: (user: BusinessUser, profileData: ProfileData) => Promise<UserTestingResponse>;
-}
-
 export interface SelfRegClient {
   grant: (user: BusinessUser) => Promise<SelfRegResponse>;
   resume: (authID: string) => Promise<SelfRegResponse>;