Commit 0ffcbf1
Sync upstream updates (#32)
* fix: allow windows style storage paths (newrelic#158)
This commit fixes two critical security issues identified by the security team:
1. TOCTOU Race Condition: Added symlink re-validation immediately before
write operations in fileStorage.Save() to prevent attackers from
creating symlinks between validation and file write.
2. Permission Error Bypass: Removed silent bypassing of permission errors
during symlink validation. Now returns an error if path security cannot
be verified, preventing potential attacks through unreadable directories.
Changes:
- Enhanced fileStorage struct with allowedBaseDir and skipValidation fields
- Added newFileStorageForTesting() for test isolation
- Implemented symlink re-validation before write operations
- Removed permission error bypass in checkPathForSymlinks()
- Added comprehensive tests: TestTOCTOUProtection and TestPermissionErrorHandling
All existing tests pass. No breaking changes to public API or behavior.
---------
Co-authored-by: gmanandhar-nr <gmanandhar@newrelic.com>
Co-authored-by: Palash Kulkarni <pkulkarni@newrelic.com>
* feat: remove processor from atp type name (newrelic#153)
* feat: remove processor from atp type name
* docs: add PR to existing atp changelog
* docs: update changelog entry
* docs: update chloggen entry for atp (newrelic#151)
* [chore] Prepare release 0.142.2 (newrelic#162)
* [chore] Prepare release 0.143.0 (newrelic#168)
* ci: pin OTel collector to highest release tag at candidate minor version
When preparing a release with SYNC_UPSTREAM=true, checkout the highest
published tag of opentelemetry-collector matching the candidate minor
version before running multimod sync. This ensures the collector beta
modules (e.g. v0.143.0) are paired with the highest stable patch release
of the collector at that minor, rather than an arbitrary main HEAD that
may contain unreleased development work.
Falls back to HEAD with a warning if no matching tag exists.
* [chore] multimod update stable modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] multimod update beta modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] update contrib modules to v0.143.0
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] mod and toolchain tidy
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update core modules list
* changelog update 0.143.0
* update version.yaml 0.143.0
* builder config changes 0.143.0
* Prepare beta for version v0.143.0
* fix: patch GO-2026-4394 by pinning otel/sdk to v1.40.0
* chore: run gotidy to sync transitive otel/sdk version bump
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mailo Arsac <marsac@newrelic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] Prepare release 0.144.0 (newrelic#170)
* [chore] multimod update stable modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] multimod update beta modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] update contrib modules to v0.144.0
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] mod and toolchain tidy
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update core modules list
* changelog update 0.144.0
* update version.yaml 0.144.0
* builder config changes 0.144.0
* Prepare beta for version v0.144.0
* fix: update confighttp.ServerConfig.Endpoint to NetAddr for v0.144.0
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mailo Arsac <marsac@newrelic.com>
* [chore] Prepare release 0.145.0 (newrelic#171)
* [chore] multimod update stable modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] multimod update beta modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] update contrib modules to v0.145.0
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] mod and toolchain tidy
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update core modules list
* changelog update 0.145.0
* update version.yaml 0.145.0
* builder config changes 0.145.0
* Prepare beta for version v0.145.0
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] Prepare release 0.146.0 (newrelic#172)
* [chore] multimod update stable modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] multimod update beta modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] update contrib modules to v0.146.0
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] mod and toolchain tidy
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update core modules list
* changelog update 0.146.0
* update version.yaml 0.146.0
* builder config changes 0.146.0
* Prepare beta for version v0.146.0
* remove otel sdk replace directives for GO-2026-4394
* fix: update correctness test PICT files for otlp_grpc rename in v0.146.0
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mailo Arsac <marsac@newrelic.com>
* [chore] Prepare release 0.147.0 (newrelic#173)
* [chore] multimod update stable modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] multimod update beta modules
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] update contrib modules to v0.147.0
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] mod and toolchain tidy
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update core modules list
* changelog update 0.147.0
* update version.yaml 0.147.0
* builder config changes 0.147.0
* Prepare beta for version v0.147.0
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [chore] automatically generate third party notice overrides (newrelic#159)
* ci: autobump golang when updating otel (newrelic#176)
* [chore] autobump golang (newrelic#178)
* chore: autobump golang when updating otel
* trigger checks
* use sed syntax that is portable to both mac and linux (which github actions uses)
* move logic out into script and add a os check
* Apply suggestions from code review
Co-authored-by: kb-newrelic <121687305+kb-newrelic@users.noreply.github.com>
* move sed_inplace function out of find statement for clarity
---------
Co-authored-by: kb-newrelic <121687305+kb-newrelic@users.noreply.github.com>
* chore(ci): fix license paths on windows (newrelic#182)
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kb-newrelic <121687305+kb-newrelic@users.noreply.github.com>
Co-authored-by: gmanandhar-nr <gmanandhar@newrelic.com>
Co-authored-by: Palash Kulkarni <pkulkarni@newrelic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mailo Arsac <marsac@newrelic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: agarvin-nr <agarvin@newrelic.com>
Co-authored-by: Emilia Ferreyra <110185663+emiliaFer@users.noreply.github.com>1 parent b77d6a6 commit 0ffcbf1
56 files changed
Lines changed: 2528 additions & 1605 deletions
File tree
- .chloggen
- .github
- workflows
- scripts
- cmd
- nrdotcol
- nrlicense
- oteltestbedcol
- exporter/nopexporter
- internal
- assets/license
- buildscripts
- common
- coreinternal
- tools
- processor/adaptivetelemetryprocessor
- internal/metadata
- receiver/nopreceiver
- testbed
- correctnesstests
- metrics/testdata
- traces/testdata
- testbed
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | 1 | | |
6 | 2 | | |
7 | 3 | | |
8 | 4 | | |
9 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
12 | 18 | | |
13 | 19 | | |
14 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | 74 | | |
76 | 75 | | |
77 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | | - | |
73 | | - | |
| 72 | + | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
69 | 68 | | |
70 | 69 | | |
71 | 70 | | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
30 | 48 | | |
31 | 49 | | |
32 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | | - | |
| 69 | + | |
68 | 70 | | |
69 | 71 | | |
70 | 72 | | |
| |||
0 commit comments