chore: More CDD updates (#5)

* chore: More CDD updates

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: Fix mistakes

* chore: Update automated test to include all inputs

* chore: Fix Claude issues

* chore: Moving files

* chore: Fixing path

* chore: Updating so test files can be found

* chore: Removing docs test for now

* chore: Remove extra input params - get from files instead

* fix: Allow .fleetControl to be missing in docs case

* fix: Fixes for the 2 use cases

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: mvicknr

.github/workflows/test_action.yml

@@ -9,15 +9,49 @@ on:
       - '**'
 
 jobs:
-  action-test:
+  test-agent-flow:
+    name: Test Agent Repository Flow
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v3
 
-      - name: Run Agent Metadata Action
+      - name: Setup test files
+        run: ln -s integration-test/agent-flow/.fleetControl .fleetControl
+
+      - name: Run Agent Metadata Action (with configs)
         uses: ./
         with:
           agent-type: 'myagent'
           version: '1.0.0'
           cache: false
+
+  test-docs-flow:
+    name: Test Documentation Flow (MDX Parsing)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0  # Fetch all history for git diff
+
+      - name: Create mock PR event
+        run: |
+          BASE_SHA=$(git rev-parse origin/main 2>/dev/null || git rev-parse main)
+          cat > /tmp/pr-event.json <<EOF
+          {
+            "pull_request": {
+              "base": {"sha": "${BASE_SHA}"},
+              "head": {"sha": "${{ github.sha }}"}
+            }
+          }
+          EOF
+
+      - name: Run Agent Metadata Action (metadata from MDX)
+        uses: ./
+        with:
+          agent-type: 'myagent'
+          version: '1.3.0'
+          cache: false
+        env:
+          GITHUB_EVENT_PATH: '/tmp/pr-event.json'

CLAUDE.md

@@ -70,7 +70,7 @@ export GITHUB_WORKSPACE=/path/to/repo
 
 **cmd/agent-metadata-action/main.go**: Application entry point
 - Loads workspace path via `config.LoadEnv()` (returns empty string if not set)
-- Loads metadata via `config.LoadMetadata()` (version, features, bugs, security)
+- Loads metadata via `config.LoadMetadata()` (version, features, bugs, security, deprecations, supportedOperatingSystems, eol)
 - If workspace is set (agent repo flow):
   - Reads configuration definitions via `config.ReadConfigurationDefinitions()`
   - Reads agent control via `config.LoadAndEncodeAgentControl()`
@@ -96,13 +96,16 @@ export GITHUB_WORKSPACE=/path/to/repo
 3. **metadata.go**: Version and changelog metadata
    - `LoadMetadata()`: Loads version and changelog info from environment variables
    - `LoadVersion()`: Reads `INPUT_VERSION` with validation (format: X.Y.Z)
-   - `parseCommaSeparated()`: Parses comma-separated lists (features, bugs, security)
+   - `parseCommaSeparated()`: Parses comma-separated lists (features, bugs, security, deprecations, supportedOperatingSystems)
+   - Reads `INPUT_EOL` for end-of-life date
 
 **internal/models**: Data structures with validation
-- `ConfigurationDefinition`: Configuration with 8 required fields (validated via custom `UnmarshalYAML`)
-  - Fields: slug, name, version, platform, description, type, format, schema
+- `ConfigurationDefinition`: Configuration with 6 required fields (validated via custom `UnmarshalYAML`)
+  - Fields: version, platform, description, type, format, schema
   - Custom unmarshaler validates all fields are present before accepting
 - `Metadata`: Version and changelog info (version required, validated via custom `UnmarshalYAML`)
+  - Required: version
+  - Optional: features, bugs, security, deprecations, supportedOperatingSystems, eol
 - `AgentControl`: Agent control content (platform and content required, validated via custom `UnmarshalJSON`)
 - `ConfigFile`: Root YAML structure containing `configurationDefinitions` array
 - `AgentMetadata`: Complete metadata structure (configurationDefinitions + metadata + agentControl)
@@ -160,11 +163,11 @@ The action expects to run after `actions/checkout` which sets the `GITHUB_WORKSP
 - Multiple layers of validation prevent escaping the designated directory
 
 ### Validation
-- **All configuration fields are required**: name, slug, version, platform, description, type, format, schema
+- **All configuration fields are required**: version, platform, description, type, format, schema
 - **Version format validation**: Must match `X.Y.Z` (three numeric components)
 - **Empty array rejection**: `configurationDefinitions` cannot be an empty array
 - **Validation timing**: All validation happens during YAML/JSON unmarshaling via custom unmarshalers
-- **Error messages**: Clear, contextual errors (e.g., "platform is required for config 'MyConfig'")
+- **Error messages**: Clear, contextual errors (e.g., "platform is required for config with type 'mytype' and version '1.0.0'")
 
 ### Schema Handling
 - Schema files are automatically loaded and **base64-encoded**

README.md

@@ -18,7 +18,9 @@ Add this action to your workflow after checking out your repository:
 
 ## Usage
 
-This action reads the `.fleetControl/configurationDefinitions.yml` file from your repository and outputs the configuration definitions. The action expects the file to be present after the repository has been checked out.
+This action reads the `.fleetControl/configurationDefinitions.yml` file from your repository and saves the agent information in New Relic. 
+The action expects the file to be present after the repository has been checked out. If you do not want to use this action,
+you can call New Relic directly to add the agent information.
 
 ### Example Workflow For Releasing a New Agent Version
 
@@ -40,7 +42,8 @@ jobs:
       - name: Read agent metadata
         uses: newrelic/agent-metadata-action@v1
         with:
-          version: 1.0.0 # only required if different from ref tag
+          agent-type: dotnet # Required: The type of agent (e.g., dotnet, java, python)
+          version: 1.0.0 # Required
           cache: true  # Optional: Enable Go build cache (default: true)
 ```
 
@@ -62,7 +65,14 @@ jobs:
       - name: Read agent metadata
         uses: newrelic/agent-metadata-action@v1
         with:
-          version: 1.0.0 # required in the docs case
+          agent-type: java # Required: The type of agent (e.g., dotnet, java, python)
+          version: 1.0.0 # required
+          features: feature1,feature2 # Optional: Comma-separated list of features
+          bugs: bug-123,bug-456 # Optional: Comma-separated list of bug fixes
+          security: CVE-2024-1234 # Optional: Comma-separated list of security fixes
+          deprecations: deprecated-feature1 # Optional: Comma-separated list of deprecations
+          supportedOperatingSystems: linux,windows,darwin # Optional: Comma-separated list of supported OSes
+          eol: 2025-12-31 # Optional: End of life date
           cache: true  # Optional: Enable Go build cache (default: true)
 ```
 
@@ -72,17 +82,15 @@ The action expects a YAML file at `.fleetControl/configurationDefinitions.yml` w
 
 ```yaml
 configurationDefinitions:
-  - name: "Configuration Name"
-    slug: "config-slug"
-    platform: "kubernetes"  # or "host"
+  - platform: "kubernetes"  # or "host"
     description: "Description of the configuration"
     type: "config-type"
     version: "1.0.0"
     format: "json"
     schema: "./schemas/config-schema.json"
 ```
 
-**All fields are required.** The action validates each configuration entry and will fail with a clear error message if any required field is missing.
+**All fields are required.** The action validates each configuration entry and will fail with a clear error message if any required field is missing (version, platform, description, type, format, schema).
 
 **Schema files** are automatically base64-encoded and embedded in the output. Schema paths must be relative to the `.fleetControl` directory and cannot use directory traversal (`..`) for security.
 

action.yml

@@ -9,18 +9,6 @@ inputs:
     description: 'Agent version in strict semver format MAJOR.MINOR.PATCH (ex. 1.2.3)'
     required: true
     default: ''
-  features:
-    description: 'Comma-separated list of features to include in the agent (ex. feature1,feature2)'
-    required: false
-    default: ''
-  bugs:
-    description: 'Comma-separated list of bugs to exclude from the agent (ex. bug1,bug2)'
-    required: false
-    default: ''
-  security:
-    description: 'Comma-separated list of security fixes (ex. fix1,fix2)'
-    required: false
-    default: ''
   cache:
     description: 'Enable Go build cache'
     required: false
@@ -40,9 +28,6 @@ runs:
       env:
         INPUT_AGENT_TYPE: ${{ inputs.agent-type }}
         INPUT_VERSION: ${{ inputs.version }}
-        INPUT_FEATURES: ${{ inputs.features }}
-        INPUT_BUGS: ${{ inputs.bugs }}
-        INPUT_SECURITY: ${{ inputs.security }}
       run: |
         set -e
         cd ${{ github.action_path }}

cmd/agent-metadata-action/main.go

@@ -10,38 +10,53 @@ import (
 )
 
 func main() {
-	// Validate agent type here for now - may move once there is code to call InstrumentationMetadata service
-	if err := validateAgentType(); err != nil {
+	if err := run(); err != nil {
 		fmt.Fprintf(os.Stderr, "::error::%v\n", err)
 		os.Exit(1)
 	}
+}
+
+func run() error {
+	// Validate agent type here for now - may move once there is code to call InstrumentationMetadata service
+	if err := validateAgentType(); err != nil {
+		return err
+	}
 
-	workspace := config.LoadEnv()
+	workspace := config.GetWorkspace()
+
+	// Workspace is required
+	if workspace == "" {
+		return fmt.Errorf("Error: GITHUB_WORKSPACE is required but not set")
+	}
+
+	// Validate workspace directory exists
+	if _, err := os.Stat(workspace); err != nil {
+		return fmt.Errorf("Error reading configs: workspace directory does not exist: %s", workspace)
+	}
 
 	metadata, err := config.LoadMetadata()
 	if err != nil {
-		fmt.Fprintf(os.Stderr, "::error::Error loading metadata: %v\n", err)
-		os.Exit(1)
+		return fmt.Errorf("Error loading metadata: %w", err)
 	}
 	fmt.Printf("::debug::Agent version: %s\n", metadata.Version)
 	fmt.Printf("::debug::Features: %v\n", metadata.Features)
 	fmt.Printf("::debug::Bugs: %v\n", metadata.Bugs)
 	fmt.Printf("::debug::Security: %v\n", metadata.Security)
 
-	// If GITHUB_WORKSPACE is set, read configuration definitions (agent repo flow)
-	if workspace != "" {
+	// Check if .fleetControl directory exists to determine flow (agent repo vs docs)
+	fleetControlPath := workspace + "/.fleetControl"
+	if _, err := os.Stat(fleetControlPath); err == nil {
+		// Scenario 1: Agent repo flow - .fleetControl directory exists
 		fmt.Printf("::debug::Reading config from workspace: %s\n", workspace)
 
 		configs, err := config.ReadConfigurationDefinitions(workspace)
 		if err != nil {
-			fmt.Fprintf(os.Stderr, "::error::Error reading configs: %v\n", err)
-			os.Exit(1)
+			return fmt.Errorf("Error reading configs: %w", err)
 		}
 
 		agentControl, err := config.LoadAndEncodeAgentControl(workspace)
 		if err != nil {
-			fmt.Fprintf(os.Stderr, "::error::Error reading agent control: %v\n", err)
-			os.Exit(1)
+			return fmt.Errorf("Error reading agent control: %w", err)
 		}
 
 		fmt.Println("::notice::Successfully read configs file")
@@ -56,11 +71,13 @@ func main() {
 		// @todo use the AgentMetadata object to call the InstrumentationMetadata service to add/update the agent in NGEP
 		printJSON("Agent Metadata", agentMetadata)
 	} else {
-		// Docs workflow: only output metadata
-		fmt.Println("::notice::Running in metadata-only mode (no workspace provided)")
+		// Scenario 2: Docs workflow
+		fmt.Println("::notice::Running in metadata-only mode (.fleetControl not found, using MDX files)")
 		// @todo use the INPUT_AGENT_TYPE along with the metadata to call the InstrumentationMetadata service for updating the agent in NGEP with extra metadata
 		printJSON("Metadata", metadata)
 	}
+
+	return nil
 }
 
 func validateAgentType() error {