chore: Fix version (#8)

* chore: Fix version

* chore: Use a temporary local tag for testing

Co-Authored-By: Claude <[email protected]>

* chore: Push test tag and cleanup after

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: mvicknr

.github/workflows/test_action.yml

@@ -1,20 +1,39 @@
 name: Action Test
 
 permissions:
-  contents: read
+  contents: write
 
 on:
   push:
     branches:
       - '**'
 
 jobs:
-  test-agent-flow:
+  setup-test-tag:
+    name: Setup Test Tag
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout action repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Push temporary tag for testing
+        run: |
+          git config user.name "github-actions"
+          git config user.email "[email protected]"
+          git tag -f v0.0.0 HEAD
+          git push -f origin v0.0.0
+
+  test-agent-flow-no-v-version:
+    needs: setup-test-tag
     name: Test Agent Repository Flow
     runs-on: ubuntu-latest
     steps:
       - name: Checkout action repository
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - name: Run Agent Metadata Action (with configs)
         uses: ./
@@ -23,6 +42,23 @@ jobs:
           version: '0.0.0'
           cache: false
 
+  test-agent-flow-v-version:
+    needs: setup-test-tag
+    name: Test Agent Repository Flow with "v" prefixed version
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout action repository
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Run Agent Metadata Action (with configs)
+        uses: ./
+        with:
+          agent-type: 'myagent'
+          version: 'v0.0.0'
+          cache: false
+
   test-docs-flow:
     name: Test Documentation Flow (MDX Parsing)
     runs-on: ubuntu-latest
@@ -83,3 +119,18 @@ jobs:
         run: |
           cd ${{ env.TEMP_WORKSPACE }}
           ${{ github.workspace }}/agent-metadata-action
+
+  cleanup-test-tag:
+    name: Cleanup Test Tag
+    runs-on: ubuntu-latest
+    needs: [test-agent-flow-no-v-version, test-agent-flow-v-version, test-docs-flow]
+    if: always()
+    steps:
+      - name: Checkout action repository
+        uses: actions/checkout@v4
+
+      - name: Delete temporary tag
+        run: |
+          git config user.name "github-actions"
+          git config user.email "[email protected]"
+          git push origin :refs/tags/v0.0.0 || true

action.yml

@@ -6,7 +6,7 @@ inputs:
     required: false
     default: ''
   version:
-    description: 'Agent version in strict semver format MAJOR.MINOR.PATCH (ex. 1.2.3)'
+    description: 'Agent version in semver format (ex. 1.2.3 or v1.2.3). The action will prepend "v" if not present for tag checkout.'
     required: false
     default: ''
   cache:
@@ -16,10 +16,21 @@ inputs:
 runs:
   using: 'composite'
   steps:
+    - name: Normalize version tag for checkout
+      id: version
+      shell: bash
+      run: |
+        VERSION="${{ inputs.version }}"
+        if [[ -n "$VERSION" && ! "$VERSION" =~ ^v ]]; then
+          echo "ref=v${VERSION}" >> $GITHUB_OUTPUT
+        else
+          echo "ref=${VERSION}" >> $GITHUB_OUTPUT
+        fi
+
     - name: Checkout repository
       uses: actions/checkout@v4
       with:
-        ref: ${{ inputs.version }} # When ref is empty (as in docs scenario), this will default to checking out the commit that triggered the action
+        ref: ${{ steps.version.outputs.ref }} # When ref is empty (as in docs scenario), this will default to checking out the commit that triggered the action
 
     - name: Setup Go
       uses: actions/setup-go@v4

cmd/agent-metadata-action/main.go

@@ -30,10 +30,7 @@ func run() error {
 	}
 
 	agentType := os.Getenv("INPUT_AGENT_TYPE")
-	agentVersion, err := config.LoadVersion()
-	if err != nil {
-		return err
-	}
+	agentVersion := os.Getenv("INPUT_VERSION")
 
 	if agentType != "" && agentVersion != "" { // Scenario 1: Agent repo flow
 		fmt.Println("::debug::Agent scenario")

internal/config/metadata.go

@@ -3,18 +3,12 @@ package config
 import (
 	"fmt"
 	"os"
-	"regexp"
 
 	"agent-metadata-action/internal/github"
 	"agent-metadata-action/internal/models"
 	"agent-metadata-action/internal/parser"
 )
 
-// semverPattern validates strict semantic versioning format: MAJOR.MINOR.PATCH (e.g., 1.2.3)
-// Does not allow prerelease identifiers or build metadata
-// @todo may need to revisit if tags used by teams don't match semver
-var semverPattern = regexp.MustCompile(`^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)$`)
-
 // LoadMetadataForAgents loads metadata with only version populated
 func LoadMetadataForAgents(version string) models.Metadata {
 	return models.Metadata{
@@ -39,6 +33,11 @@ func LoadMetadataForDocs() ([]models.Metadata, error) {
 				return nil, fmt.Errorf("failed to parse MDX file %s: %w", filepath, err)
 			}
 
+			// Validate version is not blank
+			if frontMatter.Version == "" {
+				return nil, fmt.Errorf("version is required in metadata for file %s", filepath)
+			}
+
 			metadataArray = append(metadataArray, models.Metadata{
 				Version:                   frontMatter.Version,
 				Features:                  frontMatter.Features,
@@ -54,16 +53,3 @@ func LoadMetadataForDocs() ([]models.Metadata, error) {
 	}
 	return metadataArray, nil
 }
-
-// LoadVersion loads the version from INPUT_VERSION
-// Returns an error if a version is provided and it is not in valid X.Y.Z format
-func LoadVersion() (string, error) {
-	version := os.Getenv("INPUT_VERSION")
-
-	// Validate strict semver format (X.Y.Z only)
-	if version != "" && !semverPattern.MatchString(version) {
-		return "", fmt.Errorf("invalid version format: %s (must be X.Y.Z format, e.g., 1.2.3)", version)
-	}
-
-	return version, nil
-}

internal/config/metadata_test.go

@@ -11,86 +11,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestLoadVersion_ValidFormats(t *testing.T) {
-	tests := []struct {
-		name    string
-		version string
-	}{
-		{
-			name:    "standard version",
-			version: "1.2.3",
-		},
-		{
-			name:    "simple version",
-			version: "1.0.0",
-		},
-		{
-			name:    "large numbers",
-			version: "100.200.300",
-		},
-		{
-			name:    "zero version",
-			version: "0.0.0",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Setenv("INPUT_VERSION", tt.version)
-
-			version, err := LoadVersion()
-			require.NoError(t, err)
-			assert.Equal(t, tt.version, version)
-		})
-	}
-}
-
-func TestLoadVersion_InvalidFormats(t *testing.T) {
-	tests := []struct {
-		name    string
-		version string
-	}{
-		{
-			name:    "with v prefix",
-			version: "v1.2.3",
-		},
-		{
-			name:    "with prerelease",
-			version: "1.2.3-alpha",
-		},
-		{
-			name:    "with build metadata",
-			version: "1.2.3+build",
-		},
-		{
-			name:    "two components",
-			version: "1.2",
-		},
-		{
-			name:    "four components",
-			version: "1.2.3.4",
-		},
-		{
-			name:    "leading zero",
-			version: "01.2.3",
-		},
-		{
-			name:    "non-numeric",
-			version: "abc",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Setenv("INPUT_VERSION", tt.version)
-
-			_, err := LoadVersion()
-			assert.Error(t, err)
-			assert.Contains(t, err.Error(), "invalid version format")
-		})
-	}
-}
-
 func TestLoadMetadataForAgents(t *testing.T) {
 	t.Setenv("INPUT_AGENT_TYPE", "myagenttype")
 	t.Setenv("INPUT_VERSION", "1.2.3")
@@ -207,3 +127,45 @@ func TestLoadMetadata_NoMDXFiles_ReturnsEmptyMetadata(t *testing.T) {
 	require.NoError(t, err)
 	assert.Nil(t, metadata)
 }
+
+func TestLoadMetadata_MDXFileWithBlankVersion_ReturnsError(t *testing.T) {
+	// Create a temporary workspace
+	tmpWorkspace := t.TempDir()
+
+	// Create the release notes directory structure
+	releaseNotesDir := filepath.Join(tmpWorkspace, "src/content/docs/release-notes/agent-release-notes")
+	err := os.MkdirAll(releaseNotesDir, 0755)
+	require.NoError(t, err)
+
+	// Create test MDX file with blank version
+	mdxContent := `---
+subject: Test Agent
+releaseDate: '2024-01-15'
+version: ""
+features:
+  - New feature
+---
+
+# Test Release Notes
+`
+
+	mdxFile := filepath.Join(releaseNotesDir, "test-agent.mdx")
+	err = os.WriteFile(mdxFile, []byte(mdxContent), 0644)
+	require.NoError(t, err)
+
+	// Mock GetChangedMDXFiles to return our test file
+	originalFunc := github.GetChangedMDXFilesFunc
+	github.GetChangedMDXFilesFunc = func() ([]string, error) {
+		return []string{mdxFile}, nil
+	}
+	defer func() {
+		github.GetChangedMDXFilesFunc = originalFunc
+	}()
+
+	t.Setenv("GITHUB_WORKSPACE", tmpWorkspace)
+
+	// Load metadata - should fail due to blank version
+	_, err = LoadMetadataForDocs()
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "version is required")
+}