monir bug fix

Author: hrai-nr

e2e_tests/common-scripts.sh

@@ -112,8 +112,6 @@ validate_stack_resources_with_subscription() {
 
 validate_stack_resources_without_subscription() {
   local stack_name=$1
-  local log_group_name=$2
-
 
   log "Validating stack resources for stack: $stack_name"
   firehose_stream_physical_id=$(aws cloudformation describe-stack-resources \

e2e_tests/firehose_e2e_tests.sh

@@ -28,7 +28,7 @@ COMMON_ATTRIBUTES=$(<common_attribute.json)
   validate_stack_deployment_status "$FIREHOSE_STACK_NAME_1"
 
   # Validate the stack resources
-  validate_stack_resources_without_subscription "$FIREHOSE_STACK_NAME_1" "$LOG_GROUP_NAME_1"
+  validate_stack_resources_without_subscription "$FIREHOSE_STACK_NAME_1"
 
   # Generate a UUID and create a dynamic log message
   UUID=$(uuidgen)
@@ -112,7 +112,7 @@ LOG_GROUP_INVALID_JSON=$(<invalid_log_group.json)
   deploy_firehose_stack "$template_file" "$FIREHOSE_STACK_NAME_3" "$NEW_RELIC_LICENSE_KEY" "$NEW_RELIC_REGION" "$NEW_RELIC_ACCOUNT_ID" "true" "$LOG_GROUP_INVALID_JSON" "''"
 
   # Validate the status of the Firehose stack
-  validate_stack_deployment_status "$FIREHOSE_STACK_NAME_3"
+  validate_stack_resources_without_subscription "$FIREHOSE_STACK_NAME_3"
 
   # Validate the stack resources
   validate_stack_resources "$FIREHOSE_STACK_NAME_3" "true" "''" "''"

e2e_tests/log_validation.sh

@@ -39,7 +39,7 @@ validate_logs_in_new_relic() {
   sleep_time=$SLEEP_TIME
   max_attempts=5
 
-  for i in {1..$max_attempts}; do
+  for ((i=1; i<=max_attempts; i++)); do
     local response=$(curl -s -X POST \
       -H "Content-Type: application/json" \
       -H "API-Key: $user_key" \
@@ -91,7 +91,7 @@ validate_logs_meta_data (){
         exit_with_error "Entity synthesis attribute $new_key with value $value not found in New Relic logs."
       fi
     fi
-  done < entiy_synthesis_param.cfg
+  done < entity_synthesis_param.cfg
 
   log "Entity synthesis parameter validated successfully."
 }