From fa3564fd83f77d7df37efed1ac81b619193d49fc Mon Sep 17 00:00:00 2001 From: Carl Stutz Date: Tue, 4 Dec 2018 11:02:58 -0800 Subject: [PATCH 1/3] Reduce logging level for secrets so that unless you are specifically troubleshooting you wont see container configurations during a deploy. --- lib/centurion/deploy.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/centurion/deploy.rb b/lib/centurion/deploy.rb index 74b8c450..01ab4e16 100644 --- a/lib/centurion/deploy.rb +++ b/lib/centurion/deploy.rb @@ -109,9 +109,10 @@ def start_new_container(server, service, restart_policy) info "Starting new container #{container['Id'][0..7]}" server.start_container(container['Id'], host_config) - info "Inspecting new container #{container['Id'][0..7]}:" + # since this likely contains secrets we don't want to be always printing configurations + debug "Inspecting new container #{container['Id'][0..7]}:" (server.inspect_container(container['Id']) || {}).each_pair do |key,value| - info "\t#{key} => #{value.inspect}" + debug "\t#{key} => #{value.inspect}" end container From fa538315647e547ec03dbf5b97187ab179d51975 Mon Sep 17 00:00:00 2001 From: Carl Stutz Date: Tue, 4 Dec 2018 15:21:06 -0800 Subject: [PATCH 2/3] Add a comment about starting up the container if it gets to the point of successfully starting. --- lib/centurion/deploy.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/centurion/deploy.rb b/lib/centurion/deploy.rb index 01ab4e16..6df86428 100644 --- a/lib/centurion/deploy.rb +++ b/lib/centurion/deploy.rb @@ -108,6 +108,7 @@ def start_new_container(server, service, restart_policy) info "Starting new container #{container['Id'][0..7]}" server.start_container(container['Id'], host_config) + info "Container #{container['Id'][0..7]} successfully" # since this likely contains secrets we don't want to be always printing configurations debug "Inspecting new container #{container['Id'][0..7]}:" From eb178c2d60954a4a643b944ff79a09fe5f1ac0bc Mon Sep 17 00:00:00 2001 From: Carl Stutz Date: Tue, 4 Dec 2018 15:21:59 -0800 Subject: [PATCH 3/3] Apparently need coffee. --- lib/centurion/deploy.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/centurion/deploy.rb b/lib/centurion/deploy.rb index 6df86428..179646df 100644 --- a/lib/centurion/deploy.rb +++ b/lib/centurion/deploy.rb @@ -108,7 +108,7 @@ def start_new_container(server, service, restart_policy) info "Starting new container #{container['Id'][0..7]}" server.start_container(container['Id'], host_config) - info "Container #{container['Id'][0..7]} successfully" + info "Started #{container['Id'][0..7]} successfully" # since this likely contains secrets we don't want to be always printing configurations debug "Inspecting new container #{container['Id'][0..7]}:"