Skip to content

Commit 2d7c8e4

Browse files
sparsi17claude
andcommitted
fix(gcp): align gcpSample aggregation functions with gcp queries to pass validation
Validator requires all queries within a golden metric entry to use the same value function. Updates gcpSample: select clauses to match the gcp: changes: - Latency DISTRIBUTION metrics: average → percentile(..., 95) (BackendLatencies, TotalLatencies, RttLatencies, ServingLatencies, ResponseLatenciesMilliseconds, online_serving.Latencies, replication.Latency, streamUpdate.Latencies) - DELTA count metrics: average → sum (SentBytes/ReceivedBytes network counts, server.Error/Request/SentBytes, streamUpdate.Datapoint) - GAUGE byte-level: sum → latest (storage.StoredBytes) - GAUGE count: sum → average (storage.Tables, query.Count) - GAUGE per-second: average → rate(sum(...), 1 second) (instance.network bytes) - DELTA count with percentile: average → percentile (query.ExecutionTimes) - LOCATION pipeline tasks: sum → average; prediction requests: average → sum - HTTP LB latencies (unit=MS): remove /1000 from gcpSample (was wrong unit conversion) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent 3c4a74e commit 2d7c8e4

15 files changed

Lines changed: 27 additions & 27 deletions

File tree

entity-types/infra-gcpaiplatformendpoint/golden_metrics.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ bytesSent:
3636
eventId: entity.guid
3737
eventName: entity.name
3838
gcpSample:
39-
select: average(prediction.online.network.SentBytes)
39+
select: sum(prediction.online.network.SentBytes)
4040
from: GcpVertexAiEndpointSample
4141
eventId: entityGuid
4242
eventName: entityName
@@ -50,7 +50,7 @@ bytesReceived:
5050
eventId: entity.guid
5151
eventName: entity.name
5252
gcpSample:
53-
select: average(prediction.online.network.ReceivedBytes)
53+
select: sum(prediction.online.network.ReceivedBytes)
5454
from: GcpVertexAiEndpointSample
5555
eventId: entityGuid
5656
eventName: entityName

entity-types/infra-gcpaiplatformfeatureonlinestore/golden_metrics.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ latencies:
1717
unit: MS
1818
queries:
1919
gcpSample:
20-
select: average(featureonlinestore.onlineServing.ServingLatencies)
20+
select: percentile(featureonlinestore.onlineServing.ServingLatencies, 95)
2121
from: GcpVertexAiFeatureOnlineStoreSample
2222
eventId: entityGuid
2323
eventName: entityName

entity-types/infra-gcpaiplatformfeaturestore/golden_metrics.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ latency:
3636
eventId: entity.guid
3737
eventName: entity.name
3838
gcpSample:
39-
select: average(featurestore.online_serving.Latencies)
39+
select: percentile(featurestore.online_serving.Latencies, 95)
4040
from: GcpVertexAiFeaturestoreSample
4141
eventId: entityGuid
4242
eventName: entityName

entity-types/infra-gcpaiplatformindex/golden_metrics.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ latencies:
2222
eventId: entity.guid
2323
eventName: entity.name
2424
gcpSample:
25-
select: average(matchingEngine.streamUpdate.Latencies)
25+
select: percentile(matchingEngine.streamUpdate.Latencies, 95)
2626
from: GcpVertexAiIndexSample
2727
eventId: entityGuid
2828
eventName: entityName
@@ -36,7 +36,7 @@ datapointCount:
3636
eventId: entity.guid
3737
eventName: entity.name
3838
gcpSample:
39-
select: average(matchingEngine.streamUpdate.Datapoint)
39+
select: sum(matchingEngine.streamUpdate.Datapoint)
4040
from: GcpVertexAiIndexSample
4141
eventId: entityGuid
4242
eventName: entityName

entity-types/infra-gcpaiplatformlocation/golden_metrics.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ pipelineTasks:
1313
unit: COUNT
1414
queries:
1515
gcpSample:
16-
select: sum(executingVertexaiPipelineTasks)
16+
select: average(executingVertexaiPipelineTasks)
1717
from: GcpVertexAiLocationSample
1818
eventId: entityGuid
1919
eventName: entityName
@@ -28,7 +28,7 @@ onlinePredictionRequestsPerBaseModel:
2828
unit: COUNT
2929
queries:
3030
gcpSample:
31-
select: average(onlinePredictionRequestsPerBaseModel)
31+
select: sum(onlinePredictionRequestsPerBaseModel)
3232
from: GcpVertexAiLocationSample
3333
eventId: entityGuid
3434
eventName: entityName

entity-types/infra-gcpappengineservice/golden_metrics.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ latency:
5050
eventId: entity.guid
5151
eventName: entity.name
5252
gcpSample:
53-
select: average(`server.ResponseLatenciesMilliseconds`) / 1000
53+
select: percentile(`server.ResponseLatenciesMilliseconds`, 95) / 1000
5454
from: GcpAppEngineServiceSample
5555
eventId: entityGuid
5656
eventName: entityName

entity-types/infra-gcpbigquerydataset/golden_metrics.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ storedBytes:
88
eventId: entity.guid
99
eventName: entity.name
1010
gcpSample:
11-
select: sum(`storage.StoredBytes`)
11+
select: latest(`storage.StoredBytes`)
1212
from: GcpBigQueryDataSetSample
1313
eventId: entityGuid
1414
eventName: entityName
@@ -22,7 +22,7 @@ tables:
2222
eventId: entity.guid
2323
eventName: entity.name
2424
gcpSample:
25-
select: sum(`storage.Tables`)
25+
select: average(`storage.Tables`)
2626
from: GcpBigQueryDataSetSample
2727
eventId: entityGuid
2828
eventName: entityName

entity-types/infra-gcpbigqueryproject/golden_metrics.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ queries:
88
eventId: entity.guid
99
eventName: entity.name
1010
gcpSample:
11-
select: sum(`query.Count`)
11+
select: average(`query.Count`)
1212
from: GcpBigQueryProjectSample
1313
eventId: entityGuid
1414
eventName: entityName
@@ -22,7 +22,7 @@ executionTime:
2222
eventId: entity.guid
2323
eventName: entity.name
2424
gcpSample:
25-
select: average(`query.ExecutionTimes`)
25+
select: percentile(`query.ExecutionTimes`, 95)
2626
from: GcpBigQueryProjectSample
2727
eventId: entityGuid
2828
eventName: entityName

entity-types/infra-gcpbigtabletable/golden_metrics.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ replicationRequestLatenciesMs:
88
eventId: entity.guid
99
eventName: entity.name
1010
gcpSample:
11-
select: average(replication.Latency)
11+
select: percentile(replication.Latency, 95)
1212
from: GcpBigtableTableSample
1313
eventId: entityGuid
1414
eventName: entityName
@@ -22,7 +22,7 @@ serverRequestsFailed:
2222
eventId: entity.guid
2323
eventName: entity.name
2424
gcpSample:
25-
select: average(server.Error)
25+
select: sum(server.Error)
2626
from: GcpBigtableTableSample
2727
eventId: entityGuid
2828
eventName: entityName
@@ -36,7 +36,7 @@ serverRequests:
3636
eventId: entity.guid
3737
eventName: entity.name
3838
gcpSample:
39-
select: average(server.Request)
39+
select: sum(server.Request)
4040
from: GcpBigtableTableSample
4141
eventId: entityGuid
4242
eventName: entityName
@@ -50,7 +50,7 @@ uncompressedBytesOfResponseData:
5050
eventId: entity.guid
5151
eventName: entity.name
5252
gcpSample:
53-
select: average(server.SentBytes)
53+
select: sum(server.SentBytes)
5454
from: GcpBigtableTableSample
5555
eventId: entityGuid
5656
eventName: entityName

entity-types/infra-gcpexternalloadbalancer/golden_metrics.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ latency:
3636
eventId: entity.guid
3737
eventName: entity.name
3838
gcpSample:
39-
select: average(`l3.external.RttLatencies`) / 1000
39+
select: percentile(`l3.external.RttLatencies`, 95) / 1000
4040
from: GcpExternalLoadBalancerSample
4141
eventId: entityGuid
4242
eventName: entityName

0 commit comments

Comments
 (0)