Skip to content

Commit 8acf3ec

Browse files
authored
Merge branch 'main' into fix/gcp-prefix-fixes
2 parents 43e4f3a + c3a8d2f commit 8acf3ec

41 files changed

Lines changed: 1116 additions & 449 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

entity-types/infra-gcpcloudrunrevision/dashboard.json

Lines changed: 0 additions & 186 deletions
This file was deleted.

entity-types/infra-gcpcloudrunrevision/definition.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

entity-types/infra-gcprunrevision/definition.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
domain: INFRA
22
type: GCPRUNREVISION
3+
goldenTags:
4+
- gcp.projectId
5+
- gcp.region
36
configuration:
47
entityExpirationTime: DAILY
58
alertable: true

entity-types/infra-gcpcloudrunrevision/golden_metrics.yml renamed to entity-types/infra-gcprunrevision/golden_metrics.yml

File renamed without changes.

entity-types/infra-gcpcloudrunrevision/summary_metrics.yml renamed to entity-types/infra-gcprunrevision/summary_metrics.yml

File renamed without changes.

entity-types/infra-ibmmq_manager/definition.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ type: IBMMQ_MANAGER
33

44
synthesis:
55
rules:
6-
# nri-mq rules: native identity = targetName:qmgr. OTel excluded via instrumentation.provider absent
7-
# so nri-mq and OpenTelemetry never double-synthesize the same queue manager.
6+
# nri-mq rules: identity targetName:qmgr.
87
- ruleName: infra_ibmmq_manager_nri_1
98
compositeIdentifier:
109
separator: ":"
@@ -17,10 +16,9 @@ synthesis:
1716
value: Metric
1817
- attribute: metricName
1918
prefix: ibmmq_qmgr
20-
- attribute: instrumentation.provider
21-
present: false
2219
tags:
2320
clusterName:
21+
instrumentation.provider:
2422

2523
- ruleName: infra_ibmmq_manager_nri_2
2624
compositeIdentifier:
@@ -34,10 +32,9 @@ synthesis:
3432
value: Metric
3533
- attribute: metricName
3634
prefix: ibmmq_channel
37-
- attribute: instrumentation.provider
38-
present: false
3935
tags:
4036
clusterName:
37+
instrumentation.provider:
4138

4239
- ruleName: infra_ibmmq_manager_nri_3
4340
compositeIdentifier:
@@ -51,10 +48,9 @@ synthesis:
5148
value: Metric
5249
- attribute: metricName
5350
prefix: ibmmq_subscription
54-
- attribute: instrumentation.provider
55-
present: false
5651
tags:
5752
clusterName:
53+
instrumentation.provider:
5854

5955
# OpenTelemetry rule (Prometheus receiver): identity keyed on host.id (== target.name in OTel data).
6056
# target.name is the fallback when host.id is absent (see *_fallback); mutually exclusive via

entity-types/infra-ibmmq_manager/tests/Metric.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,16 @@
66
"qmgr": "QM1",
77
"newrelic.source": "metricAPI"
88
},
9+
{
10+
"host.name": "mq-host-01",
11+
"metricName": "ibmmq_qmgr_status",
12+
"targetName": "mq-host-01:9157",
13+
"qmgr": "QM2",
14+
"instrumentation.name": "ibmmq",
15+
"instrumentation.provider": "newRelic",
16+
"instrumentation.version": "0.4.3",
17+
"newrelic.source": "metricAPI"
18+
},
919
{
1020
"metricName": "ibmmq_qmgr_connection_count",
1121
"instrumentation.provider": "opentelemetry",

entity-types/infra-ibmmq_queue/definition.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ goldenTags:
55

66
synthesis:
77
rules:
8-
# nri-mq rule: native identity = targetName:qmgr:queue. OTel excluded via instrumentation.provider
9-
# absent so nri-mq and OpenTelemetry never double-synthesize the same queue.
8+
# nri-mq rule: identity targetName:qmgr:queue.
109
- ruleName: infra_ibmmq_queue_nri_1
1110
compositeIdentifier:
1211
separator: ":"
@@ -26,10 +25,9 @@ synthesis:
2625
value: Metric
2726
- attribute: metricName
2827
prefix: ibmmq_queue
29-
- attribute: instrumentation.provider
30-
present: false
3128
tags:
3229
qmgr:
30+
instrumentation.provider:
3331

3432
# OpenTelemetry rule (Prometheus receiver): identity keyed on host.id:qmgr:queue (host.id ==
3533
# target.name in OTel data); target.name is the fallback when host.id is absent (see *_fallback);

entity-types/infra-ibmmq_queue/tests/Metric.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,17 @@
77
"queue": "DEV.QUEUE.1",
88
"newrelic.source": "metricAPI"
99
},
10+
{
11+
"host.name": "mq-host-01",
12+
"metricName": "ibmmq_queue_depth",
13+
"targetName": "mq-host-01:9157",
14+
"qmgr": "QM2",
15+
"queue": "DEV.QUEUE.2",
16+
"instrumentation.name": "ibmmq",
17+
"instrumentation.provider": "newRelic",
18+
"instrumentation.version": "0.4.3",
19+
"newrelic.source": "metricAPI"
20+
},
1021
{
1122
"metricName": "ibmmq_queue_depth",
1223
"instrumentation.provider": "opentelemetry",

0 commit comments

Comments
 (0)